From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: 19.11.11 patches review and test
Date: Fri, 17 Dec 2021 18:57:24 +0100 [thread overview]
Message-ID: <CAATJJ0KzM1tw2OZ_rCY2BWQZJeT5NRTZQpp3ET_1HRAy4PuMHA@mail.gmail.com> (raw)
In-Reply-To: <8b6f88e7214d481b86eaef093d438204@intel.com>
On Fri, Dec 17, 2021 at 4:48 PM Richardson, Bruce
<bruce.richardson@intel.com> wrote:
>
>
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Friday, December 17, 2021 2:56 PM
> > To: 'Christian Ehrhardt' <christian.ehrhardt@canonical.com>
> > Cc: stable@dpdk.org
> > Subject: RE: 19.11.11 patches review and test
> >
> > Hi Christian,
> >
> > just tried compiling latest 19.11 branch in dpdk-stable tree (which is
> > your 19.11.11-rc1 commit) on FreeBSD 13, and see the following error:
> >
> > [11/1452] Compiling C object
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> > FAILED: lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> > cc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config -
> > Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -
> > I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common -
> > I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -
> > I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -
> > I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -fcolor-
> > diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -
> > include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-
> > nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -
> > Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -
> > Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -
> > Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -
> > march=native -DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -MF
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o.d -o
> > lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -c
> > ../lib/librte_eal/common/eal_common_options.c
> > ../lib/librte_eal/common/eal_common_options.c:1499:2: error: implicit
> > declaration of function 'CPU_NAND' is invalid in C99 [-Werror,-Wimplicit-
> > function-declaration]
> >
> > It looks to me that commit 9ed3385f "eal/freebsd: update CPU macro for
> > FreeBSD 13" needs to be applied to 19.11 branch.
> >
> > Other errors on FreeBSD 13 have been reported too, I'm looking into those.
>
> Looks like 03bff90ccfd6 ("contigmem: update for FreeBSD 13") could do with being cherry-picked too for 19.11.
>
> With that done (2 patches cherry-picked, and one additional patch applied that I have just sent), I get a clean build on FBSD 13.
They all look safe to me, applied all three now.
I have started build tests...
Not sure if I can tag -rc2 today, but if not today then still soon
(many build time fixes from many people since -rc1).
> Regards,
> /Bruce
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
next prev parent reply other threads:[~2021-12-17 17:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:43 christian.ehrhardt
2021-12-13 4:14 ` Kalesh Anakkur Purayil
2021-12-13 11:06 ` Ferruh Yigit
2021-12-13 12:39 ` Christian Ehrhardt
2021-12-13 12:58 ` Ferruh Yigit
2021-12-13 13:32 ` Christian Ehrhardt
2021-12-13 13:49 ` Kalesh Anakkur Purayil
2021-12-13 14:07 ` Ferruh Yigit
2021-12-14 5:49 ` Kalesh Anakkur Purayil
2021-12-14 7:44 ` Christian Ehrhardt
2021-12-14 10:13 ` Ferruh Yigit
2021-12-14 11:39 ` Christian Ehrhardt
2021-12-14 12:08 ` Ferruh Yigit
2021-12-14 13:57 ` Christian Ehrhardt
2021-12-14 13:10 ` Ferruh Yigit
2021-12-14 13:58 ` Christian Ehrhardt
2021-12-14 14:46 ` Christian Ehrhardt
2021-12-14 14:52 ` Ferruh Yigit
2021-12-15 13:17 ` Christian Ehrhardt
2021-12-15 14:44 ` Ferruh Yigit
2021-12-16 7:21 ` Christian Ehrhardt
2021-12-14 7:14 ` Jiang, YuX
2021-12-14 7:45 ` Christian Ehrhardt
2021-12-14 8:05 ` Christian Ehrhardt
2021-12-15 11:04 ` Jiang, YuX
2021-12-15 13:16 ` Christian Ehrhardt
2021-12-17 7:05 ` Jiang, YuX
2021-12-17 7:47 ` Christian Ehrhardt
2021-12-17 14:55 ` Richardson, Bruce
2021-12-17 15:48 ` Richardson, Bruce
2021-12-17 17:57 ` Christian Ehrhardt [this message]
2021-12-14 13:51 ` Pei Zhang
2021-12-14 13:52 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0KzM1tw2OZ_rCY2BWQZJeT5NRTZQpp3ET_1HRAy4PuMHA@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=bruce.richardson@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).