* |WARNING| pw114641 [PATCH 18/21] net/softnic: add the pipeline meter CLI commands
[not found] <20220804165839.1074817-19-cristian.dumitrescu@intel.com>
@ 2022-08-04 17:03 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-08-04 17:03 UTC (permalink / raw)
To: test-report; +Cc: Cristian Dumitrescu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114641
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#268: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1711:
+ if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#291: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1734:
+ * ^Iprofile <profile_name>$
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#337: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1780:
+ if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'idx1 < idx0'
#413: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1856:
+ if (parser_read_uint32(&idx1, tokens[7]) || (idx1 < idx0)) {
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#457: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1900:
+ snprintf(out, out_size, "| %7d | %16" PRIx64 " | %16" PRIx64 " | %16" PRIx64
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#479: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2161:
+ if ((n_tokens >= 6) &&
+ !strcmp(tokens[2], "meter") &&
+ !strcmp(tokens[3], "profile") &&
+ !strcmp(tokens[5], "add")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#488: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2170:
+ if ((n_tokens >= 6) &&
+ !strcmp(tokens[2], "meter") &&
+ !strcmp(tokens[3], "profile") &&
+ !strcmp(tokens[5], "delete")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#497: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2179:
+ if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "reset")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#502: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2184:
+ if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "set")) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 9'
#507: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2189:
+ if ((n_tokens >= 9) && !strcmp(tokens[2], "meter") && !strcmp(tokens[8], "stats")) {
total: 0 errors, 1 warnings, 9 checks, 435 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-04 17:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220804165839.1074817-19-cristian.dumitrescu@intel.com>
2022-08-04 17:03 ` |WARNING| pw114641 [PATCH 18/21] net/softnic: add the pipeline meter CLI commands checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).