* [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler
2017-12-27 20:22 [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Qi Zhang
@ 2017-12-27 20:22 ` Qi Zhang
2018-01-12 2:32 ` Dai, Wei
2018-01-13 16:14 ` Zhang, Helin
2017-12-28 4:38 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: " Dai, Wei
` (3 subsequent siblings)
4 siblings, 2 replies; 10+ messages in thread
From: Qi Zhang @ 2017-12-27 20:22 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: dev, wei.dai, liang-min.wang, Qi Zhang, stable
Mailbox interrupt handler only take care of the PF reset notification,
for other message mbx->ops.read should not be called since it get chance
to break the foreground VF to PF communication.
Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/e1000/igb_ethdev.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index fdc139f..0d8bc49 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -2970,13 +2970,17 @@ void igbvf_mbx_process(struct rte_eth_dev *dev)
struct e1000_mbx_info *mbx = &hw->mbx;
u32 in_msg = 0;
- if (mbx->ops.read(hw, &in_msg, 1, 0))
- return;
+ /* peek the message first */
+ in_msg = E1000_READ_REG(hw, E1000_VMBMEM(0));
/* PF reset VF event */
- if (in_msg == E1000_PF_CONTROL_MSG)
+ if (in_msg == E1000_PF_CONTROL_MSG) {
+ /* dummy mbx read to ack pf */
+ if (mbx->ops.read(hw, &in_msg, 1, 0))
+ return;
_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET,
NULL, NULL);
+ }
}
static int
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler
2017-12-27 20:22 ` [dpdk-dev] [PATCH 2/2] net/e1000: " Qi Zhang
@ 2018-01-12 2:32 ` Dai, Wei
2018-01-13 16:14 ` Zhang, Helin
1 sibling, 0 replies; 10+ messages in thread
From: Dai, Wei @ 2018-01-12 2:32 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo; +Cc: dev, Wang, Liang-min, stable
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, December 28, 2017 4:23 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Wang, Liang-min
> <liang-min.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 2/2] net/e1000: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of the PF reset notification, for
> other message mbx->ops.read should not be called since it get chance to
> break the foreground VF to PF communication.
>
> Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link
> up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index fdc139f..0d8bc49 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -2970,13 +2970,17 @@ void igbvf_mbx_process(struct rte_eth_dev
> *dev)
> struct e1000_mbx_info *mbx = &hw->mbx;
> u32 in_msg = 0;
>
> - if (mbx->ops.read(hw, &in_msg, 1, 0))
> - return;
> + /* peek the message first */
> + in_msg = E1000_READ_REG(hw, E1000_VMBMEM(0));
>
> /* PF reset VF event */
> - if (in_msg == E1000_PF_CONTROL_MSG)
> + if (in_msg == E1000_PF_CONTROL_MSG) {
> + /* dummy mbx read to ack pf */
> + if (mbx->ops.read(hw, &in_msg, 1, 0))
> + return;
> _rte_eth_dev_callback_process(dev,
> RTE_ETH_EVENT_INTR_RESET,
> NULL, NULL);
> + }
> }
>
> static int
> --
> 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler
2017-12-27 20:22 ` [dpdk-dev] [PATCH 2/2] net/e1000: " Qi Zhang
2018-01-12 2:32 ` Dai, Wei
@ 2018-01-13 16:14 ` Zhang, Helin
1 sibling, 0 replies; 10+ messages in thread
From: Zhang, Helin @ 2018-01-13 16:14 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo
Cc: dev, Dai, Wei, Wang, Liang-min, Zhang, Qi Z, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> Sent: Thursday, December 28, 2017 4:23 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of the PF reset notification, for other
> message mbx->ops.read should not be called since it get chance to break the
> foreground VF to PF communication.
>
> Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, with minor commit log changes. Thanks!
/Helin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
2017-12-27 20:22 [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Qi Zhang
2017-12-27 20:22 ` [dpdk-dev] [PATCH 2/2] net/e1000: " Qi Zhang
@ 2017-12-28 4:38 ` Dai, Wei
2018-01-11 8:07 ` Zhang, Qi Z
2018-01-12 2:30 ` Dai, Wei
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Dai, Wei @ 2017-12-28 4:38 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo; +Cc: dev, Wang, Liang-min, stable
According to step 7 & 8 in Table 7-74 PF-to-VF Messaging Flow in 82599 datasheet,
The calling of ixgbe_read_mbx( ) can be replaced by following lines to avoid touching ->mbx.v2p_mailbox,
IXGBE_WRITE_REG(hw, IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_ACK);
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, December 28, 2017 4:22 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Wang, Liang-min
> <liang-min.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of PF reset notification, for other
> message ixgbe_read_mbx should not be called since it get chance to break
> the foreground VF to PF communication.
> This can be simply repeated by
> testpmd>rx_vlan rm all 0
>
> Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff19a56..02121f4 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct
> rte_eth_dev *dev)
> struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> u32 in_msg = 0;
>
> - if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> - return;
> + /* peek the message first */
> + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM);
>
> /* PF reset VF event */
> - if (in_msg == IXGBE_PF_CONTROL_MSG)
> + if (in_msg == IXGBE_PF_CONTROL_MSG) {
> + /* dummy mbx read to ack pf */
> + if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> + return;
> _rte_eth_dev_callback_process(dev,
> RTE_ETH_EVENT_INTR_RESET,
> NULL, NULL);
> + }
> }
>
> static int
> --
> 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
2017-12-28 4:38 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: " Dai, Wei
@ 2018-01-11 8:07 ` Zhang, Qi Z
2018-01-12 2:29 ` Dai, Wei
0 siblings, 1 reply; 10+ messages in thread
From: Zhang, Qi Z @ 2018-01-11 8:07 UTC (permalink / raw)
To: Dai, Wei, Lu, Wenzhuo; +Cc: dev, Wang, Liang-min, stable
> -----Original Message-----
> From: Dai, Wei
> Sent: Thursday, December 28, 2017 12:39 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Wang, Liang-min <liang-min.wang@intel.com>;
> stable@dpdk.org
> Subject: RE: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
> According to step 7 & 8 in Table 7-74 PF-to-VF Messaging Flow in 82599
> datasheet, The calling of ixgbe_read_mbx( ) can be replaced by following lines
> to avoid touching ->mbx.v2p_mailbox, IXGBE_WRITE_REG(hw,
> IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_ACK);
Thanks for the suggestion.
I think the patch try to keep things unchanged when a PF reset happen, but it is not going to cover the case that PF reset interrupt and a foreground VF to PF request happen simultaneously which is an knowing issue
Your suggestion may help on that, but it is not a complete fix. I think it will be better to have a separate patch that focus on it.
Regards
Qi
>
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Thursday, December 28, 2017 4:22 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Wang, Liang-min
> > <liang-min.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
> >
> > Mailbox interrupt handler only take care of PF reset notification, for
> > other message ixgbe_read_mbx should not be called since it get chance
> > to break the foreground VF to PF communication.
> > This can be simply repeated by
> > testpmd>rx_vlan rm all 0
> >
> > Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> > up/down")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ff19a56..02121f4 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct
> > rte_eth_dev *dev)
> > struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > u32 in_msg = 0;
> >
> > - if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> > - return;
> > + /* peek the message first */
> > + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM);
> >
> > /* PF reset VF event */
> > - if (in_msg == IXGBE_PF_CONTROL_MSG)
> > + if (in_msg == IXGBE_PF_CONTROL_MSG) {
> > + /* dummy mbx read to ack pf */
> > + if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> > + return;
> > _rte_eth_dev_callback_process(dev,
> > RTE_ETH_EVENT_INTR_RESET,
> > NULL, NULL);
> > + }
> > }
> >
> > static int
> > --
> > 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
2018-01-11 8:07 ` Zhang, Qi Z
@ 2018-01-12 2:29 ` Dai, Wei
0 siblings, 0 replies; 10+ messages in thread
From: Dai, Wei @ 2018-01-12 2:29 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo; +Cc: dev, Wang, Liang-min, stable
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, January 11, 2018 4:08 PM
> To: Dai, Wei <wei.dai@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Wang, Liang-min <liang-min.wang@intel.com>;
> stable@dpdk.org
> Subject: RE: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
>
>
> > -----Original Message-----
> > From: Dai, Wei
> > Sent: Thursday, December 28, 2017 12:39 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>
> > Cc: dev@dpdk.org; Wang, Liang-min <liang-min.wang@intel.com>;
> > stable@dpdk.org
> > Subject: RE: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
> >
> > According to step 7 & 8 in Table 7-74 PF-to-VF Messaging Flow in 82599
> > datasheet, The calling of ixgbe_read_mbx( ) can be replaced by
> > following lines to avoid touching ->mbx.v2p_mailbox,
> > IXGBE_WRITE_REG(hw, IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_ACK);
>
> Thanks for the suggestion.
>
> I think the patch try to keep things unchanged when a PF reset happen, but it
> is not going to cover the case that PF reset interrupt and a foreground VF to
> PF request happen simultaneously which is an knowing issue Your suggestion
> may help on that, but it is not a complete fix. I think it will be better to have
> a separate patch that focus on it.
Agree with you.
>
> Regards
> Qi
> >
> > > -----Original Message-----
> > > From: Zhang, Qi Z
> > > Sent: Thursday, December 28, 2017 4:22 AM
> > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Wang, Liang-min
> > > <liang-min.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > > stable@dpdk.org
> > > Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
> > >
> > > Mailbox interrupt handler only take care of PF reset notification,
> > > for other message ixgbe_read_mbx should not be called since it get
> > > chance to break the foreground VF to PF communication.
> > > This can be simply repeated by
> > > testpmd>rx_vlan rm all 0
> > >
> > > Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for
> > > link
> > > up/down")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> > > ---
> > > drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> > > 1 file changed, 7 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > index ff19a56..02121f4 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct
> > > rte_eth_dev *dev)
> > > struct ixgbe_hw *hw =
> > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > > u32 in_msg = 0;
> > >
> > > - if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> > > - return;
> > > + /* peek the message first */
> > > + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM);
> > >
> > > /* PF reset VF event */
> > > - if (in_msg == IXGBE_PF_CONTROL_MSG)
> > > + if (in_msg == IXGBE_PF_CONTROL_MSG) {
> > > + /* dummy mbx read to ack pf */
> > > + if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> > > + return;
> > > _rte_eth_dev_callback_process(dev,
> > > RTE_ETH_EVENT_INTR_RESET,
> > > NULL, NULL);
> > > + }
> > > }
> > >
> > > static int
> > > --
> > > 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
2017-12-27 20:22 [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Qi Zhang
2017-12-27 20:22 ` [dpdk-dev] [PATCH 2/2] net/e1000: " Qi Zhang
2017-12-28 4:38 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: " Dai, Wei
@ 2018-01-12 2:30 ` Dai, Wei
2018-01-13 6:27 ` Zhang, Helin
2018-01-13 16:13 ` Zhang, Helin
4 siblings, 0 replies; 10+ messages in thread
From: Dai, Wei @ 2018-01-12 2:30 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo; +Cc: dev, Wang, Liang-min, stable
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, December 28, 2017 4:22 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Wang, Liang-min
> <liang-min.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of PF reset notification, for other
> message ixgbe_read_mbx should not be called since it get chance to break
> the foreground VF to PF communication.
> This can be simply repeated by
> testpmd>rx_vlan rm all 0
>
> Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff19a56..02121f4 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct
> rte_eth_dev *dev)
> struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> u32 in_msg = 0;
>
> - if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> - return;
> + /* peek the message first */
> + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM);
>
> /* PF reset VF event */
> - if (in_msg == IXGBE_PF_CONTROL_MSG)
> + if (in_msg == IXGBE_PF_CONTROL_MSG) {
> + /* dummy mbx read to ack pf */
> + if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> + return;
> _rte_eth_dev_callback_process(dev,
> RTE_ETH_EVENT_INTR_RESET,
> NULL, NULL);
> + }
> }
>
> static int
> --
> 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
2017-12-27 20:22 [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Qi Zhang
` (2 preceding siblings ...)
2018-01-12 2:30 ` Dai, Wei
@ 2018-01-13 6:27 ` Zhang, Helin
2018-01-13 16:13 ` Zhang, Helin
4 siblings, 0 replies; 10+ messages in thread
From: Zhang, Helin @ 2018-01-13 6:27 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo
Cc: dev, Dai, Wei, Wang, Liang-min, Zhang, Qi Z, stable
Hi Qi
Could you help to rebase on the latest dpdk-next-net-intel? It cannot be applied now. Thanks!
Regards,
Helin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> Sent: Thursday, December 28, 2017 4:22 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of PF reset notification, for other
> message ixgbe_read_mbx should not be called since it get chance to break the
> foreground VF to PF communication.
> This can be simply repeated by
> testpmd>rx_vlan rm all 0
>
> Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff19a56..02121f4 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -8165,13 +8165,17 @@ static void ixgbevf_mbx_process(struct
> rte_eth_dev *dev)
> struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> u32 in_msg = 0;
>
> - if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> - return;
> + /* peek the message first */
> + in_msg = IXGBE_READ_REG(hw, IXGBE_VFMBMEM);
>
> /* PF reset VF event */
> - if (in_msg == IXGBE_PF_CONTROL_MSG)
> + if (in_msg == IXGBE_PF_CONTROL_MSG) {
> + /* dummy mbx read to ack pf */
> + if (ixgbe_read_mbx(hw, &in_msg, 1, 0))
> + return;
> _rte_eth_dev_callback_process(dev,
> RTE_ETH_EVENT_INTR_RESET,
> NULL, NULL);
> + }
> }
>
> static int
> --
> 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
2017-12-27 20:22 [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler Qi Zhang
` (3 preceding siblings ...)
2018-01-13 6:27 ` Zhang, Helin
@ 2018-01-13 16:13 ` Zhang, Helin
4 siblings, 0 replies; 10+ messages in thread
From: Zhang, Helin @ 2018-01-13 16:13 UTC (permalink / raw)
To: Zhang, Qi Z, Lu, Wenzhuo
Cc: dev, Dai, Wei, Wang, Liang-min, Zhang, Qi Z, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> Sent: Thursday, December 28, 2017 4:22 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Dai, Wei; Wang, Liang-min; Zhang, Qi Z; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler
>
> Mailbox interrupt handler only take care of PF reset notification, for other
> message ixgbe_read_mbx should not be called since it get chance to break the
> foreground VF to PF communication.
> This can be simply repeated by
> testpmd>rx_vlan rm all 0
>
> Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, with minor commit log changes. Thanks!
/Helin
^ permalink raw reply [flat|nested] 10+ messages in thread