* [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
@ 2020-06-17 19:02 Sergey Lvov
2020-06-18 20:32 ` Chas Williams
0 siblings, 1 reply; 5+ messages in thread
From: Sergey Lvov @ 2020-06-17 19:02 UTC (permalink / raw)
To: dev; +Cc: Sergey Lvov
It seems to be a typo
Signed-off-by: Sergey Lvov <log0div0@gmail.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 612a64599..3ef0df84a 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
if (internals->slaves[i].port_id ==
internals->current_primary_port) {
if (rte_eth_dev_default_mac_addr_set(
- internals->primary_port,
+ internals->current_primary_port,
bonded_eth_dev->data->mac_addrs)) {
RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
internals->current_primary_port);
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
2020-06-17 19:02 [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes Sergey Lvov
@ 2020-06-18 20:32 ` Chas Williams
2020-06-19 1:19 ` Wei Hu (Xavier)
0 siblings, 1 reply; 5+ messages in thread
From: Chas Williams @ 2020-06-18 20:32 UTC (permalink / raw)
To: dev
Yes, this does look like a typo on someone's part.
Please change use net/bonding: instead of pmd_bond:
Please add a Fixes: line
Please add a Cc: stable@dpdk.org
On 6/17/20 3:02 PM, Sergey Lvov wrote:
> It seems to be a typo
>
> Signed-off-by: Sergey Lvov <log0div0@gmail.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 612a64599..3ef0df84a 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
*bonded_eth_dev)
> if (internals->slaves[i].port_id ==
> internals->current_primary_port) {
> if (rte_eth_dev_default_mac_addr_set(
> - internals->primary_port,
> + internals->current_primary_port,
> bonded_eth_dev->data->mac_addrs)) {
> RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
> internals->current_primary_port);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
2020-06-18 20:32 ` Chas Williams
@ 2020-06-19 1:19 ` Wei Hu (Xavier)
2020-07-11 10:01 ` Wei Hu (Xavier)
0 siblings, 1 reply; 5+ messages in thread
From: Wei Hu (Xavier) @ 2020-06-19 1:19 UTC (permalink / raw)
To: Chas Williams, dev
Hi， Chas Williams & Sergey Lvov
There was a two-patch series about bonding those are still in reviewing
state，
and the one of them includes the identical modification. Thanks.
http://patches.dpdk.org/patch/68742/
The series include two patches:
http://patches.dpdk.org/patch/68742/
http://patches.dpdk.org/patch/68743/
Best Regards
Xavier
On 2020/6/19 4:32, Chas Williams wrote:
> Yes, this does look like a typo on someone's part.
>
> Please change use net/bonding: instead of pmd_bond:
> Please add a Fixes: line
> Please add a Cc: stable@dpdk.org
>
> On 6/17/20 3:02 PM, Sergey Lvov wrote:
> > It seems to be a typo
> >
> > Signed-off-by: Sergey Lvov <log0div0@gmail.com>
> > ---
> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index 612a64599..3ef0df84a 100644
> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
> *bonded_eth_dev)
> > if (internals->slaves[i].port_id ==
> > internals->current_primary_port) {
> > if (rte_eth_dev_default_mac_addr_set(
> > - internals->primary_port,
> > + internals->current_primary_port,
> > bonded_eth_dev->data->mac_addrs)) {
> > RTE_BOND_LOG(ERR, "Failed to update port Id %d
> MAC address",
> > internals->current_primary_port);
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
2020-06-19 1:19 ` Wei Hu (Xavier)
@ 2020-07-11 10:01 ` Wei Hu (Xavier)
2020-07-17 11:43 ` Wei Hu (Xavier)
0 siblings, 1 reply; 5+ messages in thread
From: Wei Hu (Xavier) @ 2020-07-11 10:01 UTC (permalink / raw)
To: Chas Williams, log0div0
Cc: dev, Ferruh Yigit, xavier >> Wei Hu (Xavier)
Hi, Sergey Lvov
There was a two-patch series about bonding those are still in reviewing
state，
and the one of them includes the identical modification.
http://patches.dpdk.org/patch/68742/
Would you like to review it and give 'Signed-off-by' on the patch if
there are no object?
Thanks, Xavier
On 2020/6/19 9:19, Wei Hu (Xavier) wrote:
> Hi， Chas Williams & Sergey Lvov
>
> There was a two-patch series about bonding those are still in
> reviewing state，
>
> and the one of them includes the identical modification. Thanks.
>
> http://patches.dpdk.org/patch/68742/
>
>
> The series include two patches:
> http://patches.dpdk.org/patch/68742/
> http://patches.dpdk.org/patch/68743/
>
> Best Regards
> Xavier
>
>
> On 2020/6/19 4:32, Chas Williams wrote:
>> Yes, this does look like a typo on someone's part.
>>
>> Please change use net/bonding: instead of pmd_bond:
>> Please add a Fixes: line
>> Please add a Cc: stable@dpdk.org
>>
>> On 6/17/20 3:02 PM, Sergey Lvov wrote:
>> > It seems to be a typo
>> >
>> > Signed-off-by: Sergey Lvov <log0div0@gmail.com>
>> > ---
>> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
>> b/drivers/net/bonding/rte_eth_bond_pmd.c
>> > index 612a64599..3ef0df84a 100644
>> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
>> *bonded_eth_dev)
>> > if (internals->slaves[i].port_id ==
>> > internals->current_primary_port) {
>> > if (rte_eth_dev_default_mac_addr_set(
>> > - internals->primary_port,
>> > + internals->current_primary_port,
>> > bonded_eth_dev->data->mac_addrs)) {
>> > RTE_BOND_LOG(ERR, "Failed to update port Id
>> %d MAC address",
>> > internals->current_primary_port);
>> >
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
2020-07-11 10:01 ` Wei Hu (Xavier)
@ 2020-07-17 11:43 ` Wei Hu (Xavier)
0 siblings, 0 replies; 5+ messages in thread
From: Wei Hu (Xavier) @ 2020-07-17 11:43 UTC (permalink / raw)
To: log0div0; +Cc: Chas Williams, dev, Ferruh Yigit, Wei Hu (Xavier)
Hi, Sergey Lvov
Thanks for you reporting issues,
The identical modification had been applied to dpdk-next-net.
http://patches.dpdk.org/patch/68742/
repo: http://dpdk.org/git/next/dpdk-next-net
f109ce2c5c6b114f533ffcb69460385ac04db215
net/bonding: fix MAC address when switching active port
Could you like to 'Signed-off-by' on the patch if there are no object?
Thanks, Xavier
On 2020/7/11 18:01, Wei Hu (Xavier) wrote:
>
> Hi, Sergey Lvov
>
>
> There was a two-patch series about bonding those are still in
> reviewing state，
>
> and the one of them includes the identical modification.
>
> http://patches.dpdk.org/patch/68742/
>
> Would you like to review it and give 'Signed-off-by' on the patch if
> there are no object?
>
> Thanks, Xavier
>
>
> On 2020/6/19 9:19, Wei Hu (Xavier) wrote:
>> Hi， Chas Williams & Sergey Lvov
>>
>> There was a two-patch series about bonding those are still in
>> reviewing state，
>>
>> and the one of them includes the identical modification. Thanks.
>>
>> http://patches.dpdk.org/patch/68742/
>>
>>
>> The series include two patches:
>> http://patches.dpdk.org/patch/68742/
>> http://patches.dpdk.org/patch/68743/
>>
>> Best Regards
>> Xavier
>>
>>
>> On 2020/6/19 4:32, Chas Williams wrote:
>>> Yes, this does look like a typo on someone's part.
>>>
>>> Please change use net/bonding: instead of pmd_bond:
>>> Please add a Fixes: line
>>> Please add a Cc: stable@dpdk.org
>>>
>>> On 6/17/20 3:02 PM, Sergey Lvov wrote:
>>> > It seems to be a typo
>>> >
>>> > Signed-off-by: Sergey Lvov <log0div0@gmail.com>
>>> > ---
>>> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
>>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>> >
>>> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
>>> b/drivers/net/bonding/rte_eth_bond_pmd.c
>>> > index 612a64599..3ef0df84a 100644
>>> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>>> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>>> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
>>> *bonded_eth_dev)
>>> > if (internals->slaves[i].port_id ==
>>> > internals->current_primary_port) {
>>> > if (rte_eth_dev_default_mac_addr_set(
>>> > - internals->primary_port,
>>> > + internals->current_primary_port,
>>> > bonded_eth_dev->data->mac_addrs)) {
>>> > RTE_BOND_LOG(ERR, "Failed to update port Id
>>> %d MAC address",
>>> > internals->current_primary_port);
>>> >
>>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-17 11:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 19:02 [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes Sergey Lvov
2020-06-18 20:32 ` Chas Williams
2020-06-19 1:19 ` Wei Hu (Xavier)
2020-07-11 10:01 ` Wei Hu (Xavier)
2020-07-17 11:43 ` Wei Hu (Xavier)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).