DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"yskoh@mellanox.com" <yskoh@mellanox.com>
Cc: "shahafs@mellanox.com" <shahafs@mellanox.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Gavin.Hu@arm.com" <Gavin.Hu@arm.com>, "nd@arm.com" <nd@arm.com>,
	"bluca@debian.org" <bluca@debian.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson
Date: Wed, 23 Jan 2019 17:19:14 +0000	[thread overview]
Message-ID: <1d03328d783cd5ba779e9c27e8c609cfe949b583.camel@marvell.com> (raw)
In-Reply-To: <AM6PR08MB367276836768C8E1E79813B798990@AM6PR08MB3672.eurprd08.prod.outlook.com>

On Wed, 2019-01-23 at 16:24 +0000, Honnappa Nagarahalli wrote:
> > > > > > > I'll come up with a new patch based on the discussion
> > > > > > > here.
> > > > > > > A few things noted,
> > > > > > > - we still want it to be 128B for generic build
> > > > > > > - we at least agreed on changing it to 64B for A72
> > > > > > How will this be done? Will you add
> > > > > > config/arm/arm64_bluefield_linuxapp_gcc?
> > > > > I asked this question as there was a proposal containing
> > > > > 'a72' in
> > > > > the file name. IMO, the file name should contain 'bluefield',
> > > > > not
> > > > > on a72.
> > > > 
> > > > Sorry for late reply. It's been buried for some reason. :-)
> > > No problem
> > > 
> > > > Nope, I won't create such a file. That's for cross-compiler
> > > > AFAIK.
> > > > I'm thinking about changing meson.build. Currently, one CL size
> > > > is
> > > > applied to all kinds of cores. Consequently, for armv8a, both
> > > > 'default' and 'a72' have to have the same CL size. And one more
> > > > thing raised from ARM was that 'crypto' in -march can't be a
> > > > default.
> > > Yes, crypto is optional. So, the distro builds (and any other
> > > builds
> > > for binary compatibility) should not expect crypto to be present
> > > by
> > > default.
> > 
> > IMO, crypto case is different where DPDK code check at runtime to
> > see crypto
> > instruction present in the given CPU before it uses any crypto
> > instructions. so
> > IMO, There is no harm in building with crypto enabled unlike other
> > gcc flags.
> > 
> Right now, DPDK does not boot on a platform with crypto disabled. Do
> you suggest we remove the run time check in DPDK?

May be we need to introduce a framework to define mandatory cpu flags
and optional flags. Check only mandatory flags at bootup or some
abstraction where we can express above scenario like cryto flag case.



> 

      reply	other threads:[~2019-01-23 17:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  9:39 [dpdk-dev] " Yongseok Koh
2019-01-09 10:09 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-01-09 10:19   ` Luca Boccassi
2019-01-09 10:52     ` Jerin Jacob Kollanukkaran
2019-01-09 13:14       ` Luca Boccassi
2019-01-09 10:22   ` Yongseok Koh
2019-01-09 10:49     ` Jerin Jacob Kollanukkaran
2019-01-09 11:28       ` Thomas Monjalon
2019-01-09 12:47         ` Jerin Jacob Kollanukkaran
2019-01-09 13:30           ` Thomas Monjalon
2019-01-09 14:23             ` Jerin Jacob Kollanukkaran
2019-01-09 14:57               ` Thomas Monjalon
2019-01-09 15:34                 ` [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-01-09 15:41                   ` Luca Boccassi
2019-01-09 16:36                     ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-01-09 16:52                       ` Luca Boccassi
2019-01-09 17:01                         ` Pavan Nikhilesh Bhagavatula
2019-01-14  4:32                 ` [dpdk-dev] [EXT] " Yongseok Koh
2019-01-14  7:44                   ` Honnappa Nagarahalli
2019-01-16  2:02                     ` Honnappa Nagarahalli
2019-01-19  7:09                       ` Yongseok Koh
2019-01-22 18:51                         ` Honnappa Nagarahalli
2019-01-23  8:56                           ` Jerin Jacob Kollanukkaran
2019-01-23 16:24                             ` Honnappa Nagarahalli
2019-01-23 17:19                               ` Jerin Jacob Kollanukkaran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d03328d783cd5ba779e9c27e8c609cfe949b583.camel@marvell.com \
    --to=jerinj@marvell.com \
    --cc=Gavin.Hu@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).