From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
"yskoh@mellanox.com" <yskoh@mellanox.com>
Cc: "shahafs@mellanox.com" <shahafs@mellanox.com>,
"Gavin.Hu@arm.com" <Gavin.Hu@arm.com>,
"bluca@debian.org" <bluca@debian.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson
Date: Wed, 9 Jan 2019 10:09:21 +0000 [thread overview]
Message-ID: <68eb1e77e09e396a229920f10487b6e95ddce5c8.camel@marvell.com> (raw)
In-Reply-To: <20190109093915.40882-1-yskoh@mellanox.com>
On Wed, 2019-01-09 at 01:39 -0800, Yongseok Koh wrote:
>
> -------------------------------------------------------------------
> ---
> In config/arm64_armv8_linuxapp_gcc, maximum available cache line size
> (128B) in arm64 implementations is set by default for generic config.
> However, setting 64B is preferable for meson build in order to
> support
> majority of CPUs which don't have Implementor ID or Part Number
> programmed
> on chip.
Adding Luca to get input from distro build perspective.
If I understand it correctly, distro build will be using
the generic config/arm/arm64_armv8_linuxapp_gcc for generic build.
If so, We can not change cache line size for generic config
as mentined the reason are
https://mails.dpdk.org/archives/dev/2019-January/122441.html
I think, I way forward is to add config/arm/arm64_a72_linuxapp_gcc
for meson. This config can be used for all SoC with A72 armv8
implementation and may have sym link to specfific SoC to avoid
confusion to end users.
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>
> Discussion on the mailing list:
> https://mails.dpdk.org/archives/dev/2019-January/122441.html
>
> config/arm/meson.build | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index dae55d6b26..3af256a5ec 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -47,8 +47,7 @@ flags_common_default = [
> flags_generic = [
> ['RTE_MACHINE', '"armv8a"'],
> ['RTE_MAX_LCORE', 256],
> - ['RTE_USE_C11_MEM_MODEL', true],
> - ['RTE_CACHE_LINE_SIZE', 128]]
> + ['RTE_USE_C11_MEM_MODEL', true]]
> flags_cavium = [
> ['RTE_MACHINE', '"thunderx"'],
> ['RTE_CACHE_LINE_SIZE', 128],
> @@ -89,15 +88,19 @@ impl_dpaa2 = ['NXP DPAA2', flags_dpaa2,
> machine_args_generic]
>
> dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)
>
> +# In config/arm64_armv8_linuxapp_gcc, maximum available cache line
> size (128B)
> +# in arm64 implementations is set by default for generic config.
> However,
> +# setting 64B is preferable for meson build in order to support
> majority of CPUs
> +# which don't have Implementor ID or Part Number programmed on chip.
> +dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> +
> if cc.sizeof('void *') != 8
> - dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> dpdk_conf.set('RTE_ARCH_ARM', 1)
> dpdk_conf.set('RTE_ARCH_ARMv7', 1)
> # the minimum architecture supported, armv7-a, needs the
> following,
> # mk/machine/armv7a/rte.vars.mk sets it too
> machine_args += '-mfpu=neon'
> else
> - dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> dpdk_conf.set('RTE_ARCH_ARM64', 1)
> dpdk_conf.set('RTE_ARCH_64', 1)
>
next prev parent reply other threads:[~2019-01-09 10:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:39 [dpdk-dev] " Yongseok Koh
2019-01-09 10:09 ` Jerin Jacob Kollanukkaran [this message]
2019-01-09 10:19 ` [dpdk-dev] [EXT] " Luca Boccassi
2019-01-09 10:52 ` Jerin Jacob Kollanukkaran
2019-01-09 13:14 ` Luca Boccassi
2019-01-09 10:22 ` Yongseok Koh
2019-01-09 10:49 ` Jerin Jacob Kollanukkaran
2019-01-09 11:28 ` Thomas Monjalon
2019-01-09 12:47 ` Jerin Jacob Kollanukkaran
2019-01-09 13:30 ` Thomas Monjalon
2019-01-09 14:23 ` Jerin Jacob Kollanukkaran
2019-01-09 14:57 ` Thomas Monjalon
2019-01-09 15:34 ` [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-01-09 15:41 ` Luca Boccassi
2019-01-09 16:36 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-01-09 16:52 ` Luca Boccassi
2019-01-09 17:01 ` Pavan Nikhilesh Bhagavatula
2019-01-14 4:32 ` [dpdk-dev] [EXT] " Yongseok Koh
2019-01-14 7:44 ` Honnappa Nagarahalli
2019-01-16 2:02 ` Honnappa Nagarahalli
2019-01-19 7:09 ` Yongseok Koh
2019-01-22 18:51 ` Honnappa Nagarahalli
2019-01-23 8:56 ` Jerin Jacob Kollanukkaran
2019-01-23 16:24 ` Honnappa Nagarahalli
2019-01-23 17:19 ` Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68eb1e77e09e396a229920f10487b6e95ddce5c8.camel@marvell.com \
--to=jerinj@marvell.com \
--cc=Gavin.Hu@arm.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).