DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Tom Barbette <barbette@kth.se>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] mlx5: Implement support for read_clock
Date: Wed, 3 Apr 2019 05:28:00 +0000	[thread overview]
Message-ID: <AM6PR0502MB37971C3EA5A558F1D0DC4BD7C3570@AM6PR0502MB3797.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190403052800.EDt68CfLlLK8z8F_2_TbrizHnDlSJ5fzy36aax9-v44@z> (raw)
In-Reply-To: <20190327061935.19572-3-barbette@kth.se>

Wednesday, March 27, 2019 8:20 AM, Tom Barbette:
> Subject: [PATCH v2 2/3] mlx5: Implement support for read_clock
> 
> Signed-off-by: Tom Barbette <barbette@kth.se>

Apart from the compilation issue I am OK w/ this patch.

You can add my acked-by on v3.

> ---
>  drivers/net/mlx5/mlx5.c        |  1 +
>  drivers/net/mlx5/mlx5.h        |  1 +
>  drivers/net/mlx5/mlx5_ethdev.c | 29 +++++++++++++++++++++++++++++
>  drivers/net/mlx5/mlx5_glue.c   |  8 ++++++++
>  drivers/net/mlx5/mlx5_glue.h   |  2 ++
>  5 files changed, 41 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> ae4b71695..7091ff4bb 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -376,6 +376,7 @@ const struct eth_dev_ops mlx5_dev_ops = {
>  	.xstats_get_names = mlx5_xstats_get_names,
>  	.fw_version_get = mlx5_fw_version_get,
>  	.dev_infos_get = mlx5_dev_infos_get,
> +	.read_clock = mlx5_read_clock,
>  	.dev_supported_ptypes_get = mlx5_dev_supported_ptypes_get,
>  	.vlan_filter_set = mlx5_vlan_filter_set,
>  	.rx_queue_setup = mlx5_rx_queue_setup, diff --git
> a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> 538445367..88394f391 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -275,6 +275,7 @@ int mlx5_set_flags(struct rte_eth_dev *dev, unsigned
> int keep,
>  		   unsigned int flags);
>  int mlx5_dev_configure(struct rte_eth_dev *dev);  void
> mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info
> *info);
> +int mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *time);
>  int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t
> fw_size);  const uint32_t *mlx5_dev_supported_ptypes_get(struct
> rte_eth_dev *dev);  int mlx5_link_update(struct rte_eth_dev *dev, int
> wait_to_complete); diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c index f84f7cf69..52262ee44 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -557,6 +557,35 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *info)
>  	}
>  }
> 
> +/**
> + * Get device current raw clock counter
> + *
> + * @param dev
> + *   Pointer to Ethernet device structure.
> + * @param[out] time
> + *   Current raw clock counter of the device.
> + *
> + * @return
> + *   0 if the clock has correctly been read
> + *   The value of errno in case of error
> + */
> +int
> +mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *clock) {
> +	struct mlx5_priv *priv = dev->data->dev_private;
> +	struct ibv_values_ex values;
> +	int err = 0;
> +
> +	values.comp_mask = IBV_VALUES_MASK_RAW_CLOCK;
> +	err = mlx5_glue->query_rt_values_ex(priv->ctx, &values);
> +	if (err != 0) {
> +		DRV_LOG(WARNING, "Could not query the clock !");
> +		return err;
> +	}
> +	*clock = values.raw_clock.tv_nsec;
> +	return 0;
> +}
> +
>  /**
>   * Get firmware version of a device.
>   *
> diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
> index c817d86c5..c1786c5e9 100644
> --- a/drivers/net/mlx5/mlx5_glue.c
> +++ b/drivers/net/mlx5/mlx5_glue.c
> @@ -86,6 +86,13 @@ mlx5_glue_query_device_ex(struct ibv_context
> *context,
>  	return ibv_query_device_ex(context, input, attr);  }
> 
> +static int
> +mlx5_glue_query_rt_values_ex(struct ibv_context *context,
> +			  struct ibv_values_ex *values)
> +{
> +	return ibv_query_rt_values_ex(context, values); }
> +
>  static int
>  mlx5_glue_query_port(struct ibv_context *context, uint8_t port_num,
>  		     struct ibv_port_attr *port_attr) @@ -603,6 +610,7 @@
> const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue){
>  	.close_device = mlx5_glue_close_device,
>  	.query_device = mlx5_glue_query_device,
>  	.query_device_ex = mlx5_glue_query_device_ex,
> +	.query_rt_values_ex = mlx5_glue_query_rt_values_ex,
>  	.query_port = mlx5_glue_query_port,
>  	.create_comp_channel = mlx5_glue_create_comp_channel,
>  	.destroy_comp_channel = mlx5_glue_destroy_comp_channel, diff --
> git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.h index
> b11896062..fd651cc03 100644
> --- a/drivers/net/mlx5/mlx5_glue.h
> +++ b/drivers/net/mlx5/mlx5_glue.h
> @@ -74,6 +74,8 @@ struct mlx5_glue {
>  	int (*query_device_ex)(struct ibv_context *context,
>  			       const struct ibv_query_device_ex_input *input,
>  			       struct ibv_device_attr_ex *attr);
> +	int (*query_rt_values_ex)(struct ibv_context *context,
> +			       struct ibv_values_ex *values);
>  	int (*query_port)(struct ibv_context *context, uint8_t port_num,
>  			  struct ibv_port_attr *port_attr);
>  	struct ibv_comp_channel *(*create_comp_channel)
> --
> 2.17.1


  parent reply	other threads:[~2019-04-03  5:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27  6:19 [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API Tom Barbette
2019-03-27  6:19 ` Tom Barbette
2019-03-27  6:19 ` [dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock Tom Barbette
2019-03-27  6:19   ` Tom Barbette
2019-04-02 17:46   ` Ferruh Yigit
2019-04-02 17:46     ` Ferruh Yigit
2019-04-02 19:24     ` Tom Barbette
2019-04-02 19:24       ` Tom Barbette
2019-03-27  6:19 ` [dpdk-dev] [PATCH v2 2/3] mlx5: Implement support for read_clock Tom Barbette
2019-03-27  6:19   ` Tom Barbette
2019-04-02 17:47   ` Ferruh Yigit
2019-04-02 17:47     ` Ferruh Yigit
2019-04-02 18:26   ` Ferruh Yigit
2019-04-02 18:26     ` Ferruh Yigit
2019-04-02 19:05     ` Tom Barbette
2019-04-02 19:05       ` Tom Barbette
2019-04-03  5:28   ` Shahaf Shuler [this message]
2019-04-03  5:28     ` Shahaf Shuler
2019-03-27  6:19 ` [dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW timestamp Tom Barbette
2019-03-27  6:19   ` Tom Barbette
2019-04-02 18:22   ` Ferruh Yigit
2019-04-02 18:22     ` Ferruh Yigit
2019-04-02 19:39     ` Tom Barbette
2019-04-02 19:39       ` Tom Barbette
2019-03-27 14:41 ` [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API Stephen Hemminger
2019-03-27 14:41   ` Stephen Hemminger
2019-03-27 14:48   ` Thomas Monjalon
2019-03-27 14:48     ` Thomas Monjalon
2019-03-27 14:54   ` Wiles, Keith
2019-03-27 14:54     ` Wiles, Keith
2019-03-27 16:08     ` Tom Barbette
2019-03-27 16:08       ` Tom Barbette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR0502MB37971C3EA5A558F1D0DC4BD7C3570@AM6PR0502MB3797.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=arybchenko@solarflare.com \
    --cc=barbette@kth.se \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).