DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11
@ 2020-09-21 13:38 Ferruh Yigit
  2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Ferruh Yigit @ 2020-09-21 13:38 UTC (permalink / raw)
  To: Rasesh Mody, Shahed Shaikh; +Cc: dev, Ferruh Yigit

Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)

build error:
../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’:
../drivers/net/qede/qede_main.c:587:17:
	warning: this ‘if’ clause does not guard...
                 [-Wmisleading-indentation]
  587 |                 if (!ptt)
      |                 ^~
../drivers/net/qede/qede_main.c:590:25:
	note: ...this statement, but the latter is misleadingly indented
              as if it were guarded by the ‘if’
  590 |                         qed_fill_link(hwfn, ptt, if_link);
      |                         ^~~~~~~~~~~~~

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
I am not clear what the exact intention of the original code is,
compiler warning is about wrong indentation of 'qed_fill_link(..)', I
have updated the code to keep the behavior same but fix the indentation.
Please send a proper fix if the existing behavior needs to be updated.
---
 drivers/net/qede/qede_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index aecb98261..0f82568d3 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -587,7 +587,7 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
 		if (!ptt)
 			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
 
-			qed_fill_link(hwfn, ptt, if_link);
+		qed_fill_link(hwfn, ptt, if_link);
 
 		if (ptt)
 			ecore_ptt_release(hwfn, ptt);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-10-08 11:29 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: fix build with gcc 11 Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
     [not found]   ` <CAJFAV8wAio=NF2eMMx9URkNinht2sPtBrE9k1c0uD+_GJcM4aw@mail.gmail.com>
     [not found]     ` <CAJFAV8y9zFUAKoqhQxobdQDVPAOny4ie+Cm1fHneEX6g6zdtjw@mail.gmail.com>
     [not found]       ` <AM5PR0401MB2593386BAB0C09ABE92F9D65E60B0@AM5PR0401MB2593.eurprd04.prod.outlook.com>
2020-10-08 10:40         ` David Marchand
2020-10-08 11:29           ` Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
2020-09-24  9:31   ` David Marchand
2020-10-04  8:57     ` Asaf Penso
2020-09-24 11:01   ` Phil Yang
2020-10-08 10:48   ` David Marchand
2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
2020-09-24  9:32   ` David Marchand
2020-10-08 10:48     ` David Marchand
2020-09-25  4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
2020-10-06 12:38   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).