* [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10
@ 2021-09-15 5:08 David Marchand
2021-09-15 8:14 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2021-09-15 5:08 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, David Christensen, Bruce Richardson
Like for python, multiline statements in meson must either use a
backslash character (explicit continuation) or be enclosed in ()
(implicit continuation).
python PEP8 recommends the latter [1], and it looks like meson had
an issue with backslash before 0.50 [2].
1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
config/ppc/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/ppc/meson.build b/config/ppc/meson.build
index 0b1948fc7c..aa1327a595 100644
--- a/config/ppc/meson.build
+++ b/config/ppc/meson.build
@@ -20,8 +20,8 @@ endif
# Suppress the gcc warning "note: the layout of aggregates containing
# vectors with 4-byte alignment has changed in GCC 5".
-if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
- cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
+if (cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
+ cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi'))
add_project_arguments('-Wno-psabi', language: 'c')
endif
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10
2021-09-15 5:08 [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10 David Marchand
@ 2021-09-15 8:14 ` Ferruh Yigit
2021-09-15 9:08 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2021-09-15 8:14 UTC (permalink / raw)
To: David Marchand, dev; +Cc: David Christensen, Bruce Richardson
On 9/15/2021 6:08 AM, David Marchand wrote:
> Like for python, multiline statements in meson must either use a
> backslash character (explicit continuation) or be enclosed in ()
> (implicit continuation).
>
> python PEP8 recommends the latter [1], and it looks like meson had
> an issue with backslash before 0.50 [2].
>
> 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
> 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
>
> Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> config/ppc/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/ppc/meson.build b/config/ppc/meson.build
> index 0b1948fc7c..aa1327a595 100644
> --- a/config/ppc/meson.build
> +++ b/config/ppc/meson.build
> @@ -20,8 +20,8 @@ endif
>
> # Suppress the gcc warning "note: the layout of aggregates containing
> # vectors with 4-byte alignment has changed in GCC 5".
> -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
> - cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
> +if (cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
> + cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi'))
> add_project_arguments('-Wno-psabi', language: 'c')
> endif
>
>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10
2021-09-15 8:14 ` Ferruh Yigit
@ 2021-09-15 9:08 ` Bruce Richardson
2021-09-15 15:10 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2021-09-15 9:08 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: David Marchand, dev, David Christensen
On Wed, Sep 15, 2021 at 09:14:34AM +0100, Ferruh Yigit wrote:
> On 9/15/2021 6:08 AM, David Marchand wrote:
> > Like for python, multiline statements in meson must either use a
> > backslash character (explicit continuation) or be enclosed in ()
> > (implicit continuation).
> >
> > python PEP8 recommends the latter [1], and it looks like meson had
> > an issue with backslash before 0.50 [2].
> >
> > 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
> > 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
> >
> > Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > config/ppc/meson.build | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/config/ppc/meson.build b/config/ppc/meson.build
> > index 0b1948fc7c..aa1327a595 100644
> > --- a/config/ppc/meson.build
> > +++ b/config/ppc/meson.build
> > @@ -20,8 +20,8 @@ endif
> >
> > # Suppress the gcc warning "note: the layout of aggregates containing
> > # vectors with 4-byte alignment has changed in GCC 5".
> > -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
> > - cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
> > +if (cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
> > + cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi'))
> > add_project_arguments('-Wno-psabi', language: 'c')
> > endif
> >
> >
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10
2021-09-15 9:08 ` Bruce Richardson
@ 2021-09-15 15:10 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2021-09-15 15:10 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Bruce Richardson, David Christensen
On Wed, Sep 15, 2021 at 11:08 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Wed, Sep 15, 2021 at 09:14:34AM +0100, Ferruh Yigit wrote:
> > On 9/15/2021 6:08 AM, David Marchand wrote:
> > > Like for python, multiline statements in meson must either use a
> > > backslash character (explicit continuation) or be enclosed in ()
> > > (implicit continuation).
> > >
> > > python PEP8 recommends the latter [1], and it looks like meson had
> > > an issue with backslash before 0.50 [2].
> > >
> > > 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
> > > 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
> > >
> > > Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
> > >
> > > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-15 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 5:08 [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10 David Marchand
2021-09-15 8:14 ` Ferruh Yigit
2021-09-15 9:08 ` Bruce Richardson
2021-09-15 15:10 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).