From: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
To: dev@dpdk.org
Subject: [RFC PATCH 0/3] improve FEC API usage
Date: Fri, 28 Apr 2023 14:27:25 +0400 [thread overview]
Message-ID: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> (raw)
The documentation for the FEC API is currently incomplete and contains
inaccuracies in its descriptions of function parameters.
Specifically, the semantics of the fec_capa parameter in rte_eth_fec_set()
is not well-defined. It does not provide information on what should
be done if only AUTO bit is set or one of the specified FEC modes is
not supported. Additionally, the fec_capa parameter in rte_eth_fec_get()
implies that more than one FEC mode can be obtained, but it is
wrong. Furthermore, the behaviour is undefined in
rte_eth_fec_set() when the fec_capa parameter is zero.
To address these issues, a patch series has been created that updates
the FEC API documentation, renames one of the parameters to improve
its clarity and adds a check for zero fec_capability.
Denis Pryazhennikov (3):
ethdev: update documentation for API to set FEC
ethdev: check that at least one FEC mode is specified
ethdev: rename parameter in API to get FEC
lib/ethdev/rte_ethdev.c | 13 +++++++++----
lib/ethdev/rte_ethdev.h | 25 ++++++++++++++-----------
2 files changed, 23 insertions(+), 15 deletions(-)
--
2.37.0 (Apple Git-136)
next reply other threads:[~2023-04-28 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:27 Denis Pryazhennikov [this message]
2023-04-28 10:27 ` [RFC PATCH 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-02 14:57 ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-02 14:57 ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Denis Pryazhennikov
2023-05-02 15:02 ` Ferruh Yigit
2023-05-04 7:13 ` Denis Pryazhennikov
2023-05-04 7:47 ` Ferruh Yigit
2023-05-08 11:47 ` [RFC PATCH v2 0/3] improve FEC API usage Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC Denis Pryazhennikov
2023-05-12 11:57 ` [RFC PATCH v2 0/3] improve FEC API usage Ferruh Yigit
2023-06-07 18:41 ` Ferruh Yigit
2023-06-19 12:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428102728.51956-1-denis.pryazhennikov@arknetworks.am \
--to=denis.pryazhennikov@arknetworks.am \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).