[dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket

[dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket

[Sergey Balabanov]

On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1)
is being casted to unsigned char and then to signed int.
The result is that socket_id has value of 255, not -1.
This results to memory allocation failure.

Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 97a828e..c0f0b99 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -849,7 +849,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 	};
 
 	char mem_name[RTE_ETH_NAME_MAX_LEN];
-	uint8_t socket_id;
+	int socket_id;
 	unsigned element_size;
 
 	/* Given slave mus not be in active list */
-- 
2.1.4

Re: [dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Sergey Balabanov [mailto:balabanovsv@ecotelecom.ru]
> Sent: Friday, August 07, 2015 10:33 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Sergey Balabanov
> Subject: [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket
> 
> On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1)
> is being casted to unsigned char and then to signed int.
> The result is that socket_id has value of 255, not -1.
> This results to memory allocation failure.
> 
> Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket

[Thomas Monjalon]

> > On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1)
> > is being casted to unsigned char and then to signed int.
> > The result is that socket_id has value of 255, not -1.
> > This results to memory allocation failure.
> > 
> > Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Fixes: 46fb43683679 ("bond: add mode 4")

Applied, thanks

Please Sergey, do not set the status as "Accepted" yourself in patchwork.
The "Accepted" status means that it has been applied. Setting it before could
result in having your patch forgotten.