From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>,
Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
Date: Fri, 31 Jul 2015 09:03:45 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2022D9DCA@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20150713135955.GC9631@hmsreliant.think-freely.org>
> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Monday, July 13, 2015 3:00 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org; vladz@cloudius-systems.com
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
>
> On Mon, Jul 13, 2015 at 10:47:03AM +0000, Mcnamara, John wrote:
> > > -----Original Message-----
> > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > Sent: Monday, July 13, 2015 11:42 AM
> > > To: Mcnamara, John
> > > Cc: dev@dpdk.org; vladz@cloudius-systems.com
> > > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
> > >
> > > On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote:
> > > > Fix for ABI breakage introduced in LRO addition. Moves lro
> > > > bitfield to the end of the struct/member.
> > > >
> > > > Fixes: 8eecb3295aed (ixgbe: add LRO support)
> > > >
> > > > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> > > > ---
> > > > lib/librte_ether/rte_ethdev.h | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/lib/librte_ether/rte_ethdev.h
> > > > b/lib/librte_ether/rte_ethdev.h index 79bde89..1c3ace1 100644
> > > > --- a/lib/librte_ether/rte_ethdev.h
> > > > +++ b/lib/librte_ether/rte_ethdev.h
> > > > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data {
> > > > uint8_t port_id; /**< Device [external] port
> identifier.
> > > */
> > > > uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) /
> OFF(0).
> > > */
> > > > scattered_rx : 1, /**< RX of scattered packets is ON(1)
> /
> > > OFF(0) */
> > > > - lro : 1, /**< RX LRO is ON(1) / OFF(0) */
> > > > all_multicast : 1, /**< RX all multicast mode ON(1) /
> OFF(0).
> > > */
> > > > - dev_started : 1; /**< Device state: STARTED(1) /
> STOPPED(0).
> > > */
> > > > + dev_started : 1, /**< Device state: STARTED(1) /
> STOPPED(0).
> > > */
> > > > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */
> > > > };
> > > >
> > > > /**
> > > > --
> > > > 1.8.1.4
> > > >
> > > >
> > > I presume the ABI checker stopped complaining about this with the
> > > patch, yes?
> >
> > Hi Neil,
> >
> > Yes, I replied about that in the previous thread.
> >
> Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil
Hi Chao,
Any reply on this.
Neil, if there is no reply to this from the PPC maintainer do you have any objection to this going in as is.
It at least fixes the LRO ABI breakage on the platforms we can test on.
John
next prev parent reply other threads:[~2015-07-31 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 10:26 John McNamara
2015-07-13 10:42 ` Neil Horman
2015-07-13 10:46 ` Thomas Monjalon
2015-07-13 10:47 ` Mcnamara, John
2015-07-13 13:59 ` Neil Horman
2015-07-17 11:45 ` Mcnamara, John
2015-07-17 12:25 ` Neil Horman
2015-07-31 9:03 ` Mcnamara, John [this message]
2015-07-31 10:34 ` Neil Horman
2015-08-03 2:39 ` Chao Zhu
2015-08-03 3:45 ` Chao Zhu
2015-08-03 8:41 ` Thomas Monjalon
2015-08-03 12:53 ` Neil Horman
2015-07-16 22:22 ` Vlad Zolotarov
2015-08-02 21:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2022D9DCA@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).