From: "Traynor, Kevin" <kevin.traynor@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
"Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information
Date: Fri, 4 Mar 2016 09:58:51 +0000 [thread overview]
Message-ID: <BC0FEEC7D7650749874CEC11314A88F7454365C8@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <56D957B4.4090104@redhat.com>
> -----Original Message-----
> From: Panu Matilainen [mailto:pmatilai@redhat.com]
> Sent: Friday, March 4, 2016 9:39 AM
> To: Traynor, Kevin <kevin.traynor@intel.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>; Wiles, Keith <keith.wiles@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
> information
>
> On 03/04/2016 11:28 AM, Traynor, Kevin wrote:
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> >> Sent: Thursday, March 3, 2016 6:38 PM
> >> To: Wiles, Keith <keith.wiles@intel.com>
> >> Cc: dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
> >> information
> >>
> >> 2016-02-22 07:53, Keith Wiles:
> >>> --- /dev/null
> >>> +++ b/config/common_base
> >>> +CONFIG_RTE_EAL_IGB_UIO=y
> >>> +CONFIG_RTE_EAL_VFIO=y
> >>
> >> These options should be disabled in the base file
> >> and enabled in Linux.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> >>
> >>> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
> >>
> >> Idem, it should be disabled.
> >>
> >>> +CONFIG_RTE_LIBRTE_POWER=y
> >>
> >> Idem?
> >>
> >>> +CONFIG_RTE_LIBRTE_KNI=y
> >>
> >> Should be disabled.
> >>
> >>> +CONFIG_RTE_LIBRTE_VHOST=y
> >>
> >> Should be disabled.
> >
> > Any reason this should be disabled? It was changed to =Y in DPDK 2.1.
>
> That's what I first thought too, but I think Thomas meant "disable in
> common_base, enable in Linux config" for all these.
>
> - Panu -
Ah, ok - got it, that makes sense. thanks.
next prev parent reply other threads:[~2016-03-04 9:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:53 Keith Wiles
2016-02-22 15:09 ` Trahe, Fiona
2016-02-22 16:02 ` Wiles, Keith
2016-02-22 16:44 ` Panu Matilainen
2016-02-24 13:58 ` Wiles, Keith
2016-02-24 14:19 ` Trahe, Fiona
2016-02-24 15:25 ` Wiles, Keith
2016-03-03 14:43 ` Wiles, Keith
2016-03-03 17:05 ` Thomas Monjalon
2016-03-03 18:37 ` Thomas Monjalon
2016-03-03 18:47 ` Wiles, Keith
2016-03-04 14:44 ` Wiles, Keith
2016-03-04 15:26 ` Thomas Monjalon
2016-03-04 9:28 ` Traynor, Kevin
2016-03-04 9:39 ` Panu Matilainen
2016-03-04 9:58 ` Traynor, Kevin [this message]
2016-03-04 10:28 ` Thomas Monjalon
2016-03-04 14:11 ` Wiles, Keith
2016-03-04 9:35 ` Panu Matilainen
2016-03-04 10:12 ` Panu Matilainen
2016-03-04 14:12 ` Wiles, Keith
2016-03-04 17:01 ` [dpdk-dev] [PATCH v2] " Keith Wiles
2016-03-04 17:26 ` Thomas Monjalon
2016-03-04 18:07 ` Wiles, Keith
2016-03-04 18:11 ` [dpdk-dev] [PATCH v3] " Keith Wiles
2016-03-04 22:43 ` Thomas Monjalon
2016-03-06 1:11 ` Ferruh Yigit
2016-03-06 1:21 ` [dpdk-dev] [PATCH] config: move Linux only config options from base to Linux config Ferruh Yigit
2016-03-06 9:35 ` [dpdk-dev] [PATCH v3] config: remove duplicate configuration information Thomas Monjalon
2016-03-07 12:41 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC0FEEC7D7650749874CEC11314A88F7454365C8@IRSMSX104.ger.corp.intel.com \
--to=kevin.traynor@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).