DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] net/ixgbe: add and export MDIO APIs
@ 2017-11-06 13:42 Shweta Choudaha
  2017-11-06 14:25 ` [dpdk-dev] [PATCH v2 " Shweta Choudaha
  0 siblings, 1 reply; 10+ messages in thread
From: Shweta Choudaha @ 2017-11-06 13:42 UTC (permalink / raw)
  To: dev; +Cc: bluca

Add ixgbe MDIO access APIs to read and write PHY registers when
being used as a backplane port. Export these APIs via the map file

Signed-off-by: Shweta Choudaha <shweta.choudaha@att.com>
Reviewed-by: Chas Williams <chas3@att.com>
Reviewed-by: Luca Boccassi <bluca@debian.org>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.c           | 53
+++++++++++++++++++++++++++++
 drivers/net/ixgbe/rte_pmd_ixgbe.h           | 39 +++++++++++++++++++++
 drivers/net/ixgbe/rte_pmd_ixgbe_version.map |  7 ++++
 3 files changed, 99 insertions(+)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c
b/drivers/net/ixgbe/rte_pmd_ixgbe.c
index f127378..34d8cb4 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
@@ -1041,3 +1041,56 @@ rte_pmd_ixgbe_bypass_wd_reset(uint16_t port_id)
     return ixgbe_bypass_wd_reset(dev);
 }
 #endif
+
+static void rte_pmd_ixgbe_get_hw_phy(uint16_t port, struct ixgbe_hw **hw,
+                     struct ixgbe_phy_info **phy)
+{
+    struct rte_eth_dev *dev;
+
+    *hw = NULL;
+    *phy = NULL;
+
+    dev = &rte_eth_devices[port];
+    if (!is_ixgbe_supported(dev))
+        return;
+
+    *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+    if (!*hw)
+        return;
+
+    *phy = &(*hw)->phy;
+}
+
+int
+rte_pmd_ixgbe_mdio_read(uint16_t port, uint32_t reg_addr,
+            uint32_t dev_type, uint16_t *phy_data)
+{
+    struct ixgbe_hw *hw;
+    struct ixgbe_phy_info *phy;
+
+    RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+    rte_pmd_ixgbe_get_hw_phy(port, &hw, &phy);
+
+    if (!hw || !phy)
+        return -ENOTSUP;
+
+    return phy->ops.read_reg_mdi(hw, reg_addr, dev_type, phy_data);
+}
+
+int
+rte_pmd_ixgbe_mdio_write(uint16_t port, uint32_t reg_addr,
+             uint32_t dev_type, uint16_t phy_data)
+{
+    struct ixgbe_hw *hw;
+    struct ixgbe_phy_info *phy;
+
+    RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+    rte_pmd_ixgbe_get_hw_phy(port, &hw, &phy);
+
+    if (!hw || !phy)
+        return -ENOTSUP;
+
+    return phy->ops.write_reg_mdi(hw, reg_addr, dev_type, phy_data);
+}
diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h
b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index 81b18f8..5d36f8a 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -601,6 +601,45 @@ int rte_pmd_ixgbe_bypass_wd_timeout_show(uint16_t
port, uint32_t *wd_timeout);
  */
 int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);

+/**
+ * Read PHY register using MDIO
+ *
+ * @param port
+ *   The port identifier of the Ethernet device.
+ * @param reg_addr
+ *   32 bit PHY Register
+ * @param dev_type
+ *   Always Unused
+ * @param phy_data
+ *   Pointer for reading PHY register data
+ * @return
+ *   - (0) if successful.
+ *   - (-ENOTSUP) if hardware doesn't support.
+ *   - (-ENODEV) if *port* invalid.
+ */
+int
+rte_pmd_ixgbe_mdio_read(uint16_t port, uint32_t reg_addr,
+            uint32_t dev_type, uint16_t *phy_data);
+
+/**
+ * Write data to PHY register using MDIO
+ *
+ * @param port
+ *   The port identifier of the Ethernet device.
+ * @param reg_addr
+ *   32 bit PHY Register
+ * @param dev_type
+ *   Always unused
+ * @param phy_data
+ *   Data to write to PHY register
+ * @return
+ *   - (0) if successful.
+ *   - (-ENOTSUP) if hardware doesn't support.
+ *   - (-ENODEV) if *port* invalid.
+ */
+int
+rte_pmd_ixgbe_mdio_write(uint16_t port, uint32_t reg_addr,
+             uint32_t dev_type, uint16_t phy_data);

 /**
  * Response sent back to ixgbe driver from user app after callback
diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
index bf77674..b4d5983 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
@@ -52,3 +52,10 @@ DPDK_17.08 {
     rte_pmd_ixgbe_bypass_wd_timeout_show;
     rte_pmd_ixgbe_bypass_wd_timeout_store;
 } DPDK_17.05;
+
+EXPERIMENTAL {
+    global:
+
+    rte_pmd_ixgbe_mdio_read;
+    rte_pmd_ixgbe_mdio_write;
+} DPDK_17.11;
-- 
2.1.4

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-01-23 15:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 13:42 [dpdk-dev] [PATCH 1/2] net/ixgbe: add and export MDIO APIs Shweta Choudaha
2017-11-06 14:25 ` [dpdk-dev] [PATCH v2 " Shweta Choudaha
2017-11-06 14:25   ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe : backplane port MDIO support Shweta Choudaha
2017-12-21  3:23     ` Zhang, Helin
2018-01-10  3:17     ` Zhang, Helin
2018-01-23 14:14       ` Shweta Choudaha
2017-12-21  3:25   ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: add and export MDIO APIs Zhang, Helin
2018-01-23 15:12     ` Shweta Choudaha
2018-01-23 15:05   ` [dpdk-dev] [PATCH v3 " Shweta Choudaha
2018-01-23 15:05     ` [dpdk-dev] [PATCH v3 2/2] net/ixgbe : backplane port MDIO support Shweta Choudaha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).