DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/bnxt: fix build issue
@ 2020-07-09  8:15 David Marchand
  2020-07-09 12:10 ` Ferruh Yigit
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: David Marchand @ 2020-07-09  8:15 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, thomas, Ajit Khaparde, Somnath Kotur,
	Randy Schacher, Venkat Duvvuru, Peter Spreadborough

In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset.
Testing against a n value does not work and we end up with a link issue:

/usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':
.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference
 to `tf_em_ext_alloc'
/usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free':
.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference
 to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
 Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2

Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/bnxt/tf_core/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bnxt/tf_core/Makefile b/drivers/net/bnxt/tf_core/Makefile
index b4fbdd00fc..806471427c 100644
--- a/drivers/net/bnxt/tf_core/Makefile
+++ b/drivers/net/bnxt/tf_core/Makefile
@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c
-ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n)
-SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c
+ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y)
+SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c
 else
-SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c
+SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c
 endif
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c
 SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c
-- 
2.23.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-07-29  6:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09  8:15 [dpdk-dev] [PATCH] net/bnxt: fix build issue David Marchand
2020-07-09 12:10 ` Ferruh Yigit
2020-07-09 14:33   ` Ajit Khaparde
2020-07-09 14:34 ` Ajit Khaparde
2020-07-10 13:55   ` Ajit Khaparde
2020-07-29  0:48 ` Ajit Khaparde
2020-07-29  6:56   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).