patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2 1/1] net/ionic: use standard stdbool.h
@ 2020-03-09  7:53 Sunil Kumar Kori
  2020-03-09  8:16 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
  2020-03-09  9:09 ` [dpdk-stable] [PATCH v3 " Sunil Kumar Kori
  0 siblings, 2 replies; 8+ messages in thread
From: Sunil Kumar Kori @ 2020-03-09  7:53 UTC (permalink / raw)
  To: Alfredo Cardigliano; +Cc: dev, stable, Sunil Kumar Kori

Any DPDK public header file which includes stdbool.h may conflict with
local definition of bool, if any, which further results in compilation
error. To avoid, used standard stdbool.h instead of defining bool
internally.

I observed this issue during a development where I included rte_uuid.h
into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
throwing error as given below:

  CC ionic_rxtx.o
In file included from .../dpdk/build/include/rte_uuid.h:17:0,
                 from .../dpdk/build/include/rte_ethdev.h:161,
                 from .../dpdk/build/include/rte_ethdev_driver.h:18,
                 from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
.../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
typedef uint8_t bool;
                 ^
In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
                 from .../dpdk/drivers/net/ionic/ionic.h:13,
                 from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
                 from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
.../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
typedef uint8_t bool;
^~~~~~~
cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
.../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v2:
 - include stdbool.h in ionic_dev.h.

 drivers/net/ionic/ionic_dev.c       | 1 +
 drivers/net/ionic/ionic_dev.h       | 2 ++
 drivers/net/ionic/ionic_mac_api.c   | 1 +
 drivers/net/ionic/ionic_main.c      | 1 +
 drivers/net/ionic/ionic_osdep.h     | 1 -
 drivers/net/ionic/ionic_rx_filter.c | 1 +
 6 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c
index aba388115..fe111a515 100644
--- a/drivers/net/ionic/ionic_dev.c
+++ b/drivers/net/ionic/ionic_dev.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
  */
+#include <stdbool.h>
 
 #include <rte_malloc.h>
 
diff --git a/drivers/net/ionic/ionic_dev.h b/drivers/net/ionic/ionic_dev.h
index 8c1ec13a6..532255a60 100644
--- a/drivers/net/ionic/ionic_dev.h
+++ b/drivers/net/ionic/ionic_dev.h
@@ -5,6 +5,8 @@
 #ifndef _IONIC_DEV_H_
 #define _IONIC_DEV_H_
 
+#include <stdbool.h>
+
 #include "ionic_osdep.h"
 #include "ionic_if.h"
 #include "ionic_regs.h"
diff --git a/drivers/net/ionic/ionic_mac_api.c b/drivers/net/ionic/ionic_mac_api.c
index 189b8b81a..40421fd4e 100644
--- a/drivers/net/ionic/ionic_mac_api.c
+++ b/drivers/net/ionic/ionic_mac_api.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
  */
+#include <stdbool.h>
 
 #include "ionic_mac_api.h"
 
diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c
index b828d230d..9d74ec73e 100644
--- a/drivers/net/ionic/ionic_main.c
+++ b/drivers/net/ionic/ionic_main.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
  */
+#include <stdbool.h>
 
 #include <rte_memzone.h>
 
diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_osdep.h
index ecdbc24e6..6ca5426ec 100644
--- a/drivers/net/ionic/ionic_osdep.h
+++ b/drivers/net/ionic/ionic_osdep.h
@@ -45,7 +45,6 @@ typedef uint32_t __le32;
 typedef uint64_t __le64;
 
 #ifndef __cplusplus
-typedef uint8_t bool;
 #define false   0
 #define true    1
 #endif
diff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c
index f75b81a27..fe624538d 100644
--- a/drivers/net/ionic/ionic_rx_filter.c
+++ b/drivers/net/ionic/ionic_rx_filter.c
@@ -3,6 +3,7 @@
  */
 
 #include <errno.h>
+#include <stdbool.h>
 
 #include <rte_malloc.h>
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/1] net/ionic: use standard stdbool.h
  2020-03-09  7:53 [dpdk-stable] [PATCH v2 1/1] net/ionic: use standard stdbool.h Sunil Kumar Kori
@ 2020-03-09  8:16 ` Jerin Jacob
  2020-03-09  8:43   ` Ferruh Yigit
  2020-03-09  9:09 ` [dpdk-stable] [PATCH v3 " Sunil Kumar Kori
  1 sibling, 1 reply; 8+ messages in thread
From: Jerin Jacob @ 2020-03-09  8:16 UTC (permalink / raw)
  To: Sunil Kumar Kori; +Cc: Alfredo Cardigliano, dpdk-dev, dpdk stable

On Mon, Mar 9, 2020 at 1:23 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> Any DPDK public header file which includes stdbool.h may conflict with
> local definition of bool, if any, which further results in compilation
> error. To avoid, used standard stdbool.h instead of defining bool
> internally.
>
> I observed this issue during a development where I included rte_uuid.h
> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
> throwing error as given below:
>
>   CC ionic_rxtx.o
> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>                  from .../dpdk/build/include/rte_ethdev.h:161,
>                  from .../dpdk/build/include/rte_ethdev_driver.h:18,
>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
> typedef uint8_t bool;
>                  ^
> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>                  from .../dpdk/drivers/net/ionic/ionic.h:13,
>                  from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
> typedef uint8_t bool;
> ^~~~~~~
> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---

>
> diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_osdep.h
> index ecdbc24e6..6ca5426ec 100644
> --- a/drivers/net/ionic/ionic_osdep.h
> +++ b/drivers/net/ionic/ionic_osdep.h
> @@ -45,7 +45,6 @@ typedef uint32_t __le32;
>  typedef uint64_t __le64;
>
>  #ifndef __cplusplus
> -typedef uint8_t bool;
>  #define false   0
>  #define true    1

You could remove the above  as well(#define false and #define true)

>  #endif

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/1] net/ionic: use standard stdbool.h
  2020-03-09  8:16 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
@ 2020-03-09  8:43   ` Ferruh Yigit
  2020-03-09  9:10     ` [dpdk-stable] [EXT] " Sunil Kumar Kori
  0 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2020-03-09  8:43 UTC (permalink / raw)
  To: Jerin Jacob, Sunil Kumar Kori; +Cc: Alfredo Cardigliano, dpdk-dev, dpdk stable

On 3/9/2020 8:16 AM, Jerin Jacob wrote:
> On Mon, Mar 9, 2020 at 1:23 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>>
>> Any DPDK public header file which includes stdbool.h may conflict with
>> local definition of bool, if any, which further results in compilation
>> error. To avoid, used standard stdbool.h instead of defining bool
>> internally.
>>
>> I observed this issue during a development where I included rte_uuid.h
>> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
>> throwing error as given below:
>>
>>   CC ionic_rxtx.o
>> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>>                  from .../dpdk/build/include/rte_ethdev.h:161,
>>                  from .../dpdk/build/include/rte_ethdev_driver.h:18,
>>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
>> typedef uint8_t bool;
>>                  ^
>> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>>                  from .../dpdk/drivers/net/ionic/ionic.h:13,
>>                  from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
>> typedef uint8_t bool;
>> ^~~~~~~
>> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
>> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
> 
>>
>> diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_osdep.h
>> index ecdbc24e6..6ca5426ec 100644
>> --- a/drivers/net/ionic/ionic_osdep.h
>> +++ b/drivers/net/ionic/ionic_osdep.h
>> @@ -45,7 +45,6 @@ typedef uint32_t __le32;
>>  typedef uint64_t __le64;
>>
>>  #ifndef __cplusplus
>> -typedef uint8_t bool;
>>  #define false   0
>>  #define true    1
> 
> You could remove the above  as well(#define false and #define true)

+1,
I need to do same thing for ionic in other patch to be able to use bool:
https://patches.dpdk.org/patch/66225/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-stable] [PATCH v3 1/1] net/ionic: use standard stdbool.h
  2020-03-09  7:53 [dpdk-stable] [PATCH v2 1/1] net/ionic: use standard stdbool.h Sunil Kumar Kori
  2020-03-09  8:16 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
@ 2020-03-09  9:09 ` Sunil Kumar Kori
  2020-03-10 15:21   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  2020-03-10 17:10   ` Ferruh Yigit
  1 sibling, 2 replies; 8+ messages in thread
From: Sunil Kumar Kori @ 2020-03-09  9:09 UTC (permalink / raw)
  To: Alfredo Cardigliano; +Cc: dev, stable, Sunil Kumar Kori

Any DPDK public header file which includes stdbool.h may conflict with
local definition of bool, if any, which further results in compilation
error. To avoid, used standard stdbool.h instead of defining bool
internally.

I observed this issue during a development where I included rte_uuid.h
into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
throwing error as given below:

  CC ionic_rxtx.o
In file included from .../dpdk/build/include/rte_uuid.h:17:0,
                 from .../dpdk/build/include/rte_ethdev.h:161,
                 from .../dpdk/build/include/rte_ethdev_driver.h:18,
                 from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
.../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
typedef uint8_t bool;
                 ^
In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
                 from .../dpdk/drivers/net/ionic/ionic.h:13,
                 from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
                 from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
.../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
typedef uint8_t bool;
^~~~~~~
cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
.../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed

Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter")
Cc: stable@dpdk.org

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v3:
 - remove #define true and false.
 - add fixes tag.
v2:
 - include stdbool.h in ionic_dev.h

 drivers/net/ionic/ionic_dev.c       | 1 +
 drivers/net/ionic/ionic_dev.h       | 2 ++
 drivers/net/ionic/ionic_mac_api.c   | 1 +
 drivers/net/ionic/ionic_main.c      | 1 +
 drivers/net/ionic/ionic_osdep.h     | 6 ------
 drivers/net/ionic/ionic_rx_filter.c | 1 +
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c
index aba388115..fe111a515 100644
--- a/drivers/net/ionic/ionic_dev.c
+++ b/drivers/net/ionic/ionic_dev.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
  */
+#include <stdbool.h>
 
 #include <rte_malloc.h>
 
diff --git a/drivers/net/ionic/ionic_dev.h b/drivers/net/ionic/ionic_dev.h
index 8c1ec13a6..532255a60 100644
--- a/drivers/net/ionic/ionic_dev.h
+++ b/drivers/net/ionic/ionic_dev.h
@@ -5,6 +5,8 @@
 #ifndef _IONIC_DEV_H_
 #define _IONIC_DEV_H_
 
+#include <stdbool.h>
+
 #include "ionic_osdep.h"
 #include "ionic_if.h"
 #include "ionic_regs.h"
diff --git a/drivers/net/ionic/ionic_mac_api.c b/drivers/net/ionic/ionic_mac_api.c
index 189b8b81a..40421fd4e 100644
--- a/drivers/net/ionic/ionic_mac_api.c
+++ b/drivers/net/ionic/ionic_mac_api.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
  */
+#include <stdbool.h>
 
 #include "ionic_mac_api.h"
 
diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c
index b828d230d..9d74ec73e 100644
--- a/drivers/net/ionic/ionic_main.c
+++ b/drivers/net/ionic/ionic_main.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
  */
+#include <stdbool.h>
 
 #include <rte_memzone.h>
 
diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_osdep.h
index ecdbc24e6..e04bb8f65 100644
--- a/drivers/net/ionic/ionic_osdep.h
+++ b/drivers/net/ionic/ionic_osdep.h
@@ -44,12 +44,6 @@ typedef uint16_t __le16;
 typedef uint32_t __le32;
 typedef uint64_t __le64;
 
-#ifndef __cplusplus
-typedef uint8_t bool;
-#define false   0
-#define true    1
-#endif
-
 static inline uint32_t div_round_up(uint32_t n, uint32_t d)
 {
 	return (n + d - 1) / d;
diff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c
index f75b81a27..fe624538d 100644
--- a/drivers/net/ionic/ionic_rx_filter.c
+++ b/drivers/net/ionic/ionic_rx_filter.c
@@ -3,6 +3,7 @@
  */
 
 #include <errno.h>
+#include <stdbool.h>
 
 #include <rte_malloc.h>
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/ionic: use standard stdbool.h
  2020-03-09  8:43   ` Ferruh Yigit
@ 2020-03-09  9:10     ` Sunil Kumar Kori
  0 siblings, 0 replies; 8+ messages in thread
From: Sunil Kumar Kori @ 2020-03-09  9:10 UTC (permalink / raw)
  To: Ferruh Yigit, Jerin Jacob; +Cc: Alfredo Cardigliano, dpdk-dev, dpdk stable

Updated. Sent next version(v3).

Regards
Sunil Kumar Kori

>-----Original Message-----
>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Monday, March 9, 2020 2:14 PM
>To: Jerin Jacob <jerinjacobk@gmail.com>; Sunil Kumar Kori
><skori@marvell.com>
>Cc: Alfredo Cardigliano <cardigliano@ntop.org>; dpdk-dev <dev@dpdk.org>;
>dpdk stable <stable@dpdk.org>
>Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/ionic: use standard stdbool.h
>
>External Email
>
>----------------------------------------------------------------------
>On 3/9/2020 8:16 AM, Jerin Jacob wrote:
>> On Mon, Mar 9, 2020 at 1:23 PM Sunil Kumar Kori <skori@marvell.com>
>wrote:
>>>
>>> Any DPDK public header file which includes stdbool.h may conflict
>>> with local definition of bool, if any, which further results in
>>> compilation error. To avoid, used standard stdbool.h instead of
>>> defining bool internally.
>>>
>>> I observed this issue during a development where I included
>>> rte_uuid.h into rte_ethdev.h. As rte_ethdev.h is included to PMD
>>> driver, it started throwing error as given below:
>>>
>>>   CC ionic_rxtx.o
>>> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>>>                  from .../dpdk/build/include/rte_ethdev.h:161,
>>>                  from .../dpdk/build/include/rte_ethdev_driver.h:18,
>>>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
>>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more
>>> data types in declaration specifiers typedef uint8_t bool;
>>>                  ^
>>> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>>>                  from .../dpdk/drivers/net/ionic/ionic.h:13,
>>>                  from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>>>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
>>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type
>>> name in empty declaration typedef uint8_t bool; ^~~~~~~
>>> cc1: warning: unrecognized command line option ‘-Wno-address-of-
>packed-member’
>>> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target
>>> 'ionic_rxtx.o' failed
>>>
>>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>>> ---
>>
>>>
>>> diff --git a/drivers/net/ionic/ionic_osdep.h
>>> b/drivers/net/ionic/ionic_osdep.h index ecdbc24e6..6ca5426ec 100644
>>> --- a/drivers/net/ionic/ionic_osdep.h
>>> +++ b/drivers/net/ionic/ionic_osdep.h
>>> @@ -45,7 +45,6 @@ typedef uint32_t __le32;  typedef uint64_t __le64;
>>>
>>>  #ifndef __cplusplus
>>> -typedef uint8_t bool;
>>>  #define false   0
>>>  #define true    1
>>
>> You could remove the above  as well(#define false and #define true)
>
>+1,
>I need to do same thing for ionic in other patch to be able to use bool:
>https://urldefense.proofpoint.com/v2/url?u=https-
>3A__patches.dpdk.org_patch_66225_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7x
>tfQ&r=dXeXaAMkP5COgn1zxHMyaF1_d9IIuq6vHQO6NrIPjaE&m=T5C3CnQeBz
>RfXkKcooV3-FN-
>R3e5MZhMonknLFnZhyE&s=OEYWfU4EaPmiYf6FXpwxDOaWV75g1wDeaASYN
>wIJiJI&e=

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h
  2020-03-09  9:09 ` [dpdk-stable] [PATCH v3 " Sunil Kumar Kori
@ 2020-03-10 15:21   ` Ferruh Yigit
  2020-03-10 15:31     ` Alfredo Cardigliano
  2020-03-10 17:10   ` Ferruh Yigit
  1 sibling, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2020-03-10 15:21 UTC (permalink / raw)
  To: Sunil Kumar Kori, Alfredo Cardigliano; +Cc: dev, stable

On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote:
> Any DPDK public header file which includes stdbool.h may conflict with
> local definition of bool, if any, which further results in compilation
> error. To avoid, used standard stdbool.h instead of defining bool
> internally.
> 
> I observed this issue during a development where I included rte_uuid.h
> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
> throwing error as given below:
> 
>   CC ionic_rxtx.o
> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>                  from .../dpdk/build/include/rte_ethdev.h:161,
>                  from .../dpdk/build/include/rte_ethdev_driver.h:18,
>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
> typedef uint8_t bool;
>                  ^
> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>                  from .../dpdk/drivers/net/ionic/ionic.h:13,
>                  from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
> typedef uint8_t bool;
> ^~~~~~~
> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
> 
> Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

Hi Alfredo,

Do you have any concern/objection on the patch? If not it will be merged soon.

Thanks,
ferruh


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h
  2020-03-10 15:21   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
@ 2020-03-10 15:31     ` Alfredo Cardigliano
  0 siblings, 0 replies; 8+ messages in thread
From: Alfredo Cardigliano @ 2020-03-10 15:31 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Sunil Kumar Kori, dev, stable



> On 10 Mar 2020, at 16:21, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote:
>> Any DPDK public header file which includes stdbool.h may conflict with
>> local definition of bool, if any, which further results in compilation
>> error. To avoid, used standard stdbool.h instead of defining bool
>> internally.
>> 
>> I observed this issue during a development where I included rte_uuid.h
>> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
>> throwing error as given below:
>> 
>>  CC ionic_rxtx.o
>> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>>                 from .../dpdk/build/include/rte_ethdev.h:161,
>>                 from .../dpdk/build/include/rte_ethdev_driver.h:18,
>>                 from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
>> typedef uint8_t bool;
>>                 ^
>> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>>                 from .../dpdk/drivers/net/ionic/ionic.h:13,
>>                 from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>>                 from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
>> typedef uint8_t bool;
>> ^~~~~~~
>> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
>> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
>> 
>> Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter")
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> 
> Hi Alfredo,
> 
> Do you have any concern/objection on the patch? If not it will be merged soon.
> 
> Thanks,
> ferruh
> 

Hi Ferruh

it looks fine, please go ahead.

Thank you
Alfredo

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h
  2020-03-09  9:09 ` [dpdk-stable] [PATCH v3 " Sunil Kumar Kori
  2020-03-10 15:21   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
@ 2020-03-10 17:10   ` Ferruh Yigit
  1 sibling, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2020-03-10 17:10 UTC (permalink / raw)
  To: Sunil Kumar Kori, Alfredo Cardigliano; +Cc: dev, stable

On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote:
> Any DPDK public header file which includes stdbool.h may conflict with
> local definition of bool, if any, which further results in compilation
> error. To avoid, used standard stdbool.h instead of defining bool
> internally.
> 
> I observed this issue during a development where I included rte_uuid.h
> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
> throwing error as given below:
> 
>   CC ionic_rxtx.o
> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>                  from .../dpdk/build/include/rte_ethdev.h:161,
>                  from .../dpdk/build/include/rte_ethdev_driver.h:18,
>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
> typedef uint8_t bool;
>                  ^
> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>                  from .../dpdk/drivers/net/ionic/ionic.h:13,
>                  from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>                  from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
> typedef uint8_t bool;
> ^~~~~~~
> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
> 
> Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

Converting Alfredo's response to explicit tag:
Acked-by: Alfredo Cardigliano <cardigliano@ntop.org>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-03-10 17:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09  7:53 [dpdk-stable] [PATCH v2 1/1] net/ionic: use standard stdbool.h Sunil Kumar Kori
2020-03-09  8:16 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-03-09  8:43   ` Ferruh Yigit
2020-03-09  9:10     ` [dpdk-stable] [EXT] " Sunil Kumar Kori
2020-03-09  9:09 ` [dpdk-stable] [PATCH v3 " Sunil Kumar Kori
2020-03-10 15:21   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2020-03-10 15:31     ` Alfredo Cardigliano
2020-03-10 17:10   ` Ferruh Yigit

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git