please help backporting some patches to stable release 20.11.10

please help backporting some patches to stable release 20.11.10

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 20.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 20.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 2023/11/22.

You can find the a temporary work-in-progress branch of the coming 20.11.10
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 20.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 20.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 20.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
47a85dda3f  Ciara Power      crypto/openssl: fix memory leaks in asym session
9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks in asym operations

RE: please help backporting some patches to stable release 20.11.10

[Power, Ciara]

Hi Luca,

> -----Original Message-----
> From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> Sent: Wednesday, November 15, 2023 11:47 AM
> To: dpdk stable <stable@dpdk.org>
> Cc: Akhil Goyal <gakhil@marvell.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>; Power, Ciara
> <ciara.power@intel.com>; Doherty, Declan <declan.doherty@intel.com>; Fan
> Zhang <roy.fan.zhang@intel.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>; Ji, Kai <kai.ji@intel.com>; Shally Verma
> <shally.verma@caviumnetworks.com>; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>
> Subject: please help backporting some patches to stable release 20.11.10
> 
> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh I didn't apply following commits from DPDK main to 20.11 stable
> branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 2023/11/22.
> 
> You can find the a temporary work-in-progress branch of the coming 20.11.10
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit in it's
> commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 20.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> 47a85dda3f  Ciara Power      crypto/openssl: fix memory leaks in asym session

This one doesn't need to be backported to 20.11 - it relates to OpenSSL 3 specific code which wasn't supported in that release.


> 9d91c3047d  Gowrishankar Muthukrishnan crypto/openssl: fix memory leaks
> in asym operations

please help backporting some patches to stable release 20.11.10

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 20.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 20.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 2023/12/01.

You can find the a temporary work-in-progress branch of the coming 20.11.10
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 20.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 20.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 20.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
4c40006c4b  Dengdui Huang    net/hns3: fix ignored reset event
b59a0cbec8  Dengdui Huang    net/hns3: fix reset event status
94cf4db160  Dengdui Huang    net/hns3: fix VF reset handler interruption

Re: please help backporting some patches to stable release 20.11.10

[huangdengdui]

Hi, Luca Boccassi

The following patchset is introduced after 20.11 and does not need to backport to 20.11.
4c40006c4b  Dengdui Huang    net/hns3: fix ignored reset event
b59a0cbec8  Dengdui Huang    net/hns3: fix reset event status
94cf4db160  Dengdui Huang    net/hns3: fix VF reset handler interruption

Thanks.
Dengdui

On 2023/11/29 10:33, luca.boccassi@gmail.com wrote:
> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
> I didn't apply following commits from DPDK main to 20.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 2023/12/01.
> 
> You can find the a temporary work-in-progress branch of the coming 20.11.10
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 20.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> 4c40006c4b  Dengdui Huang    net/hns3: fix ignored reset event
> b59a0cbec8  Dengdui Huang    net/hns3: fix reset event status
> 94cf4db160  Dengdui Huang    net/hns3: fix VF reset handler interruption

please help backporting some patches to stable release 20.11.10

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 20.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 20.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 2023/11/15.

You can find the a temporary work-in-progress branch of the coming 20.11.10
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 20.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 20.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 20.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
1e80c07472  Chaoyong He      net/nfp: fix reconfigure logic in PF initialization
d67022275d  Chaoyong He      net/nfp: fix reconfigure logic of set MAC address
1eee1ea75c  Dengdui Huang    net/hns3: fix IMP or global reset
5be38fc6c0  Dengdui Huang    net/hns3: fix multiple reset detected log
c01ffb24a2  Dengdui Huang    net/hns3: refactor interrupt state query
a4b2c6815a  Huisong Li       net/hns3: fix LRO offload to report
7bfb0d4eaf  Juraj Linkeš     config/arm: fix aarch32 build with GCC 13
867d31bed4  Maxime Coquelin  vhost: fix check on virtqueue access in async registration

please help backporting some patches to stable release 20.11.10

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 20.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 20.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 2023/10/26.

You can find the a temporary work-in-progress branch of the coming 20.11.10
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 20.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 20.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 20.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input alignment
37b68fa144  Jie Hai          app/testpmd: fix primary process not polling all queues
e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before FD close
a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
74decf3bf0  Wei Hu           net/mana: enable 32-bit build

RE: please help backporting some patches to stable release 20.11.10

[Long Li]

Hi Luca,

The following patches should not be backported to stable 20.11.

> 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

Thank you,

Long

> -----Original Message-----
> From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> Sent: Wednesday, October 18, 2023 5:03 PM
> To: dpdk stable <stable@dpdk.org>
> Cc: Abhijit Sinha <abhijit.sinha@intel.com>; Anatoly Burakov
> <anatoly.burakov@intel.com>; Beilei Xing <beilei.xing@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Chandubabu Namburu <chandu@amd.com>;
> Ciara Power <ciara.power@intel.com>; Declan Doherty
> <declan.doherty@intel.com>; Deepak Kumar Jain <deepak.k.jain@intel.com>;
> Dmitry Kozlyuk <dkozlyuk@nvidia.com>; Ferruh Yigit
> <ferruh.yigit@amd.com>; Ferruh Yigit <ferruh.yigit@intel.com>; Fiona Trahe
> <fiona.trahe@intel.com>; Hernan Vargas <hernan.vargas@intel.com>; Jie Hai
> <haijie1@huawei.com>; Jingjing Wu <jingjing.wu@intel.com>; John Griffin
> <john.griffin@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Leyi Rong <leyi.rong@intel.com>; Long Li
> <longli@microsoft.com>; Matan Azrad <matan@nvidia.com>; Maxime
> Coquelin <maxime.coquelin@redhat.com>; Nicolas Chautru
> <nicolas.chautru@intel.com>; Qi Zhang <qi.z.zhang@intel.com>; Radu Nicolau
> <radu.nicolau@intel.com>; Saurabh Singhal <saurabhs@arista.com>; Selwin
> Sebastian <selwin.sebastian@amd.com>; Somalapuram Amaranath
> <asomalap@amd.com>; Thomas Monjalon <thomas@monjalon.net>; Wei Hu
> <weh@microsoft.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>
> Subject: please help backporting some patches to stable release 20.11.10
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh I didn't apply following commits from DPDK main to 20.11 stable
> branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
>
> Please do either of the above by 2023/10/26.
>
> You can find the a temporary work-in-progress branch of the coming 20.11.10
> release at:
>
> https://gith/
> ub.com%2Fbluca%2Fdpdk-
> stable&data=05%7C01%7Clongli%40microsoft.com%7C88692d1c42094f053
> 86b08dbd036c5d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%
> 7C638332705966366690%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=sfCTswh8te9raFdLBSZoepSJDswS9XWW7f7c2e8Fzpg%3D&r
> eserved=0
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit in it's
> commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
>
> https://git.d/
> pdk.org%2Fdpdk-
> stable%2Fcommit%2F%3Fh%3D18.11%26id%3Dd90e6ae6f936ecdc2fd3811
> ff9f26aec7f3c06eb&data=05%7C01%7Clongli%40microsoft.com%7C88692d
> 1c42094f05386b08dbd036c5d6%7C72f988bf86f141af91ab2d7cd011db47
> %7C1%7C0%7C638332705966374971%7CUnknown%7CTWFpbGZsb3d8ey
> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7C3000%7C%7C%7C&sdata=Op%2Ba2zXddKaac%2BnF8bte0jARsXL77HC%
> 2FrLks11%2FtT6g%3D&reserved=0
>
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 20.11 is located at tree:
>
> https://git.d/
> pdk.org%2Fdpdk-
> stable&data=05%7C01%7Clongli%40microsoft.com%7C88692d1c42094f053
> 86b08dbd036c5d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%
> 7C638332705966383769%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=xWKECUfWfEK5KC%2BF38LGtCckByCDQlYZUl0CV8qsKv8%3
> D&reserved=0
>
> Thanks.
>
> Luca Boccassi
>
> ---
> 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input
> alignment
> 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling all
> queues
> e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before FD
> close
> a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

RE: please help backporting some patches to stable release 20.11.10

[Richardson, Bruce]

Ok to skip 12016895fc, it should not be necessary for backport.

> -----Original Message-----
> From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> Sent: Thursday, October 19, 2023 1:03 AM
> To: dpdk stable <stable@dpdk.org>
> Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Chandubabu Namburu <chandu@amd.com>; Power,
> Ciara <ciara.power@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit
> <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas,
> Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>;
> Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong
> <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad
> <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Chautru,
> Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh
> <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon
> <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Subject: please help backporting some patches to stable release 20.11.10
> 
> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh
> I didn't apply following commits from DPDK main to 20.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 2023/10/26.
> 
> You can find the a temporary work-in-progress branch of the coming
> 20.11.10
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts
> or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in
> the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 20.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input alignment
> 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling
> all queues
> e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before
> FD close
> a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

Re: please help backporting some patches to stable release 20.11.10

[Chris Brezovec (cbrezove)]

[-- Attachment #1: Type: text/plain, Size: 4593 bytes --]

Hey Bruce,

I was wondering why you thought it was ok to skip backporting 12016895fc to earlier releases?

It looks like I ran into this issue on v21.11and v22.11.  I patched this back locally and saw that we no longer were leaking mbufs in TX queue stop with IAVF.  It did not patch cleanly because https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201 was not backported either.

It does seems like this issue exists in earlier releases though, so wondering the reasoning for not backporting.

Thanks!
-Chrisb


From: Richardson, Bruce <bruce.richardson@intel.com>
Date: Monday, October 23, 2023 at 5:39 AM
To: dpdk stable <stable@dpdk.org>
Subject: RE: please help backporting some patches to stable release 20.11.10
Ok to skip 12016895fc, it should not be necessary for backport.

> -----Original Message-----
> From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> Sent: Thursday, October 19, 2023 1:03 AM
> To: dpdk stable <stable@dpdk.org>
> Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Chandubabu Namburu <chandu@amd.com>; Power,
> Ciara <ciara.power@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit
> <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas,
> Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>;
> Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong
> <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad
> <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Chautru,
> Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh
> <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon
> <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Subject: please help backporting some patches to stable release 20.11.10
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh
> I didn't apply following commits from DPDK main to 20.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
>
> Please do either of the above by 2023/10/26.
>
> You can find the a temporary work-in-progress branch of the coming
> 20.11.10
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts
> or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in
> the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 20.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Luca Boccassi
>
> ---
> 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input alignment
> 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling
> all queues
> e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before
> FD close
> a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

[-- Attachment #2: Type: text/html, Size: 8893 bytes --]

RE: please help backporting some patches to stable release 20.11.10

[Richardson, Bruce]

[-- Attachment #1: Type: text/plain, Size: 6695 bytes --]

Trying to remember now, but I believe I originally encountered the issue fixed by 12016895fc in the context of setting up runtime queue reconfiguration from commit [1]. In the absence of that new feature being backported, I assumed there was no need to backport the fix, since others had not previously reported it. Since it seems that was a mistake, we should indeed look to backport the patch in question.

Stable-tree maintainers, can we re-add 12016895fc to the list of backports for next point releases?

Regards,
/Bruce

[1] http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9d9acca8e35

PS: Link in your email is inaccessible to me, it’s perhaps a cisco-internal-only reference.

From: Chris Brezovec (cbrezove) <cbrezove@cisco.com>
Sent: Monday, March 25, 2024 1:34 PM
To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable <stable@dpdk.org>
Subject: Re: please help backporting some patches to stable release 20.11.10

Hey Bruce,

I was wondering why you thought it was ok to skip backporting 12016895fc to earlier releases?

It looks like I ran into this issue on v21.11and v22.11.  I patched this back locally and saw that we no longer were leaking mbufs in TX queue stop with IAVF.  It did not patch cleanly because https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201 was not backported either.

It does seems like this issue exists in earlier releases though, so wondering the reasoning for not backporting.

Thanks!
-Chrisb


From: Richardson, Bruce <bruce.richardson@intel.com<mailto:bruce.richardson@intel.com>>
Date: Monday, October 23, 2023 at 5:39 AM
To: dpdk stable <stable@dpdk.org<mailto:stable@dpdk.org>>
Subject: RE: please help backporting some patches to stable release 20.11.10
Ok to skip 12016895fc, it should not be necessary for backport.

> -----Original Message-----
> From: luca.boccassi@gmail.com<mailto:luca.boccassi@gmail.com> <luca.boccassi@gmail.com<mailto:luca.boccassi@gmail.com>>
> Sent: Thursday, October 19, 2023 1:03 AM
> To: dpdk stable <stable@dpdk.org<mailto:stable@dpdk.org>>
> Cc: Sinha, Abhijit <abhijit.sinha@intel.com<mailto:abhijit.sinha@intel.com>>; Burakov, Anatoly
> <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>; Xing, Beilei <beilei.xing@intel.com<mailto:beilei.xing@intel.com>>; Bernard
> Iremonger <bernard.iremonger@intel.com<mailto:bernard.iremonger@intel.com>>; Richardson, Bruce
> <bruce.richardson@intel.com<mailto:bruce.richardson@intel.com>>; Chandubabu Namburu <chandu@amd.com<mailto:chandu@amd.com>>; Power,
> Ciara <ciara.power@intel.com<mailto:ciara.power@intel.com>>; Doherty, Declan <declan.doherty@intel.com<mailto:declan.doherty@intel.com>>;
> Deepak Kumar Jain <deepak.k.jain@intel.com<mailto:deepak.k.jain@intel.com>>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com<mailto:dkozlyuk@nvidia.com>>; Ferruh Yigit <ferruh.yigit@amd.com<mailto:ferruh.yigit@amd.com>>; Ferruh Yigit
> <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>; Trahe, Fiona <fiona.trahe@intel.com<mailto:fiona.trahe@intel.com>>; Vargas,
> Hernan <hernan.vargas@intel.com<mailto:hernan.vargas@intel.com>>; Jie Hai <haijie1@huawei.com<mailto:haijie1@huawei.com>>; Wu,
> Jingjing <jingjing.wu@intel.com<mailto:jingjing.wu@intel.com>>; Griffin, John <john.griffin@intel.com<mailto:john.griffin@intel.com>>;
> Konstantin Ananyev <konstantin.ananyev@intel.com<mailto:konstantin.ananyev@intel.com>>; Leyi Rong
> <leyi.rong@intel.com<mailto:leyi.rong@intel.com>>; Long Li <longli@microsoft.com<mailto:longli@microsoft.com>>; Matan Azrad
> <matan@nvidia.com<mailto:matan@nvidia.com>>; Maxime Coquelin <maxime.coquelin@redhat.com<mailto:maxime.coquelin@redhat.com>>; Chautru,
> Nicolas <nicolas.chautru@intel.com<mailto:nicolas.chautru@intel.com>>; Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>;
> Nicolau, Radu <radu.nicolau@intel.com<mailto:radu.nicolau@intel.com>>; Singhal, Saurabh
> <saurabhs@arista.com<mailto:saurabhs@arista.com>>; Selwin Sebastian <selwin.sebastian@amd.com<mailto:selwin.sebastian@amd.com>>;
> Somalapuram Amaranath <asomalap@amd.com<mailto:asomalap@amd.com>>; Thomas Monjalon
> <thomas@monjalon.net<mailto:thomas@monjalon.net>>; Wei Hu <weh@microsoft.com<mailto:weh@microsoft.com>>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com<mailto:wenzhuo.lu@intel.com>>
> Subject: please help backporting some patches to stable release 20.11.10
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh
> I didn't apply following commits from DPDK main to 20.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 20.11 branch, or
>     - Indicate that the patch should not be backported
>
> Please do either of the above by 2023/10/26.
>
> You can find the a temporary work-in-progress branch of the coming
> 20.11.10
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts
> or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in
> the
> subject line, as we have multiple branches, for example:
>     [PATCH 20.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 20.11'
>
> Send the backported patch to "stable@dpdk.org<mailto:stable@dpdk.org>" but not "dev@dpdk.org<mailto:dev@dpdk.org>".
>
> FYI, branch 20.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Luca Boccassi
>
> ---
> 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input alignment
> 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling
> all queues
> e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before
> FD close
> a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

[-- Attachment #2: Type: text/html, Size: 13859 bytes --]

Re: please help backporting some patches to stable release 20.11.10

[Luca Boccassi]

At least for 22.11 it doesn't apply cleanly, context has changed quite
a bit, so it would need to be backported by a pmd maintainer/developer

On Mon, 25 Mar 2024 at 14:06, Richardson, Bruce
<bruce.richardson@intel.com> wrote:
>
> Trying to remember now, but I believe I originally encountered the issue fixed by 12016895fc in the context of setting up runtime queue reconfiguration from commit [1]. In the absence of that new feature being backported, I assumed there was no need to backport the fix, since others had not previously reported it. Since it seems that was a mistake, we should indeed look to backport the patch in question.
>
>
>
> Stable-tree maintainers, can we re-add 12016895fc to the list of backports for next point releases?
>
>
>
> Regards,
>
> /Bruce
>
>
>
> [1] http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9d9acca8e35
>
>
>
> PS: Link in your email is inaccessible to me, it’s perhaps a cisco-internal-only reference.
>
>
>
> From: Chris Brezovec (cbrezove) <cbrezove@cisco.com>
> Sent: Monday, March 25, 2024 1:34 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable <stable@dpdk.org>
> Subject: Re: please help backporting some patches to stable release 20.11.10
>
>
>
> Hey Bruce,
>
>
>
> I was wondering why you thought it was ok to skip backporting 12016895fc to earlier releases?
>
>
>
> It looks like I ran into this issue on v21.11and v22.11.  I patched this back locally and saw that we no longer were leaking mbufs in TX queue stop with IAVF.  It did not patch cleanly because https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201 was not backported either.
>
>
>
> It does seems like this issue exists in earlier releases though, so wondering the reasoning for not backporting.
>
>
>
> Thanks!
>
> -Chrisb
>
>
>
>
>
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Date: Monday, October 23, 2023 at 5:39 AM
> To: dpdk stable <stable@dpdk.org>
> Subject: RE: please help backporting some patches to stable release 20.11.10
>
> Ok to skip 12016895fc, it should not be necessary for backport.
>
> > -----Original Message-----
> > From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> > Sent: Thursday, October 19, 2023 1:03 AM
> > To: dpdk stable <stable@dpdk.org>
> > Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Bernard
> > Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; Chandubabu Namburu <chandu@amd.com>; Power,
> > Ciara <ciara.power@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> > Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk
> > <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit
> > <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas,
> > Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu,
> > Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>;
> > Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong
> > <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad
> > <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Chautru,
> > Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh
> > <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> > Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon
> > <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>
> > Subject: please help backporting some patches to stable release 20.11.10
> >
> > Hi commit authors (and maintainers),
> >
> > Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> > fixes.sh
> > I didn't apply following commits from DPDK main to 20.11
> > stable branch, as conflicts or build errors occur.
> >
> > Can authors check your patches in the following list and either:
> >     - Backport your patches to the 20.11 branch, or
> >     - Indicate that the patch should not be backported
> >
> > Please do either of the above by 2023/10/26.
> >
> > You can find the a temporary work-in-progress branch of the coming
> > 20.11.10
> > release at:
> >     https://github.com/bluca/dpdk-stable
> > It is recommended to backport on top of that to minimize further conflicts
> > or
> > misunderstandings.
> >
> > Some notes on stable backports:
> >
> > A backport should contain a reference to the DPDK main branch commit
> > in it's commit message in the following fashion:
> >     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> >
> > For example:
> >     https://git.dpdk.org/dpdk-
> > stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> >
> > When sending the backported patch, please indicate the target branch in
> > the
> > subject line, as we have multiple branches, for example:
> >     [PATCH 20.11] foo/bar: fix baz
> >
> > With git format-patch, this can be achieved by appending the parameter:
> >     --subject-prefix='PATCH 20.11'
> >
> > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> >
> > FYI, branch 20.11 is located at tree:
> >    https://git.dpdk.org/dpdk-stable
> >
> > Thanks.
> >
> > Luca Boccassi
> >
> > ---
> > 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> > d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> > 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input alignment
> > 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling
> > all queues
> > e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before
> > FD close
> > a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> > 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> > 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

RE: please help backporting some patches to stable release 20.11.10

[Richardson, Bruce]

Hi Chris,

You say in your original mail that you have already got backported versions of the patch in question. Would you be in a position to upstream those backports to the DPDK community, by emailing them to DPDK stable?

Thanks,
/Bruce

> -----Original Message-----
> From: Luca Boccassi <luca.boccassi@gmail.com>
> Sent: Monday, March 25, 2024 2:28 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: Chris Brezovec (cbrezove) <cbrezove@cisco.com>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: please help backporting some patches to stable release 20.11.10
> 
> At least for 22.11 it doesn't apply cleanly, context has changed quite
> a bit, so it would need to be backported by a pmd maintainer/developer
> 
> On Mon, 25 Mar 2024 at 14:06, Richardson, Bruce
> <bruce.richardson@intel.com> wrote:
> >
> > Trying to remember now, but I believe I originally encountered the issue fixed
> by 12016895fc in the context of setting up runtime queue reconfiguration
> from commit [1]. In the absence of that new feature being backported, I
> assumed there was no need to backport the fix, since others had not
> previously reported it. Since it seems that was a mistake, we should indeed
> look to backport the patch in question.
> >
> >
> >
> > Stable-tree maintainers, can we re-add 12016895fc to the list of backports
> for next point releases?
> >
> >
> >
> > Regards,
> >
> > /Bruce
> >
> >
> >
> > [1]
> http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9
> d9acca8e35
> >
> >
> >
> > PS: Link in your email is inaccessible to me, it’s perhaps a cisco-internal-only
> reference.
> >
> >
> >
> > From: Chris Brezovec (cbrezove) <cbrezove@cisco.com>
> > Sent: Monday, March 25, 2024 1:34 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable
> <stable@dpdk.org>
> > Subject: Re: please help backporting some patches to stable release
> 20.11.10
> >
> >
> >
> > Hey Bruce,
> >
> >
> >
> > I was wondering why you thought it was ok to skip backporting 12016895fc
> to earlier releases?
> >
> >
> >
> > It looks like I ran into this issue on v21.11and v22.11.  I patched this back
> locally and saw that we no longer were leaking mbufs in TX queue stop with
> IAVF.  It did not patch cleanly because https://polaris-git.cisco.com/iosxe-
> dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201
> was not backported either.
> >
> >
> >
> > It does seems like this issue exists in earlier releases though, so wondering
> the reasoning for not backporting.
> >
> >
> >
> > Thanks!
> >
> > -Chrisb
> >
> >
> >
> >
> >
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Date: Monday, October 23, 2023 at 5:39 AM
> > To: dpdk stable <stable@dpdk.org>
> > Subject: RE: please help backporting some patches to stable release
> 20.11.10
> >
> > Ok to skip 12016895fc, it should not be necessary for backport.
> >
> > > -----Original Message-----
> > > From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> > > Sent: Thursday, October 19, 2023 1:03 AM
> > > To: dpdk stable <stable@dpdk.org>
> > > Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly
> > > <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Bernard
> > > Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce
> > > <bruce.richardson@intel.com>; Chandubabu Namburu
> <chandu@amd.com>; Power,
> > > Ciara <ciara.power@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>;
> > > Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk
> > > <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit
> > > <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas,
> > > Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu,
> > > Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>;
> > > Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong
> > > <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad
> > > <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>;
> Chautru,
> > > Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > > Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh
> > > <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> > > Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon
> > > <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo
> > > <wenzhuo.lu@intel.com>
> > > Subject: please help backporting some patches to stable release 20.11.10
> > >
> > > Hi commit authors (and maintainers),
> > >
> > > Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> > > fixes.sh
> > > I didn't apply following commits from DPDK main to 20.11
> > > stable branch, as conflicts or build errors occur.
> > >
> > > Can authors check your patches in the following list and either:
> > >     - Backport your patches to the 20.11 branch, or
> > >     - Indicate that the patch should not be backported
> > >
> > > Please do either of the above by 2023/10/26.
> > >
> > > You can find the a temporary work-in-progress branch of the coming
> > > 20.11.10
> > > release at:
> > >     https://github.com/bluca/dpdk-stable
> > > It is recommended to backport on top of that to minimize further conflicts
> > > or
> > > misunderstandings.
> > >
> > > Some notes on stable backports:
> > >
> > > A backport should contain a reference to the DPDK main branch commit
> > > in it's commit message in the following fashion:
> > >     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> > >
> > > For example:
> > >     https://git.dpdk.org/dpdk-
> > >
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> > >
> > > When sending the backported patch, please indicate the target branch in
> > > the
> > > subject line, as we have multiple branches, for example:
> > >     [PATCH 20.11] foo/bar: fix baz
> > >
> > > With git format-patch, this can be achieved by appending the parameter:
> > >     --subject-prefix='PATCH 20.11'
> > >
> > > Send the backported patch to "stable@dpdk.org" but not
> "dev@dpdk.org".
> > >
> > > FYI, branch 20.11 is located at tree:
> > >    https://git.dpdk.org/dpdk-stable
> > >
> > > Thanks.
> > >
> > > Luca Boccassi
> > >
> > > ---
> > > 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> > > d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> > > 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input
> alignment
> > > 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling
> > > all queues
> > > e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before
> > > FD close
> > > a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> > > 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> > > 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

Re: please help backporting some patches to stable release 20.11.10

[Chris Brezovec (cbrezove)]

[-- Attachment #1: Type: text/plain, Size: 7485 bytes --]

Hi Bruce,

I can work to get my backported version out to the community and upstreamed.

Thanks,
-Chrisb

From: Richardson, Bruce <bruce.richardson@intel.com>
Date: Tuesday, March 26, 2024 at 11:10 AM
To: Luca Boccassi <luca.boccassi@gmail.com>
Cc: Chris Brezovec (cbrezove) <cbrezove@cisco.com>, dpdk stable <stable@dpdk.org>
Subject: RE: please help backporting some patches to stable release 20.11.10
Hi Chris,

You say in your original mail that you have already got backported versions of the patch in question. Would you be in a position to upstream those backports to the DPDK community, by emailing them to DPDK stable?

Thanks,
/Bruce

> -----Original Message-----
> From: Luca Boccassi <luca.boccassi@gmail.com>
> Sent: Monday, March 25, 2024 2:28 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: Chris Brezovec (cbrezove) <cbrezove@cisco.com>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: please help backporting some patches to stable release 20.11.10
>
> At least for 22.11 it doesn't apply cleanly, context has changed quite
> a bit, so it would need to be backported by a pmd maintainer/developer
>
> On Mon, 25 Mar 2024 at 14:06, Richardson, Bruce
> <bruce.richardson@intel.com> wrote:
> >
> > Trying to remember now, but I believe I originally encountered the issue fixed
> by 12016895fc in the context of setting up runtime queue reconfiguration
> from commit [1]. In the absence of that new feature being backported, I
> assumed there was no need to backport the fix, since others had not
> previously reported it. Since it seems that was a mistake, we should indeed
> look to backport the patch in question.
> >
> >
> >
> > Stable-tree maintainers, can we re-add 12016895fc to the list of backports
> for next point releases?
> >
> >
> >
> > Regards,
> >
> > /Bruce
> >
> >
> >
> > [1]
> http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9
> d9acca8e35
> >
> >
> >
> > PS: Link in your email is inaccessible to me, it’s perhaps a cisco-internal-only
> reference.
> >
> >
> >
> > From: Chris Brezovec (cbrezove) <cbrezove@cisco.com>
> > Sent: Monday, March 25, 2024 1:34 PM
> > To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable
> <stable@dpdk.org>
> > Subject: Re: please help backporting some patches to stable release
> 20.11.10
> >
> >
> >
> > Hey Bruce,
> >
> >
> >
> > I was wondering why you thought it was ok to skip backporting 12016895fc
> to earlier releases?
> >
> >
> >
> > It looks like I ran into this issue on v21.11and v22.11.  I patched this back
> locally and saw that we no longer were leaking mbufs in TX queue stop with
> IAVF.  It did not patch cleanly because https://polaris-git.cisco.com/iosxe-
> dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201
> was not backported either.
> >
> >
> >
> > It does seems like this issue exists in earlier releases though, so wondering
> the reasoning for not backporting.
> >
> >
> >
> > Thanks!
> >
> > -Chrisb
> >
> >
> >
> >
> >
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Date: Monday, October 23, 2023 at 5:39 AM
> > To: dpdk stable <stable@dpdk.org>
> > Subject: RE: please help backporting some patches to stable release
> 20.11.10
> >
> > Ok to skip 12016895fc, it should not be necessary for backport.
> >
> > > -----Original Message-----
> > > From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> > > Sent: Thursday, October 19, 2023 1:03 AM
> > > To: dpdk stable <stable@dpdk.org>
> > > Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly
> > > <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Bernard
> > > Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce
> > > <bruce.richardson@intel.com>; Chandubabu Namburu
> <chandu@amd.com>; Power,
> > > Ciara <ciara.power@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>;
> > > Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk
> > > <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit
> > > <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas,
> > > Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu,
> > > Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>;
> > > Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong
> > > <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad
> > > <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>;
> Chautru,
> > > Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > > Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh
> > > <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>;
> > > Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon
> > > <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo
> > > <wenzhuo.lu@intel.com>
> > > Subject: please help backporting some patches to stable release 20.11.10
> > >
> > > Hi commit authors (and maintainers),
> > >
> > > Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> > > fixes.sh
> > > I didn't apply following commits from DPDK main to 20.11
> > > stable branch, as conflicts or build errors occur.
> > >
> > > Can authors check your patches in the following list and either:
> > >     - Backport your patches to the 20.11 branch, or
> > >     - Indicate that the patch should not be backported
> > >
> > > Please do either of the above by 2023/10/26.
> > >
> > > You can find the a temporary work-in-progress branch of the coming
> > > 20.11.10
> > > release at:
> > >     https://github.com/bluca/dpdk-stable
> > > It is recommended to backport on top of that to minimize further conflicts
> > > or
> > > misunderstandings.
> > >
> > > Some notes on stable backports:
> > >
> > > A backport should contain a reference to the DPDK main branch commit
> > > in it's commit message in the following fashion:
> > >     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> > >
> > > For example:
> > >     https://git.dpdk.org/dpdk-
> > >
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> > >
> > > When sending the backported patch, please indicate the target branch in
> > > the
> > > subject line, as we have multiple branches, for example:
> > >     [PATCH 20.11] foo/bar: fix baz
> > >
> > > With git format-patch, this can be achieved by appending the parameter:
> > >     --subject-prefix='PATCH 20.11'
> > >
> > > Send the backported patch to "stable@dpdk.org" but not
> "dev@dpdk.org".
> > >
> > > FYI, branch 20.11 is located at tree:
> > >    https://git.dpdk.org/dpdk-stable
> > >
> > > Thanks.
> > >
> > > Luca Boccassi
> > >
> > > ---
> > > 12016895fc  Bruce Richardson net/iavf: fix buffer leak on Tx queue stop
> > > d7d52b37e8  Ciara Power      crypto/qat: fix raw API null algorithm digest
> > > 7d04891664  Hernan Vargas    baseband/acc: fix ACC100 HARQ input
> alignment
> > > 37b68fa144  Jie Hai          app/testpmd: fix primary process not polling
> > > all queues
> > > e35a5737a7  Saurabh Singhal  net/iavf: unregister interrupt handler before
> > > FD close
> > > a27ff9cac1  Selwin Sebastian net/axgbe: identify CPU with cpuid
> > > 26c6bdf3d1  Wei Hu           net/mana: add 32-bit short doorbell
> > > 74decf3bf0  Wei Hu           net/mana: enable 32-bit build

[-- Attachment #2: Type: text/html, Size: 12963 bytes --]