DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] ci: restrict concurrency
@ 2022-01-12  6:50 Josh Soref
  2022-01-12  6:50 ` [PATCH 1/1] " Josh Soref
  0 siblings, 1 reply; 4+ messages in thread
From: Josh Soref @ 2022-01-12  6:50 UTC (permalink / raw)
  To: dev; +Cc: Josh Soref

dpdk is fairly expensive to build in GitHub.

It's helpful to abandon old builds as soon as there's a new
build waiting instead of wasting resources on the previous
round.

Josh Soref (1):
  ci: restrict concurrency

 .github/workflows/build.yml | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.32.0 (Apple Git-132)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] ci: restrict concurrency
  2022-01-12  6:50 [PATCH 0/1] ci: restrict concurrency Josh Soref
@ 2022-01-12  6:50 ` Josh Soref
  2022-01-13 11:42   ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Josh Soref @ 2022-01-12  6:50 UTC (permalink / raw)
  To: dev; +Cc: Josh Soref

Signed-off-by: Josh Soref <jsoref@gmail.com>
---
 .github/workflows/build.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6cf997d6..a171d430 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -12,6 +12,9 @@ defaults:
 jobs:
   build:
     name: ${{ join(matrix.config.*, '-') }}
+    concurrency:
+      group: build-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-${{ matrix.config.mini }}-${{ github.event.pull_request.number || github.ref }}
+      cancel-in-progress: true
     runs-on: ${{ matrix.config.os }}
     env:
       AARCH64: ${{ matrix.config.cross == 'aarch64' }}
-- 
2.32.0 (Apple Git-132)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] ci: restrict concurrency
  2022-01-12  6:50 ` [PATCH 1/1] " Josh Soref
@ 2022-01-13 11:42   ` Thomas Monjalon
  2022-01-13 12:41     ` Josh Soref
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2022-01-13 11:42 UTC (permalink / raw)
  To: Josh Soref; +Cc: dev

Hi,

The explanation should be in the patch, not the cover letter.
Actually, you don't need a cover letter for a single patch.
Copying it here:
"
dpdk is fairly expensive to build in GitHub.

It's helpful to abandon old builds as soon as there's a new
build waiting instead of wasting resources on the previous
round.
"

12/01/2022 07:50, Josh Soref:
> Signed-off-by: Josh Soref <jsoref@gmail.com>
> ---
> +    concurrency:
> +      group: build-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-${{ matrix.config.mini }}-${{ github.event.pull_request.number || github.ref }}
> +      cancel-in-progress: true

The goal of the CI is to catch any issue in a submitted patch.
Is your change cancelling a test of a patch when another one is submitted?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] ci: restrict concurrency
  2022-01-13 11:42   ` Thomas Monjalon
@ 2022-01-13 12:41     ` Josh Soref
  0 siblings, 0 replies; 4+ messages in thread
From: Josh Soref @ 2022-01-13 12:41 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi,
>
> The explanation should be in the patch, not the cover letter.
> Actually, you don't need a cover letter for a single patch.
> Copying it here:
> "
> dpdk is fairly expensive to build in GitHub.
>
> It's helpful to abandon old builds as soon as there's a new
> build waiting instead of wasting resources on the previous
> round.
> "
>
> 12/01/2022 07:50, Josh Soref:
> > Signed-off-by: Josh Soref <jsoref@gmail.com>
> > ---
> > +    concurrency:
> > +      group: build-${{ matrix.config.os }}-${{ matrix.config.compiler
> }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-${{
> matrix.config.mini }}-${{ github.event.pull_request.number || github.ref }}
> > +      cancel-in-progress: true
>
> The goal of the CI is to catch any issue in a submitted patch.
> Is your change cancelling a test of a patch when another one is submitted?
>

If it's on the same branch or if it's in the same pull request yes,
otherwise, no.

>

[-- Attachment #2: Type: text/html, Size: 1701 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-13 12:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12  6:50 [PATCH 0/1] ci: restrict concurrency Josh Soref
2022-01-12  6:50 ` [PATCH 1/1] " Josh Soref
2022-01-13 11:42   ` Thomas Monjalon
2022-01-13 12:41     ` Josh Soref

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git