* [PATCH 0/1] *** Update drivers/net/gve/base code for DQO *** @ 2023-04-11 4:59 Rushil Gupta 2023-04-11 4:59 ` [PATCH 1/1] net/gve: update base code for DQO Rushil Gupta 0 siblings, 1 reply; 13+ messages in thread From: Rushil Gupta @ 2023-04-11 4:59 UTC (permalink / raw) To: qi.z.zhang, ferruh.yigit; +Cc: bruce.richardson, dev, Rushil Gupta This patch is dependent on https://patchwork.dpdk.org/project/dpdk/patch/20230410064724.2094392-1-junfeng.guo@intel.com/ Rushil Gupta (1): net/gve: update base code for DQO drivers/net/gve/base/gve.h | 1 + drivers/net/gve/base/gve_adminq.c | 10 +++++----- drivers/net/gve/base/gve_desc_dqo.h | 4 ---- 3 files changed, 6 insertions(+), 9 deletions(-) -- 2.40.0.577.gac1e443424-goog ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/1] net/gve: update base code for DQO 2023-04-11 4:59 [PATCH 0/1] *** Update drivers/net/gve/base code for DQO *** Rushil Gupta @ 2023-04-11 4:59 ` Rushil Gupta 2023-04-11 6:51 ` Guo, Junfeng 2023-05-04 8:30 ` Ferruh Yigit 0 siblings, 2 replies; 13+ messages in thread From: Rushil Gupta @ 2023-04-11 4:59 UTC (permalink / raw) To: qi.z.zhang, ferruh.yigit; +Cc: bruce.richardson, dev, Rushil Gupta, Junfeng Guo Update gve base code to support DQO. This patch is based on this: https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* Signed-off-by: Rushil Gupta <rushilg@google.com> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> --- drivers/net/gve/base/gve.h | 1 + drivers/net/gve/base/gve_adminq.c | 10 +++++----- drivers/net/gve/base/gve_desc_dqo.h | 4 ---- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h index 2dc4507acb..2b7cf7d99b 100644 --- a/drivers/net/gve/base/gve.h +++ b/drivers/net/gve/base/gve.h @@ -7,6 +7,7 @@ #define _GVE_H_ #include "gve_desc.h" +#include "gve_desc_dqo.h" #define GVE_VERSION "1.3.0" #define GVE_VERSION_PREFIX "GVE-" diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c index e745b709b2..e963f910a0 100644 --- a/drivers/net/gve/base/gve_adminq.c +++ b/drivers/net/gve/base/gve_adminq.c @@ -497,11 +497,11 @@ static int gve_adminq_create_tx_queue(struct gve_priv *priv, u32 queue_index) cmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id); } else { cmd.create_tx_queue.tx_ring_size = - cpu_to_be16(txq->nb_tx_desc); + cpu_to_be16(priv->tx_desc_cnt); cmd.create_tx_queue.tx_comp_ring_addr = - cpu_to_be64(txq->complq->tx_ring_phys_addr); + cpu_to_be64(txq->compl_ring_phys_addr); cmd.create_tx_queue.tx_comp_ring_size = - cpu_to_be16(priv->tx_compq_size); + cpu_to_be16(priv->tx_compq_size * DQO_TX_MULTIPLIER); } return gve_adminq_issue_cmd(priv, &cmd); @@ -549,9 +549,9 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index) cmd.create_rx_queue.rx_ring_size = cpu_to_be16(priv->rx_desc_cnt); cmd.create_rx_queue.rx_desc_ring_addr = - cpu_to_be64(rxq->rx_ring_phys_addr); + cpu_to_be64(rxq->compl_ring_phys_addr); cmd.create_rx_queue.rx_data_ring_addr = - cpu_to_be64(rxq->bufq->rx_ring_phys_addr); + cpu_to_be64(rxq->rx_ring_phys_addr); cmd.create_rx_queue.packet_buffer_size = cpu_to_be16(rxq->rx_buf_len); cmd.create_rx_queue.rx_buff_ring_size = diff --git a/drivers/net/gve/base/gve_desc_dqo.h b/drivers/net/gve/base/gve_desc_dqo.h index ee1afdecb8..bb4a18d4d1 100644 --- a/drivers/net/gve/base/gve_desc_dqo.h +++ b/drivers/net/gve/base/gve_desc_dqo.h @@ -13,10 +13,6 @@ #define GVE_TX_MAX_HDR_SIZE_DQO 255 #define GVE_TX_MIN_TSO_MSS_DQO 88 -#ifndef __LITTLE_ENDIAN_BITFIELD -#error "Only little endian supported" -#endif - /* Basic TX descriptor (DTYPE 0x0C) */ struct gve_tx_pkt_desc_dqo { __le64 buf_addr; -- 2.40.0.577.gac1e443424-goog ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 1/1] net/gve: update base code for DQO 2023-04-11 4:59 ` [PATCH 1/1] net/gve: update base code for DQO Rushil Gupta @ 2023-04-11 6:51 ` Guo, Junfeng 2023-04-12 8:50 ` Ferruh Yigit 2023-05-04 8:30 ` Ferruh Yigit 1 sibling, 1 reply; 13+ messages in thread From: Guo, Junfeng @ 2023-04-11 6:51 UTC (permalink / raw) To: ferruh.yigit, Richardson, Bruce; +Cc: dev, Zhang, Qi Z, Rushil Gupta Hi Ferruh & Bruce, This patch contains few lines change for the MIT licensed gve base code. Note that there is no new files added, just some minor code update. Do we need to ask for special approval from the Tech Board for this? Please help give some advice and also help review this patch. Thanks! BTW, Google will also help replace all the base code under MIT license with the ones under BSD-3 license soon, which would make things more easier. Regards, Junfeng > -----Original Message----- > From: Rushil Gupta <rushilg@google.com> > Sent: Tuesday, April 11, 2023 12:59 > To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com > Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; > Rushil Gupta <rushilg@google.com>; Guo, Junfeng > <junfeng.guo@intel.com> > Subject: [PATCH 1/1] net/gve: update base code for DQO > > Update gve base code to support DQO. > > This patch is based on this: > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > > Signed-off-by: Rushil Gupta <rushilg@google.com> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> > --- > drivers/net/gve/base/gve.h | 1 + > drivers/net/gve/base/gve_adminq.c | 10 +++++----- > drivers/net/gve/base/gve_desc_dqo.h | 4 ---- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h > index 2dc4507acb..2b7cf7d99b 100644 > --- a/drivers/net/gve/base/gve.h > +++ b/drivers/net/gve/base/gve.h > @@ -7,6 +7,7 @@ > #define _GVE_H_ > > #include "gve_desc.h" > +#include "gve_desc_dqo.h" > > #define GVE_VERSION "1.3.0" > #define GVE_VERSION_PREFIX "GVE-" > diff --git a/drivers/net/gve/base/gve_adminq.c > b/drivers/net/gve/base/gve_adminq.c > index e745b709b2..e963f910a0 100644 > --- a/drivers/net/gve/base/gve_adminq.c > +++ b/drivers/net/gve/base/gve_adminq.c > @@ -497,11 +497,11 @@ static int gve_adminq_create_tx_queue(struct > gve_priv *priv, u32 queue_index) > cmd.create_tx_queue.queue_page_list_id = > cpu_to_be32(qpl_id); > } else { > cmd.create_tx_queue.tx_ring_size = > - cpu_to_be16(txq->nb_tx_desc); > + cpu_to_be16(priv->tx_desc_cnt); > cmd.create_tx_queue.tx_comp_ring_addr = > - cpu_to_be64(txq->complq->tx_ring_phys_addr); > + cpu_to_be64(txq->compl_ring_phys_addr); > cmd.create_tx_queue.tx_comp_ring_size = > - cpu_to_be16(priv->tx_compq_size); > + cpu_to_be16(priv->tx_compq_size * > DQO_TX_MULTIPLIER); > } > > return gve_adminq_issue_cmd(priv, &cmd); > @@ -549,9 +549,9 @@ static int gve_adminq_create_rx_queue(struct > gve_priv *priv, u32 queue_index) > cmd.create_rx_queue.rx_ring_size = > cpu_to_be16(priv->rx_desc_cnt); > cmd.create_rx_queue.rx_desc_ring_addr = > - cpu_to_be64(rxq->rx_ring_phys_addr); > + cpu_to_be64(rxq->compl_ring_phys_addr); > cmd.create_rx_queue.rx_data_ring_addr = > - cpu_to_be64(rxq->bufq->rx_ring_phys_addr); > + cpu_to_be64(rxq->rx_ring_phys_addr); > cmd.create_rx_queue.packet_buffer_size = > cpu_to_be16(rxq->rx_buf_len); > cmd.create_rx_queue.rx_buff_ring_size = > diff --git a/drivers/net/gve/base/gve_desc_dqo.h > b/drivers/net/gve/base/gve_desc_dqo.h > index ee1afdecb8..bb4a18d4d1 100644 > --- a/drivers/net/gve/base/gve_desc_dqo.h > +++ b/drivers/net/gve/base/gve_desc_dqo.h > @@ -13,10 +13,6 @@ > #define GVE_TX_MAX_HDR_SIZE_DQO 255 > #define GVE_TX_MIN_TSO_MSS_DQO 88 > > -#ifndef __LITTLE_ENDIAN_BITFIELD > -#error "Only little endian supported" > -#endif > - > /* Basic TX descriptor (DTYPE 0x0C) */ > struct gve_tx_pkt_desc_dqo { > __le64 buf_addr; > -- > 2.40.0.577.gac1e443424-goog ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-11 6:51 ` Guo, Junfeng @ 2023-04-12 8:50 ` Ferruh Yigit 2023-04-12 9:09 ` Guo, Junfeng 0 siblings, 1 reply; 13+ messages in thread From: Ferruh Yigit @ 2023-04-12 8:50 UTC (permalink / raw) To: Guo, Junfeng, Richardson, Bruce; +Cc: dev, Zhang, Qi Z, Rushil Gupta On 4/11/2023 7:51 AM, Guo, Junfeng wrote: Hi Junfeng, message moved down. > >> -----Original Message----- >> From: Rushil Gupta <rushilg@google.com> >> Sent: Tuesday, April 11, 2023 12:59 >> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com >> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; >> Rushil Gupta <rushilg@google.com>; Guo, Junfeng >> <junfeng.guo@intel.com> >> Subject: [PATCH 1/1] net/gve: update base code for DQO >> >> Update gve base code to support DQO. >> >> This patch is based on this: >> https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* >> >> Signed-off-by: Rushil Gupta <rushilg@google.com> >> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> > Hi Ferruh & Bruce, > > This patch contains few lines change for the MIT licensed gve base code. > Note that there is no new files added, just some minor code update. > > Do we need to ask for special approval from the Tech Board for this? > Please help give some advice and also help review this patch. Thanks! > Once the MIT license exception is in place, as far as I know no more approval is required per change. > BTW, Google will also help replace all the base code under MIT license > with the ones under BSD-3 license soon, which would make things more > easier. > Is this different from base code under DPDK is changing license [1] ? [1] https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&archive=both ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 8:50 ` Ferruh Yigit @ 2023-04-12 9:09 ` Guo, Junfeng 2023-04-12 9:34 ` Ferruh Yigit 0 siblings, 1 reply; 13+ messages in thread From: Guo, Junfeng @ 2023-04-12 9:09 UTC (permalink / raw) To: Ferruh Yigit, Richardson, Bruce; +Cc: dev, Zhang, Qi Z, Rushil Gupta > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@amd.com> > Sent: Wednesday, April 12, 2023 16:50 > To: Guo, Junfeng <junfeng.guo@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Rushil Gupta > <rushilg@google.com> > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > Hi Junfeng, message moved down. > > > > >> -----Original Message----- > >> From: Rushil Gupta <rushilg@google.com> > >> Sent: Tuesday, April 11, 2023 12:59 > >> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com > >> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; > >> Rushil Gupta <rushilg@google.com>; Guo, Junfeng > >> <junfeng.guo@intel.com> > >> Subject: [PATCH 1/1] net/gve: update base code for DQO > >> > >> Update gve base code to support DQO. > >> > >> This patch is based on this: > >> https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > >> > >> Signed-off-by: Rushil Gupta <rushilg@google.com> > >> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> > > Hi Ferruh & Bruce, > > > > This patch contains few lines change for the MIT licensed gve base code. > > Note that there is no new files added, just some minor code update. > > > > Do we need to ask for special approval from the Tech Board for this? > > Please help give some advice and also help review this patch. Thanks! > > > > Once the MIT license exception is in place, as far as I know no more > approval is required per change. Got it, thanks the comment! Then we may also need your help to review, as well as the coming patch set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > BTW, Google will also help replace all the base code under MIT license > > with the ones under BSD-3 license soon, which would make things more > > easier. > > > > Is this different from base code under DPDK is changing license [1] ? > > > [1] > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar > chive=both > The patch set of the above link only contains the processing of replace the MIT licensed base code with the BSD-3 licensed base code. After some discussion, we think Google is in the right place to do that work. And they are working on that now. This patch is mainly for the feature upstreaming of DPDK 23.07. It contains only the code part, following previous license statements, without any license change. This patch is separated and sent by Google, to ensure there is no license violation. BTW, about the feature of GVE PMD enhancement, the rest code are all about BSD-3 licensed files, and that patch set will be sent out soon. Thanks! ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 9:09 ` Guo, Junfeng @ 2023-04-12 9:34 ` Ferruh Yigit 2023-04-12 9:41 ` Guo, Junfeng 0 siblings, 1 reply; 13+ messages in thread From: Ferruh Yigit @ 2023-04-12 9:34 UTC (permalink / raw) To: Guo, Junfeng, Richardson, Bruce; +Cc: dev, Zhang, Qi Z, Rushil Gupta On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@amd.com> >> Sent: Wednesday, April 12, 2023 16:50 >> To: Guo, Junfeng <junfeng.guo@intel.com>; Richardson, Bruce >> <bruce.richardson@intel.com> >> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Rushil Gupta >> <rushilg@google.com> >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO >> >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: >> >> Hi Junfeng, message moved down. >> >>> >>>> -----Original Message----- >>>> From: Rushil Gupta <rushilg@google.com> >>>> Sent: Tuesday, April 11, 2023 12:59 >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org; >>>> Rushil Gupta <rushilg@google.com>; Guo, Junfeng >>>> <junfeng.guo@intel.com> >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO >>>> >>>> Update gve base code to support DQO. >>>> >>>> This patch is based on this: >>>> https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* >>>> >>>> Signed-off-by: Rushil Gupta <rushilg@google.com> >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> >>> Hi Ferruh & Bruce, >>> >>> This patch contains few lines change for the MIT licensed gve base code. >>> Note that there is no new files added, just some minor code update. >>> >>> Do we need to ask for special approval from the Tech Board for this? >>> Please help give some advice and also help review this patch. Thanks! >>> >> >> Once the MIT license exception is in place, as far as I know no more >> approval is required per change. > > Got it, thanks the comment! > > Then we may also need your help to review, as well as the coming patch > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > >> >>> BTW, Google will also help replace all the base code under MIT license >>> with the ones under BSD-3 license soon, which would make things more >>> easier. >>> >> >> Is this different from base code under DPDK is changing license [1] ? >> >> >> [1] >> https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar >> chive=both >> > > The patch set of the above link only contains the processing of replace the > MIT licensed base code with the BSD-3 licensed base code. After some > discussion, we think Google is in the right place to do that work. And they > are working on that now. > Is the Google GVE driver [2] in the process of changing license from MIT to BSD-3? [2] https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/tree/v1.3.0/google/gve > This patch is mainly for the feature upstreaming of DPDK 23.07. It contains > only the code part, following previous license statements, without any > license change. > > This patch is separated and sent by Google, to ensure there is no license > violation. > > BTW, about the feature of GVE PMD enhancement, the rest code are all > about BSD-3 licensed files, and that patch set will be sent out soon. > > Thanks! ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 9:34 ` Ferruh Yigit @ 2023-04-12 9:41 ` Guo, Junfeng 2023-04-12 15:42 ` Rushil Gupta 0 siblings, 1 reply; 13+ messages in thread From: Guo, Junfeng @ 2023-04-12 9:41 UTC (permalink / raw) To: Ferruh Yigit, Richardson, Bruce, Rushil Gupta; +Cc: dev, Zhang, Qi Z > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@amd.com> > Sent: Wednesday, April 12, 2023 17:35 > To: Guo, Junfeng <junfeng.guo@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Rushil Gupta > <rushilg@google.com> > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > >> -----Original Message----- > >> From: Ferruh Yigit <ferruh.yigit@amd.com> > >> Sent: Wednesday, April 12, 2023 16:50 > >> To: Guo, Junfeng <junfeng.guo@intel.com>; Richardson, Bruce > >> <bruce.richardson@intel.com> > >> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Rushil Gupta > >> <rushilg@google.com> > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > >> > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > >> > >> Hi Junfeng, message moved down. > >> > >>> > >>>> -----Original Message----- > >>>> From: Rushil Gupta <rushilg@google.com> > >>>> Sent: Tuesday, April 11, 2023 12:59 > >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com > >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com>; > dev@dpdk.org; > >>>> Rushil Gupta <rushilg@google.com>; Guo, Junfeng > >>>> <junfeng.guo@intel.com> > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > >>>> > >>>> Update gve base code to support DQO. > >>>> > >>>> This patch is based on this: > >>>> > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > >>>> > >>>> Signed-off-by: Rushil Gupta <rushilg@google.com> > >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> > >>> Hi Ferruh & Bruce, > >>> > >>> This patch contains few lines change for the MIT licensed gve base > code. > >>> Note that there is no new files added, just some minor code update. > >>> > >>> Do we need to ask for special approval from the Tech Board for this? > >>> Please help give some advice and also help review this patch. Thanks! > >>> > >> > >> Once the MIT license exception is in place, as far as I know no more > >> approval is required per change. > > > > Got it, thanks the comment! > > > > Then we may also need your help to review, as well as the coming patch > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > >> > >>> BTW, Google will also help replace all the base code under MIT > license > >>> with the ones under BSD-3 license soon, which would make things > more > >>> easier. > >>> > >> > >> Is this different from base code under DPDK is changing license [1] ? > >> > >> > >> [1] > >> > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar > >> chive=both > >> > > > > The patch set of the above link only contains the processing of replace > the > > MIT licensed base code with the BSD-3 licensed base code. After some > > discussion, we think Google is in the right place to do that work. And > they > > are working on that now. > > > > Is the Google GVE driver [2] in the process of changing license from MIT > to BSD-3? > > > [2] > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- > linux/tree/v1.3.0/google/gve > I'm not sure, I don't know much about Google's plans. Maybe they could provide some info here. Thanks! @Rushil Gupta > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. It > contains > > only the code part, following previous license statements, without any > > license change. > > > > This patch is separated and sent by Google, to ensure there is no license > > violation. > > > > BTW, about the feature of GVE PMD enhancement, the rest code are all > > about BSD-3 licensed files, and that patch set will be sent out soon. > > > > Thanks! ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 9:41 ` Guo, Junfeng @ 2023-04-12 15:42 ` Rushil Gupta 2023-04-12 16:02 ` Ferruh Yigit 0 siblings, 1 reply; 13+ messages in thread From: Rushil Gupta @ 2023-04-12 15:42 UTC (permalink / raw) To: Guo, Junfeng; +Cc: Ferruh Yigit, Richardson, Bruce, dev, Zhang, Qi Z [-- Attachment #1: Type: text/plain, Size: 4600 bytes --] On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <junfeng.guo@intel.com> wrote: > > > > -----Original Message----- > > From: Ferruh Yigit <ferruh.yigit@amd.com> > > Sent: Wednesday, April 12, 2023 17:35 > > To: Guo, Junfeng <junfeng.guo@intel.com>; Richardson, Bruce > > <bruce.richardson@intel.com> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Rushil Gupta > > <rushilg@google.com> > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > > > > >> -----Original Message----- > > >> From: Ferruh Yigit <ferruh.yigit@amd.com> > > >> Sent: Wednesday, April 12, 2023 16:50 > > >> To: Guo, Junfeng <junfeng.guo@intel.com>; Richardson, Bruce > > >> <bruce.richardson@intel.com> > > >> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Rushil Gupta > > >> <rushilg@google.com> > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > >> > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > >> > > >> Hi Junfeng, message moved down. > > >> > > >>> > > >>>> -----Original Message----- > > >>>> From: Rushil Gupta <rushilg@google.com> > > >>>> Sent: Tuesday, April 11, 2023 12:59 > > >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com > > >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com>; > > dev@dpdk.org; > > >>>> Rushil Gupta <rushilg@google.com>; Guo, Junfeng > > >>>> <junfeng.guo@intel.com> > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > > >>>> > > >>>> Update gve base code to support DQO. > > >>>> > > >>>> This patch is based on this: > > >>>> > > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > > >>>> > > >>>> Signed-off-by: Rushil Gupta <rushilg@google.com> > > >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> > > >>> Hi Ferruh & Bruce, > > >>> > > >>> This patch contains few lines change for the MIT licensed gve base > > code. > > >>> Note that there is no new files added, just some minor code update. > > >>> > > >>> Do we need to ask for special approval from the Tech Board for this? > > >>> Please help give some advice and also help review this patch. Thanks! > > >>> > > >> > > >> Once the MIT license exception is in place, as far as I know no more > > >> approval is required per change. > > > > > > Got it, thanks the comment! > > > > > > Then we may also need your help to review, as well as the coming patch > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > > > >> > > >>> BTW, Google will also help replace all the base code under MIT > > license > > >>> with the ones under BSD-3 license soon, which would make things > > more > > >>> easier. > > >>> > > >> > > >> Is this different from base code under DPDK is changing license [1] ? > > >> > > >> > > >> [1] > > >> > > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar > > >> chive=both > > >> > > > > > > The patch set of the above link only contains the processing of replace > > the > > > MIT licensed base code with the BSD-3 licensed base code. After some > > > discussion, we think Google is in the right place to do that work. And > > they > > > are working on that now. > > > > > > > Is the Google GVE driver [2] in the process of changing license from MIT > > to BSD-3? > > > > > > [2] > > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- > > linux/tree/v1.3.0/google/gve > > > > I'm not sure, I don't know much about Google's plans. > Maybe they could provide some info here. Thanks! > > @Rushil Gupta > > > > > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. It > > contains > > > only the code part, following previous license statements, without any > > > license change. > > > > > > This patch is separated and sent by Google, to ensure there is no > license > > > violation. > > > > > > BTW, about the feature of GVE PMD enhancement, the rest code are all > > > about BSD-3 licensed files, and that patch set will be sent out soon. > > > > > > Thanks! > > I have got the green light internally to switch to BSD-3 license for code under base directory. If it is ok with the tech board, I can send a patch right away with all of the base files changed to BSD-3 which can be merged after this patch. Please let me know what you think. We are also about to upstream driver code: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo. [-- Attachment #2: Type: text/html, Size: 7814 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 15:42 ` Rushil Gupta @ 2023-04-12 16:02 ` Ferruh Yigit 2023-04-12 18:04 ` Rushil Gupta 0 siblings, 1 reply; 13+ messages in thread From: Ferruh Yigit @ 2023-04-12 16:02 UTC (permalink / raw) To: Rushil Gupta, Guo, Junfeng; +Cc: Richardson, Bruce, dev, Zhang, Qi Z, techboard On 4/12/2023 4:42 PM, Rushil Gupta wrote: > > > On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <junfeng.guo@intel.com > <mailto:junfeng.guo@intel.com>> wrote: > > > > > -----Original Message----- > > From: Ferruh Yigit <ferruh.yigit@amd.com > <mailto:ferruh.yigit@amd.com>> > > Sent: Wednesday, April 12, 2023 17:35 > > To: Guo, Junfeng <junfeng.guo@intel.com > <mailto:junfeng.guo@intel.com>>; Richardson, Bruce > > <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com>> > > Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z > <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta > > <rushilg@google.com <mailto:rushilg@google.com>> > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > > > > >> -----Original Message----- > > >> From: Ferruh Yigit <ferruh.yigit@amd.com > <mailto:ferruh.yigit@amd.com>> > > >> Sent: Wednesday, April 12, 2023 16:50 > > >> To: Guo, Junfeng <junfeng.guo@intel.com > <mailto:junfeng.guo@intel.com>>; Richardson, Bruce > > >> <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com>> > > >> Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z > <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta > > >> <rushilg@google.com <mailto:rushilg@google.com>> > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > >> > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > >> > > >> Hi Junfeng, message moved down. > > >> > > >>> > > >>>> -----Original Message----- > > >>>> From: Rushil Gupta <rushilg@google.com > <mailto:rushilg@google.com>> > > >>>> Sent: Tuesday, April 11, 2023 12:59 > > >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com > <mailto:qi.z.zhang@intel.com>>; ferruh.yigit@amd.com > <mailto:ferruh.yigit@amd.com> > > >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com > <mailto:bruce.richardson@intel.com>>; > > dev@dpdk.org <mailto:dev@dpdk.org>; > > >>>> Rushil Gupta <rushilg@google.com > <mailto:rushilg@google.com>>; Guo, Junfeng > > >>>> <junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>> > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > > >>>> > > >>>> Update gve base code to support DQO. > > >>>> > > >>>> This patch is based on this: > > >>>> > > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > <https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*> > > >>>> > > >>>> Signed-off-by: Rushil Gupta <rushilg@google.com > <mailto:rushilg@google.com>> > > >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com > <mailto:junfeng.guo@intel.com>> > > >>> Hi Ferruh & Bruce, > > >>> > > >>> This patch contains few lines change for the MIT licensed gve base > > code. > > >>> Note that there is no new files added, just some minor code > update. > > >>> > > >>> Do we need to ask for special approval from the Tech Board for > this? > > >>> Please help give some advice and also help review this patch. > Thanks! > > >>> > > >> > > >> Once the MIT license exception is in place, as far as I know no > more > > >> approval is required per change. > > > > > > Got it, thanks the comment! > > > > > > Then we may also need your help to review, as well as the coming > patch > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > > > >> > > >>> BTW, Google will also help replace all the base code under MIT > > license > > >>> with the ones under BSD-3 license soon, which would make things > > more > > >>> easier. > > >>> > > >> > > >> Is this different from base code under DPDK is changing license > [1] ? > > >> > > >> > > >> [1] > > >> > > > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar <https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar> > > >> chive=both > > >> > > > > > > The patch set of the above link only contains the processing of > replace > > the > > > MIT licensed base code with the BSD-3 licensed base code. After some > > > discussion, we think Google is in the right place to do that > work. And > > they > > > are working on that now. > > > > > > > Is the Google GVE driver [2] in the process of changing license > from MIT > > to BSD-3? > > > > > > [2] > > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- > <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-> > > linux/tree/v1.3.0/google/gve > > > > I'm not sure, I don't know much about Google's plans. > Maybe they could provide some info here. Thanks! > > @Rushil Gupta > > > > > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. It > > contains > > > only the code part, following previous license statements, > without any > > > license change. > > > > > > This patch is separated and sent by Google, to ensure there is > no license > > > violation. > > > > > > BTW, about the feature of GVE PMD enhancement, the rest code are all > > > about BSD-3 licensed files, and that patch set will be sent out > soon. > > > > > > Thanks! > > I have got the green light internally to switch to BSD-3 license for > code under base directory. If it is ok with the tech board, I can send a > patch right away with all of the base files changed to BSD-3 which can > be merged after this patch. Please let me know what you think. > We are also about to upstream driver > code: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd> to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo. +techboard There is already a patch [1] to change dpdk gve driver license from MIT to BSD-3, what will be different in the patch you are planning to send? Or overall I am trying to understand what is this new development on top of existing patch. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 16:02 ` Ferruh Yigit @ 2023-04-12 18:04 ` Rushil Gupta 2023-04-14 5:17 ` Rushil Gupta 0 siblings, 1 reply; 13+ messages in thread From: Rushil Gupta @ 2023-04-12 18:04 UTC (permalink / raw) To: Ferruh Yigit; +Cc: Guo, Junfeng, Richardson, Bruce, dev, Zhang, Qi Z, techboard [-- Attachment #1: Type: text/plain, Size: 7114 bytes --] Sorry for the confusion. I was talking about the same patch (titled net/gve: update copyright holders); however, I am not able to find it on patchwork. On Wed, Apr 12, 2023 at 9:03 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > On 4/12/2023 4:42 PM, Rushil Gupta wrote: > > > > > > On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <junfeng.guo@intel.com > > <mailto:junfeng.guo@intel.com>> wrote: > > > > > > > > > -----Original Message----- > > > From: Ferruh Yigit <ferruh.yigit@amd.com > > <mailto:ferruh.yigit@amd.com>> > > > Sent: Wednesday, April 12, 2023 17:35 > > > To: Guo, Junfeng <junfeng.guo@intel.com > > <mailto:junfeng.guo@intel.com>>; Richardson, Bruce > > > <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com>> > > > Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z > > <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta > > > <rushilg@google.com <mailto:rushilg@google.com>> > > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > > > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > > > > > > > >> -----Original Message----- > > > >> From: Ferruh Yigit <ferruh.yigit@amd.com > > <mailto:ferruh.yigit@amd.com>> > > > >> Sent: Wednesday, April 12, 2023 16:50 > > > >> To: Guo, Junfeng <junfeng.guo@intel.com > > <mailto:junfeng.guo@intel.com>>; Richardson, Bruce > > > >> <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com > >> > > > >> Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z > > <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta > > > >> <rushilg@google.com <mailto:rushilg@google.com>> > > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > >> > > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > > >> > > > >> Hi Junfeng, message moved down. > > > >> > > > >>> > > > >>>> -----Original Message----- > > > >>>> From: Rushil Gupta <rushilg@google.com > > <mailto:rushilg@google.com>> > > > >>>> Sent: Tuesday, April 11, 2023 12:59 > > > >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com > > <mailto:qi.z.zhang@intel.com>>; ferruh.yigit@amd.com > > <mailto:ferruh.yigit@amd.com> > > > >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com > > <mailto:bruce.richardson@intel.com>>; > > > dev@dpdk.org <mailto:dev@dpdk.org>; > > > >>>> Rushil Gupta <rushilg@google.com > > <mailto:rushilg@google.com>>; Guo, Junfeng > > > >>>> <junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>> > > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > > > >>>> > > > >>>> Update gve base code to support DQO. > > > >>>> > > > >>>> This patch is based on this: > > > >>>> > > > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > > <https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*> > > > >>>> > > > >>>> Signed-off-by: Rushil Gupta <rushilg@google.com > > <mailto:rushilg@google.com>> > > > >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com > > <mailto:junfeng.guo@intel.com>> > > > >>> Hi Ferruh & Bruce, > > > >>> > > > >>> This patch contains few lines change for the MIT licensed gve > base > > > code. > > > >>> Note that there is no new files added, just some minor code > > update. > > > >>> > > > >>> Do we need to ask for special approval from the Tech Board for > > this? > > > >>> Please help give some advice and also help review this patch. > > Thanks! > > > >>> > > > >> > > > >> Once the MIT license exception is in place, as far as I know no > > more > > > >> approval is required per change. > > > > > > > > Got it, thanks the comment! > > > > > > > > Then we may also need your help to review, as well as the coming > > patch > > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > > > > > >> > > > >>> BTW, Google will also help replace all the base code under MIT > > > license > > > >>> with the ones under BSD-3 license soon, which would make things > > > more > > > >>> easier. > > > >>> > > > >> > > > >> Is this different from base code under DPDK is changing license > > [1] ? > > > >> > > > >> > > > >> [1] > > > >> > > > > > > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar < > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar> > > > >> chive=both > > > >> > > > > > > > > The patch set of the above link only contains the processing of > > replace > > > the > > > > MIT licensed base code with the BSD-3 licensed base code. After > some > > > > discussion, we think Google is in the right place to do that > > work. And > > > they > > > > are working on that now. > > > > > > > > > > Is the Google GVE driver [2] in the process of changing license > > from MIT > > > to BSD-3? > > > > > > > > > [2] > > > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- > > <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-> > > > linux/tree/v1.3.0/google/gve > > > > > > > I'm not sure, I don't know much about Google's plans. > > Maybe they could provide some info here. Thanks! > > > > @Rushil Gupta > > > > > > > > > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. > It > > > contains > > > > only the code part, following previous license statements, > > without any > > > > license change. > > > > > > > > This patch is separated and sent by Google, to ensure there is > > no license > > > > violation. > > > > > > > > BTW, about the feature of GVE PMD enhancement, the rest code are > all > > > > about BSD-3 licensed files, and that patch set will be sent out > > soon. > > > > > > > > Thanks! > > > > I have got the green light internally to switch to BSD-3 license for > > code under base directory. If it is ok with the tech board, I can send a > > patch right away with all of the base files changed to BSD-3 which can > > be merged after this patch. Please let me know what you think. > > We are also about to upstream driver > > code: > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd < > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd> > to FreeBSD as well so you will see similar code under BSD license soon in > freebsd repo. > > > +techboard > > There is already a patch [1] to change dpdk gve driver license from MIT > to BSD-3, what will be different in the patch you are planning to send? > > Or overall I am trying to understand what is this new development on top > of existing patch. > > > > > > [-- Attachment #2: Type: text/html, Size: 13281 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-12 18:04 ` Rushil Gupta @ 2023-04-14 5:17 ` Rushil Gupta 2023-04-14 11:00 ` Ferruh Yigit 0 siblings, 1 reply; 13+ messages in thread From: Rushil Gupta @ 2023-04-14 5:17 UTC (permalink / raw) To: Ferruh Yigit; +Cc: Guo, Junfeng, Richardson, Bruce, dev, Zhang, Qi Z, techboard [-- Attachment #1: Type: text/plain, Size: 7582 bytes --] I want to highlight that we wish to keep license changes separate from this patch (probably for 23.11). This patch is to simply support basic structures for the DQO data path. On Wed, Apr 12, 2023 at 11:04 AM Rushil Gupta <rushilg@google.com> wrote: > Sorry for the confusion. I was talking about the same patch (titled > net/gve: update copyright holders); however, I am not able to find it on > patchwork. > > > On Wed, Apr 12, 2023 at 9:03 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >> On 4/12/2023 4:42 PM, Rushil Gupta wrote: >> > >> > >> > On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <junfeng.guo@intel.com >> > <mailto:junfeng.guo@intel.com>> wrote: >> > >> > >> > >> > > -----Original Message----- >> > > From: Ferruh Yigit <ferruh.yigit@amd.com >> > <mailto:ferruh.yigit@amd.com>> >> > > Sent: Wednesday, April 12, 2023 17:35 >> > > To: Guo, Junfeng <junfeng.guo@intel.com >> > <mailto:junfeng.guo@intel.com>>; Richardson, Bruce >> > > <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com>> >> > > Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z >> > <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta >> > > <rushilg@google.com <mailto:rushilg@google.com>> >> > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO >> > > >> > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: >> > > > >> > > > >> > > >> -----Original Message----- >> > > >> From: Ferruh Yigit <ferruh.yigit@amd.com >> > <mailto:ferruh.yigit@amd.com>> >> > > >> Sent: Wednesday, April 12, 2023 16:50 >> > > >> To: Guo, Junfeng <junfeng.guo@intel.com >> > <mailto:junfeng.guo@intel.com>>; Richardson, Bruce >> > > >> <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com >> >> >> > > >> Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z >> > <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta >> > > >> <rushilg@google.com <mailto:rushilg@google.com>> >> > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO >> > > >> >> > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: >> > > >> >> > > >> Hi Junfeng, message moved down. >> > > >> >> > > >>> >> > > >>>> -----Original Message----- >> > > >>>> From: Rushil Gupta <rushilg@google.com >> > <mailto:rushilg@google.com>> >> > > >>>> Sent: Tuesday, April 11, 2023 12:59 >> > > >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com >> > <mailto:qi.z.zhang@intel.com>>; ferruh.yigit@amd.com >> > <mailto:ferruh.yigit@amd.com> >> > > >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com >> > <mailto:bruce.richardson@intel.com>>; >> > > dev@dpdk.org <mailto:dev@dpdk.org>; >> > > >>>> Rushil Gupta <rushilg@google.com >> > <mailto:rushilg@google.com>>; Guo, Junfeng >> > > >>>> <junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>> >> > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO >> > > >>>> >> > > >>>> Update gve base code to support DQO. >> > > >>>> >> > > >>>> This patch is based on this: >> > > >>>> >> > > >> https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* >> > <https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* >> > >> > > >>>> >> > > >>>> Signed-off-by: Rushil Gupta <rushilg@google.com >> > <mailto:rushilg@google.com>> >> > > >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com >> > <mailto:junfeng.guo@intel.com>> >> > > >>> Hi Ferruh & Bruce, >> > > >>> >> > > >>> This patch contains few lines change for the MIT licensed gve >> base >> > > code. >> > > >>> Note that there is no new files added, just some minor code >> > update. >> > > >>> >> > > >>> Do we need to ask for special approval from the Tech Board for >> > this? >> > > >>> Please help give some advice and also help review this patch. >> > Thanks! >> > > >>> >> > > >> >> > > >> Once the MIT license exception is in place, as far as I know no >> > more >> > > >> approval is required per change. >> > > > >> > > > Got it, thanks the comment! >> > > > >> > > > Then we may also need your help to review, as well as the coming >> > patch >> > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! >> > > > >> > > >> >> > > >>> BTW, Google will also help replace all the base code under MIT >> > > license >> > > >>> with the ones under BSD-3 license soon, which would make >> things >> > > more >> > > >>> easier. >> > > >>> >> > > >> >> > > >> Is this different from base code under DPDK is changing license >> > [1] ? >> > > >> >> > > >> >> > > >> [1] >> > > >> >> > > >> > >> https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar < >> https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar> >> > > >> chive=both >> > > >> >> > > > >> > > > The patch set of the above link only contains the processing of >> > replace >> > > the >> > > > MIT licensed base code with the BSD-3 licensed base code. After >> some >> > > > discussion, we think Google is in the right place to do that >> > work. And >> > > they >> > > > are working on that now. >> > > > >> > > >> > > Is the Google GVE driver [2] in the process of changing license >> > from MIT >> > > to BSD-3? >> > > >> > > >> > > [2] >> > > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- >> > <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-> >> > > linux/tree/v1.3.0/google/gve >> > > >> > >> > I'm not sure, I don't know much about Google's plans. >> > Maybe they could provide some info here. Thanks! >> > >> > @Rushil Gupta >> > >> > > >> > > >> > > > This patch is mainly for the feature upstreaming of DPDK 23.07. >> It >> > > contains >> > > > only the code part, following previous license statements, >> > without any >> > > > license change. >> > > > >> > > > This patch is separated and sent by Google, to ensure there is >> > no license >> > > > violation. >> > > > >> > > > BTW, about the feature of GVE PMD enhancement, the rest code >> are all >> > > > about BSD-3 licensed files, and that patch set will be sent out >> > soon. >> > > > >> > > > Thanks! >> > >> > I have got the green light internally to switch to BSD-3 license for >> > code under base directory. If it is ok with the tech board, I can send a >> > patch right away with all of the base files changed to BSD-3 which can >> > be merged after this patch. Please let me know what you think. >> > We are also about to upstream driver >> > code: >> https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd < >> https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd> >> to FreeBSD as well so you will see similar code under BSD license soon in >> freebsd repo. >> >> >> +techboard >> >> There is already a patch [1] to change dpdk gve driver license from MIT >> to BSD-3, what will be different in the patch you are planning to send? >> >> Or overall I am trying to understand what is this new development on top >> of existing patch. >> >> >> >> >> >> [-- Attachment #2: Type: text/html, Size: 13813 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-14 5:17 ` Rushil Gupta @ 2023-04-14 11:00 ` Ferruh Yigit 0 siblings, 0 replies; 13+ messages in thread From: Ferruh Yigit @ 2023-04-14 11:00 UTC (permalink / raw) To: Rushil Gupta; +Cc: Guo, Junfeng, Richardson, Bruce, dev, Zhang, Qi Z, techboard On 4/14/2023 6:17 AM, Rushil Gupta wrote: > I want to highlight that we wish to keep license changes separate from > this patch (probably for 23.11). This patch is to simply support basic > structures for the DQO data path. > +1 to separate it license patch. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] net/gve: update base code for DQO 2023-04-11 4:59 ` [PATCH 1/1] net/gve: update base code for DQO Rushil Gupta 2023-04-11 6:51 ` Guo, Junfeng @ 2023-05-04 8:30 ` Ferruh Yigit 1 sibling, 0 replies; 13+ messages in thread From: Ferruh Yigit @ 2023-05-04 8:30 UTC (permalink / raw) To: Rushil Gupta, qi.z.zhang; +Cc: bruce.richardson, dev, Junfeng Guo On 4/11/2023 5:59 AM, Rushil Gupta wrote: > Update gve base code to support DQO. > > This patch is based on this: > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > > Signed-off-by: Rushil Gupta <rushilg@google.com> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> Applied to dpdk-next-net/main, thanks. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-05-04 8:30 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-04-11 4:59 [PATCH 0/1] *** Update drivers/net/gve/base code for DQO *** Rushil Gupta 2023-04-11 4:59 ` [PATCH 1/1] net/gve: update base code for DQO Rushil Gupta 2023-04-11 6:51 ` Guo, Junfeng 2023-04-12 8:50 ` Ferruh Yigit 2023-04-12 9:09 ` Guo, Junfeng 2023-04-12 9:34 ` Ferruh Yigit 2023-04-12 9:41 ` Guo, Junfeng 2023-04-12 15:42 ` Rushil Gupta 2023-04-12 16:02 ` Ferruh Yigit 2023-04-12 18:04 ` Rushil Gupta 2023-04-14 5:17 ` Rushil Gupta 2023-04-14 11:00 ` Ferruh Yigit 2023-05-04 8:30 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).