* [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
@ 2019-09-12 10:38 Eelco Chaudron
2019-09-12 12:02 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Eelco Chaudron @ 2019-09-12 10:38 UTC (permalink / raw)
To: beilei.xing, qi.z.zhang; +Cc: dev
When receiving the unsupported AQ messages, it's taken as an
error. It's not appropriate and triggers too much unnecessary print.
This commit is similar to commit e130425300b0 ("net/i40e: downgrade
unnecessary error log") which made the same change for the PF instance.
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index c77b30c54..7b1d485c6 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
}
break;
default:
- PMD_DRV_LOG(ERR, "Request %u is not supported yet",
+ PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
aq_opc);
break;
}
--
2.18.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
2019-09-12 10:38 [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log Eelco Chaudron
@ 2019-09-12 12:02 ` David Marchand
2019-09-12 12:40 ` Ye Xiaolong
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2019-09-12 12:02 UTC (permalink / raw)
To: Eelco Chaudron; +Cc: Beilei Xing, Qi Zhang, dev
On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> wrote:
>
> When receiving the unsupported AQ messages, it's taken as an
> error. It's not appropriate and triggers too much unnecessary print.
>
> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
> unnecessary error log") which made the same change for the PF instance.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index c77b30c54..7b1d485c6 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
> }
> break;
> default:
> - PMD_DRV_LOG(ERR, "Request %u is not supported yet",
> + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
> aq_opc);
> break;
> }
> --
> 2.18.1
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
2019-09-12 12:02 ` David Marchand
@ 2019-09-12 12:40 ` Ye Xiaolong
2019-09-12 12:56 ` Eelco Chaudron
2019-09-13 9:00 ` Eelco Chaudron
0 siblings, 2 replies; 6+ messages in thread
From: Ye Xiaolong @ 2019-09-12 12:40 UTC (permalink / raw)
To: David Marchand; +Cc: Eelco Chaudron, Beilei Xing, Qi Zhang, dev
On 09/12, David Marchand wrote:
>On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> wrote:
>>
>> When receiving the unsupported AQ messages, it's taken as an
>> error. It's not appropriate and triggers too much unnecessary print.
>>
>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>> unnecessary error log") which made the same change for the PF instance.
>>
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>> ---
>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
>> index c77b30c54..7b1d485c6 100644
>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>> }
>> break;
>> default:
>> - PMD_DRV_LOG(ERR, "Request %u is not supported yet",
>> + PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
>> aq_opc);
>> break;
>> }
>> --
>> 2.18.1
>>
>
>Reviewed-by: David Marchand <david.marchand@redhat.com>
>
>
>--
>David Marchand
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
2019-09-12 12:40 ` Ye Xiaolong
@ 2019-09-12 12:56 ` Eelco Chaudron
2019-09-13 9:00 ` Eelco Chaudron
1 sibling, 0 replies; 6+ messages in thread
From: Eelco Chaudron @ 2019-09-12 12:56 UTC (permalink / raw)
To: Ye Xiaolong; +Cc: David Marchand, Beilei Xing, Qi Zhang, dev
On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com>
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>> }
>>> break;
>>> default:
>>> - PMD_DRV_LOG(ERR, "Request %u is not
>>> supported yet",
>>> + PMD_DRV_LOG(DEBUG, "Request %u is not
>>> supported yet",
>>> aq_opc);
>>> break;
>>> }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.
Thanks David/Ye
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
2019-09-12 12:40 ` Ye Xiaolong
2019-09-12 12:56 ` Eelco Chaudron
@ 2019-09-13 9:00 ` Eelco Chaudron
2019-09-13 13:24 ` Kevin Traynor
1 sibling, 1 reply; 6+ messages in thread
From: Eelco Chaudron @ 2019-09-13 9:00 UTC (permalink / raw)
To: Ye Xiaolong, stable
Cc: David Marchand, Beilei Xing, Qi Zhang, dev, Kevin Traynor
Forgot to include the stable alias to get this in 18.11, sorry Kevin
//Eelco
On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com>
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>> }
>>> break;
>>> default:
>>> - PMD_DRV_LOG(ERR, "Request %u is not
>>> supported yet",
>>> + PMD_DRV_LOG(DEBUG, "Request %u is not
>>> supported yet",
>>> aq_opc);
>>> break;
>>> }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
2019-09-13 9:00 ` Eelco Chaudron
@ 2019-09-13 13:24 ` Kevin Traynor
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-09-13 13:24 UTC (permalink / raw)
To: Eelco Chaudron, Ye Xiaolong, stable
Cc: David Marchand, Beilei Xing, Qi Zhang, dev
On 13/09/2019 10:00, Eelco Chaudron wrote:
> Forgot to include the stable alias to get this in 18.11, sorry Kevin
>
No problem, I'll take a note to backport it and add
Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
> //Eelco
>
> On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
>
>> On 09/12, David Marchand wrote:
>>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com>
>>> wrote:
>>>>
>>>> When receiving the unsupported AQ messages, it's taken as an
>>>> error. It's not appropriate and triggers too much unnecessary print.
>>>>
>>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>>> unnecessary error log") which made the same change for the PF
>>>> instance.
>>>>
>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>>> ---
>>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> index c77b30c54..7b1d485c6 100644
>>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>>> }
>>>> break;
>>>> default:
>>>> - PMD_DRV_LOG(ERR, "Request %u is not
>>>> supported yet",
>>>> + PMD_DRV_LOG(DEBUG, "Request %u is not
>>>> supported yet",
>>>> aq_opc);
>>>> break;
>>>> }
>>>> --
>>>> 2.18.1
>>>>
>>>
>>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>>
>>>
>>> --
>>> David Marchand
>>
>> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>
>> Applied to dpdk-next-net-intel.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-13 13:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 10:38 [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log Eelco Chaudron
2019-09-12 12:02 ` David Marchand
2019-09-12 12:40 ` Ye Xiaolong
2019-09-12 12:56 ` Eelco Chaudron
2019-09-13 9:00 ` Eelco Chaudron
2019-09-13 13:24 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).