DPDK CI discussions
 help / color / mirror / Atom feed
* Adding Series Dependency to Patchwork
@ 2024-02-22 19:51 Adam Hassick
  2024-04-04 13:50 ` Patrick Robb
  0 siblings, 1 reply; 6+ messages in thread
From: Adam Hassick @ 2024-02-22 19:51 UTC (permalink / raw)
  To: ci

Hi All,

There has been a discussion on GitHub between myself and others about
adding support for series dependency to Patchwork. This would involve
adding the feature to the Patchwork dashboard and git-pw. However, it
seems like the maintainer would like us to do much of the required
implementation work. I estimate, with a low level of certainty, that
it would consume 35 to 50 hours of developer time.

The active issue relating to this feature can be found here, as well
as the archived one:
https://github.com/getpatchwork/patchwork/issues/583

Would it be worth it for us here at the Community Lab to contribute
upstream to Patchwork? Implementing the feature in the Patchwork
project will make our method for defining series dependencies the
standard, and it may lift some of the burden of maintaining this
feature off of us.

Regards,
Adam Hassick

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Adding Series Dependency to Patchwork
  2024-02-22 19:51 Adding Series Dependency to Patchwork Adam Hassick
@ 2024-04-04 13:50 ` Patrick Robb
  2024-04-05  6:41   ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Patrick Robb @ 2024-04-04 13:50 UTC (permalink / raw)
  To: ci, NBU-Contact-Thomas Monjalon (EXTERNAL)
  Cc: Adam Hassick, David Marchand, Aaron Conole

Hi Thomas,

Adam explains more completely in the preceding email, but he has
talked with the patchwork project maintainer, and determined the
needed next steps to do work adding depends-on support to patchwork
server. And he provides an estimate (35-50 hours of his time) for
adding this feature to pw.

What we want is a community opinion on using Community Lab resources
(our developer time) towards this effort on patchwork project. I'm
going to you, because you were the person who originally raised the
depends on issue and adding this support to pw server.

Given his time estimate, do you endorse this work, or do you prefer we
focus on our SOW items and other community requests which are in queue
right now? Thanks.

On Thu, Feb 22, 2024 at 2:51 PM Adam Hassick <ahassick@iol.unh.edu> wrote:
>
> Hi All,
>
> There has been a discussion on GitHub between myself and others about
> adding support for series dependency to Patchwork. This would involve
> adding the feature to the Patchwork dashboard and git-pw. However, it
> seems like the maintainer would like us to do much of the required
> implementation work. I estimate, with a low level of certainty, that
> it would consume 35 to 50 hours of developer time.
>
> The active issue relating to this feature can be found here, as well
> as the archived one:
> https://github.com/getpatchwork/patchwork/issues/583
>
> Would it be worth it for us here at the Community Lab to contribute
> upstream to Patchwork? Implementing the feature in the Patchwork
> project will make our method for defining series dependencies the
> standard, and it may lift some of the burden of maintaining this
> feature off of us.
>
> Regards,
> Adam Hassick

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Adding Series Dependency to Patchwork
  2024-04-04 13:50 ` Patrick Robb
@ 2024-04-05  6:41   ` Thomas Monjalon
  2024-04-11 14:18     ` Aaron Conole
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2024-04-05  6:41 UTC (permalink / raw)
  To: Patrick Robb, Adam Hassick; +Cc: ci, David Marchand, Aaron Conole

Hello,

Yes I still think it is a valuable work to achieve.
If Aaron agrees, I wish you can complete this feature upstream.

Thank you


04/04/2024 15:50, Patrick Robb:
> Hi Thomas,
> 
> Adam explains more completely in the preceding email, but he has
> talked with the patchwork project maintainer, and determined the
> needed next steps to do work adding depends-on support to patchwork
> server. And he provides an estimate (35-50 hours of his time) for
> adding this feature to pw.
> 
> What we want is a community opinion on using Community Lab resources
> (our developer time) towards this effort on patchwork project. I'm
> going to you, because you were the person who originally raised the
> depends on issue and adding this support to pw server.
> 
> Given his time estimate, do you endorse this work, or do you prefer we
> focus on our SOW items and other community requests which are in queue
> right now? Thanks.
> 
> On Thu, Feb 22, 2024 at 2:51 PM Adam Hassick <ahassick@iol.unh.edu> wrote:
> >
> > Hi All,
> >
> > There has been a discussion on GitHub between myself and others about
> > adding support for series dependency to Patchwork. This would involve
> > adding the feature to the Patchwork dashboard and git-pw. However, it
> > seems like the maintainer would like us to do much of the required
> > implementation work. I estimate, with a low level of certainty, that
> > it would consume 35 to 50 hours of developer time.
> >
> > The active issue relating to this feature can be found here, as well
> > as the archived one:
> > https://github.com/getpatchwork/patchwork/issues/583
> >
> > Would it be worth it for us here at the Community Lab to contribute
> > upstream to Patchwork? Implementing the feature in the Patchwork
> > project will make our method for defining series dependencies the
> > standard, and it may lift some of the burden of maintaining this
> > feature off of us.
> >
> > Regards,
> > Adam Hassick
> 






^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Adding Series Dependency to Patchwork
  2024-04-05  6:41   ` Thomas Monjalon
@ 2024-04-11 14:18     ` Aaron Conole
  2024-04-11 14:33       ` Patrick Robb
  0 siblings, 1 reply; 6+ messages in thread
From: Aaron Conole @ 2024-04-11 14:18 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Patrick Robb, Adam Hassick, ci, David Marchand

Thomas Monjalon <thomas@monjalon.net> writes:

> Hello,
>
> Yes I still think it is a valuable work to achieve.
> If Aaron agrees, I wish you can complete this feature upstream.

okay by me

> Thank you
>
>
> 04/04/2024 15:50, Patrick Robb:
>> Hi Thomas,
>> 
>> Adam explains more completely in the preceding email, but he has
>> talked with the patchwork project maintainer, and determined the
>> needed next steps to do work adding depends-on support to patchwork
>> server. And he provides an estimate (35-50 hours of his time) for
>> adding this feature to pw.
>> 
>> What we want is a community opinion on using Community Lab resources
>> (our developer time) towards this effort on patchwork project. I'm
>> going to you, because you were the person who originally raised the
>> depends on issue and adding this support to pw server.
>> 
>> Given his time estimate, do you endorse this work, or do you prefer we
>> focus on our SOW items and other community requests which are in queue
>> right now? Thanks.
>> 
>> On Thu, Feb 22, 2024 at 2:51 PM Adam Hassick <ahassick@iol.unh.edu> wrote:
>> >
>> > Hi All,
>> >
>> > There has been a discussion on GitHub between myself and others about
>> > adding support for series dependency to Patchwork. This would involve
>> > adding the feature to the Patchwork dashboard and git-pw. However, it
>> > seems like the maintainer would like us to do much of the required
>> > implementation work. I estimate, with a low level of certainty, that
>> > it would consume 35 to 50 hours of developer time.
>> >
>> > The active issue relating to this feature can be found here, as well
>> > as the archived one:
>> > https://github.com/getpatchwork/patchwork/issues/583
>> >
>> > Would it be worth it for us here at the Community Lab to contribute
>> > upstream to Patchwork? Implementing the feature in the Patchwork
>> > project will make our method for defining series dependencies the
>> > standard, and it may lift some of the burden of maintaining this
>> > feature off of us.
>> >
>> > Regards,
>> > Adam Hassick
>> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Adding Series Dependency to Patchwork
  2024-04-11 14:18     ` Aaron Conole
@ 2024-04-11 14:33       ` Patrick Robb
  2024-07-12 20:15         ` Adam Hassick
  0 siblings, 1 reply; 6+ messages in thread
From: Patrick Robb @ 2024-04-11 14:33 UTC (permalink / raw)
  To: Aaron Conole; +Cc: Thomas Monjalon, Adam Hassick, ci, David Marchand

Perfect. Then we will proceed.

On Thu, Apr 11, 2024 at 10:18 AM Aaron Conole <aconole@redhat.com> wrote:
>
> Thomas Monjalon <thomas@monjalon.net> writes:
>
> > Hello,
> >
> > Yes I still think it is a valuable work to achieve.
> > If Aaron agrees, I wish you can complete this feature upstream.
>
> okay by me
>
> > Thank you
> >
> >
> > 04/04/2024 15:50, Patrick Robb:
> >> Hi Thomas,
> >>
> >> Adam explains more completely in the preceding email, but he has
> >> talked with the patchwork project maintainer, and determined the
> >> needed next steps to do work adding depends-on support to patchwork
> >> server. And he provides an estimate (35-50 hours of his time) for
> >> adding this feature to pw.
> >>
> >> What we want is a community opinion on using Community Lab resources
> >> (our developer time) towards this effort on patchwork project. I'm
> >> going to you, because you were the person who originally raised the
> >> depends on issue and adding this support to pw server.
> >>
> >> Given his time estimate, do you endorse this work, or do you prefer we
> >> focus on our SOW items and other community requests which are in queue
> >> right now? Thanks.
> >>
> >> On Thu, Feb 22, 2024 at 2:51 PM Adam Hassick <ahassick@iol.unh.edu> wrote:
> >> >
> >> > Hi All,
> >> >
> >> > There has been a discussion on GitHub between myself and others about
> >> > adding support for series dependency to Patchwork. This would involve
> >> > adding the feature to the Patchwork dashboard and git-pw. However, it
> >> > seems like the maintainer would like us to do much of the required
> >> > implementation work. I estimate, with a low level of certainty, that
> >> > it would consume 35 to 50 hours of developer time.
> >> >
> >> > The active issue relating to this feature can be found here, as well
> >> > as the archived one:
> >> > https://github.com/getpatchwork/patchwork/issues/583
> >> >
> >> > Would it be worth it for us here at the Community Lab to contribute
> >> > upstream to Patchwork? Implementing the feature in the Patchwork
> >> > project will make our method for defining series dependencies the
> >> > standard, and it may lift some of the burden of maintaining this
> >> > feature off of us.
> >> >
> >> > Regards,
> >> > Adam Hassick
> >>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Adding Series Dependency to Patchwork
  2024-04-11 14:33       ` Patrick Robb
@ 2024-07-12 20:15         ` Adam Hassick
  0 siblings, 0 replies; 6+ messages in thread
From: Adam Hassick @ 2024-07-12 20:15 UTC (permalink / raw)
  To: Patrick Robb; +Cc: Aaron Conole, Thomas Monjalon, ci, David Marchand

Hi All,

We've gotten a review of our initial submission to add the dependency
parsing to the Patchwork dashboard. Stephen recommends that we change
our format to use the message ID of patches or cover letters rather
than the ID of the patch or series in the database. So, instead of
adding a dependency by adding "Depends-on: series-5678" one would add
"Depends-on: <20240712120000-1-user@example.com>". We can keep the
option of using the patchwork web URLs that was discussed in the
original issue on GitHub.

The main reasoning for this is that our format doesn't make it clear
exactly what the dependency is or where it's found outside of the
context of Patchwork. This discussion can be viewed here:
http://patchwork.ozlabs.org/project/patchwork/patch/20240617221900.156155-3-ahassick@iol.unh.edu/

Does this change sound reasonable?

Regards,
Adam

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-07-12 20:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-22 19:51 Adding Series Dependency to Patchwork Adam Hassick
2024-04-04 13:50 ` Patrick Robb
2024-04-05  6:41   ` Thomas Monjalon
2024-04-11 14:18     ` Aaron Conole
2024-04-11 14:33       ` Patrick Robb
2024-07-12 20:15         ` Adam Hassick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).