DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] meson: error out on failed kernel module builds
@ 2020-05-11 10:25 Anatoly Burakov
  2020-05-11 10:27 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2020-05-11 10:25 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson

Now that kernel modules aren't built by default, we can be more
strict with their build process, and fail the build if they were
requested to be built, but weren't.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 kernel/linux/meson.build | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
index 1796cc6861..da79df1687 100644
--- a/kernel/linux/meson.build
+++ b/kernel/linux/meson.build
@@ -5,8 +5,7 @@ subdirs = ['igb_uio', 'kni']
 
 # if we are cross-compiling we need kernel_dir specified
 if get_option('kernel_dir') == '' and meson.is_cross_build()
-	warning('Need "kernel_dir" option for kmod compilation when cross-compiling')
-	subdir_done()
+	error('Need "kernel_dir" option for kmod compilation when cross-compiling')
 endif
 
 kernel_dir = get_option('kernel_dir')
@@ -20,8 +19,7 @@ endif
 make_returncode = run_command('make', '-sC', kernel_dir + '/build',
 		'kernelversion').returncode()
 if make_returncode != 0
-	warning('Cannot compile kernel modules as requested - are kernel headers installed?')
-	subdir_done()
+	error('Cannot compile kernel modules as requested - are kernel headers installed?')
 endif
 
 # DO ACTUAL MODULE BUILDING
-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds
  2020-05-11 10:25 [dpdk-dev] [PATCH] meson: error out on failed kernel module builds Anatoly Burakov
@ 2020-05-11 10:27 ` Bruce Richardson
  2020-05-19 16:01   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-05-11 10:27 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev

On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote:
> Now that kernel modules aren't built by default, we can be more
> strict with their build process, and fail the build if they were
> requested to be built, but weren't.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
I think erroring out is the right thing to do, now that modules need to be
explicitly enabled.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds
  2020-05-11 10:27 ` Bruce Richardson
@ 2020-05-19 16:01   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-05-19 16:01 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, Bruce Richardson

11/05/2020 12:27, Bruce Richardson:
> On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote:
> > Now that kernel modules aren't built by default, we can be more
> > strict with their build process, and fail the build if they were
> > requested to be built, but weren't.
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> I think erroring out is the right thing to do, now that modules need to be
> explicitly enabled.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-19 16:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 10:25 [dpdk-dev] [PATCH] meson: error out on failed kernel module builds Anatoly Burakov
2020-05-11 10:27 ` Bruce Richardson
2020-05-19 16:01   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).