DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header directly to us
@ 2020-11-09  6:24 Guo, Jia
  2020-11-09  9:49 ` [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d Zhang, Qi Z
  0 siblings, 1 reply; 4+ messages in thread
From: Guo, Jia @ 2020-11-09  6:24 UTC (permalink / raw)
  To: Prateek Agarwal; +Cc: dev

Hi, Agarwal

> -----Original Message-----
> From: Prateek Agarwal <pratekag@gmail.com>
> Sent: Saturday, November 7, 2020 5:01 PM
> To: Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Prateek Agarwal <pratekag@gmail.com>
> Subject: [PATCH] Made i40 header CPP compatible using extern "C". Library
> headers work directly in cpp code. Linking errors thrown due to the absence
> of this change in i40e pmd header does not help in resolving the problem. I
> needed this header directly to use...
> 

Obviously that is not you want to merge the title and the commit log. Please separate it and update one new version. 

> Signed-off-by: Prateek Agarwal <pratekag@gmail.com>
> ---
>  drivers/net/i40e/rte_pmd_i40e.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/i40e/rte_pmd_i40e.h
> b/drivers/net/i40e/rte_pmd_i40e.h index fc3560c28..4cb21c371 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -14,6 +14,10 @@
>   *
>   */
> 
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #include <rte_compat.h>
>  #include <rte_ethdev.h>
>  #include <rte_ether.h>
> @@ -1130,4 +1134,8 @@ __rte_experimental  int
> rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev
> *switch_dev);
> 
> +#ifdef __cplusplus
> +}
> +#endif
> +
>  #endif /* _PMD_I40E_H_ */
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d...
  2020-11-09  6:24 [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header directly to us Guo, Jia
@ 2020-11-09  9:49 ` Zhang, Qi Z
  2020-11-09 17:44   ` Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Qi Z @ 2020-11-09  9:49 UTC (permalink / raw)
  To: Guo, Jia, Prateek Agarwal; +Cc: dev



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guo, Jia
> Sent: Monday, November 9, 2020 2:24 PM
> To: Prateek Agarwal <pratekag@gmail.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern
> "C". Library headers work directly in cpp code. Linking errors thrown due to the
> absence of this change in i40e pmd header does not help in resolving the
> problem. I needed this header d...
> 
> Hi, Agarwal
> 
> > -----Original Message-----
> > From: Prateek Agarwal <pratekag@gmail.com>
> > Sent: Saturday, November 7, 2020 5:01 PM
> > To: Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Prateek Agarwal <pratekag@gmail.com>
> > Subject: [PATCH] Made i40 header CPP compatible using extern "C".
> > Library headers work directly in cpp code. Linking errors thrown due
> > to the absence of this change in i40e pmd header does not help in
> > resolving the problem. I needed this header directly to use...
> >
> 
> Obviously that is not you want to merge the title and the commit log. Please
> separate it and update one new version.


Fixed the format during merge as below

net/i40e: add extern "C" for cpp compile

Add extern "C" in rte_pmd_i40e.h when be compiled with cpp.

Applied to dpdk-next-net-intel.

Thanks
Qi


> 
> > Signed-off-by: Prateek Agarwal <pratekag@gmail.com>
> > ---
> >  drivers/net/i40e/rte_pmd_i40e.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/i40e/rte_pmd_i40e.h
> > b/drivers/net/i40e/rte_pmd_i40e.h index fc3560c28..4cb21c371 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e.h
> > +++ b/drivers/net/i40e/rte_pmd_i40e.h
> > @@ -14,6 +14,10 @@
> >   *
> >   */
> >
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> >  #include <rte_compat.h>
> >  #include <rte_ethdev.h>
> >  #include <rte_ether.h>
> > @@ -1130,4 +1134,8 @@ __rte_experimental  int
> > rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev
> > *switch_dev);
> >
> > +#ifdef __cplusplus
> > +}
> > +#endif
> > +
> >  #endif /* _PMD_I40E_H_ */
> > --
> > 2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d...
  2020-11-09  9:49 ` [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d Zhang, Qi Z
@ 2020-11-09 17:44   ` Ferruh Yigit
  2020-11-10 12:44     ` Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2020-11-09 17:44 UTC (permalink / raw)
  To: Zhang, Qi Z, Guo, Jia, Prateek Agarwal; +Cc: dev

On 11/9/2020 9:49 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Guo, Jia
>> Sent: Monday, November 9, 2020 2:24 PM
>> To: Prateek Agarwal <pratekag@gmail.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern
>> "C". Library headers work directly in cpp code. Linking errors thrown due to the
>> absence of this change in i40e pmd header does not help in resolving the
>> problem. I needed this header d...
>>
>> Hi, Agarwal
>>
>>> -----Original Message-----
>>> From: Prateek Agarwal <pratekag@gmail.com>
>>> Sent: Saturday, November 7, 2020 5:01 PM
>>> To: Guo, Jia <jia.guo@intel.com>
>>> Cc: dev@dpdk.org; Prateek Agarwal <pratekag@gmail.com>
>>> Subject: [PATCH] Made i40 header CPP compatible using extern "C".
>>> Library headers work directly in cpp code. Linking errors thrown due
>>> to the absence of this change in i40e pmd header does not help in
>>> resolving the problem. I needed this header directly to use...
>>>
>>
>> Obviously that is not you want to merge the title and the commit log. Please
>> separate it and update one new version.
> 
> 
> Fixed the format during merge as below
> 
> net/i40e: add extern "C" for cpp compile
> 
> Add extern "C" in rte_pmd_i40e.h when be compiled with cpp.
> 
> Applied to dpdk-next-net-intel.
> 

Hi Prateek,

In the git history, we have your name as:
"Prateek Agarwal <prateekag@cse.iitb.ac.in>"

We are trying to keep authors unique in the git history, as much as possible, 
will be OK to continue with the one in the git history?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d...
  2020-11-09 17:44   ` Ferruh Yigit
@ 2020-11-10 12:44     ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-11-10 12:44 UTC (permalink / raw)
  To: Zhang, Qi Z, Guo, Jia, Prateek Agarwal; +Cc: dev

On 11/9/2020 5:44 PM, Ferruh Yigit wrote:
> On 11/9/2020 9:49 AM, Zhang, Qi Z wrote:
>>
>>
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Guo, Jia
>>> Sent: Monday, November 9, 2020 2:24 PM
>>> To: Prateek Agarwal <pratekag@gmail.com>
>>> Cc: dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern
>>> "C". Library headers work directly in cpp code. Linking errors thrown due to the
>>> absence of this change in i40e pmd header does not help in resolving the
>>> problem. I needed this header d...
>>>
>>> Hi, Agarwal
>>>
>>>> -----Original Message-----
>>>> From: Prateek Agarwal <pratekag@gmail.com>
>>>> Sent: Saturday, November 7, 2020 5:01 PM
>>>> To: Guo, Jia <jia.guo@intel.com>
>>>> Cc: dev@dpdk.org; Prateek Agarwal <pratekag@gmail.com>
>>>> Subject: [PATCH] Made i40 header CPP compatible using extern "C".
>>>> Library headers work directly in cpp code. Linking errors thrown due
>>>> to the absence of this change in i40e pmd header does not help in
>>>> resolving the problem. I needed this header directly to use...
>>>>
>>>
>>> Obviously that is not you want to merge the title and the commit log. Please
>>> separate it and update one new version.
>>
>>
>> Fixed the format during merge as below
>>
>> net/i40e: add extern "C" for cpp compile
>>
>> Add extern "C" in rte_pmd_i40e.h when be compiled with cpp.
>>
>> Applied to dpdk-next-net-intel.
>>
> 
> Hi Prateek,
> 
> In the git history, we have your name as:
> "Prateek Agarwal <prateekag@cse.iitb.ac.in>"
> 
> We are trying to keep authors unique in the git history, as much as possible, 
> will be OK to continue with the one in the git history?

Using the one in the git history, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-10 12:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09  6:24 [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header directly to us Guo, Jia
2020-11-09  9:49 ` [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d Zhang, Qi Z
2020-11-09 17:44   ` Ferruh Yigit
2020-11-10 12:44     ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git