[dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

[dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

[changqingxwu]

Signed-off-by: changqingxwu <changqingx.wu@intel.com>
---
 tests/TestSuite_vxlan.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 8de8384..34297e0 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         if "inner_l4_invalid" in kwargs:
             self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
                         == self.l4err_num + 1, "Failed to count inner l4 chksum error")
-            self.l4err_num += 1
 
         # verify detected l3 invalid checksum
         if "ip_invalid" in kwargs:
-- 
2.17.2

Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

[Zhu, ShuaiX]

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, April 9, 2019 3:15 PM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..34297e0 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>          if "inner_l4_invalid" in kwargs:
>              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
>                          == self.l4err_num + 1, "Failed to count inner l4
> chksum error")
> -            self.l4err_num += 1
> 
>          # verify detected l3 invalid checksum
>          if "ip_invalid" in kwargs:
> --
> 2.17.2

Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

[Tu, Lijuan]

I am not quit catch your reason, I think when it catch "Bad-l4csum", and the number increases. So what is your consideration that remove the statement.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, April 9, 2019 12:15 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..34297e0 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>          if "inner_l4_invalid" in kwargs:
>              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
>                          == self.l4err_num + 1, "Failed to count inner l4 chksum error")
> -            self.l4err_num += 1
> 
>          # verify detected l3 invalid checksum
>          if "ip_invalid" in kwargs:
> --
> 2.17.2

Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

[Wu, ChangqingX]

Dpdk made some code changes in the commit:53324971a14e02f5f710d6e73fe475650e9a9802, which effects method that tests the number of "Bad-l4csum", continuously sends 2 or more packets between start and stop, the number of "Bad-l4csum" Will accumulate, if stop, the number of "Bad-l4csum" will be reset, you can check: dpdk-11148, Yigit, Ferruh comments 


Thanks
changqingx

-----Original Message-----
From: Tu, Lijuan 
Sent: Friday, April 12, 2019 1:26 AM
To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
Cc: Wu, ChangqingX <changqingx.wu@intel.com>
Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

I am not quit catch your reason, I think when it catch "Bad-l4csum", and the number increases. So what is your consideration that remove the statement.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, April 9, 2019 12:15 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..34297e0 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>          if "inner_l4_invalid" in kwargs:
>              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
>                          == self.l4err_num + 1, "Failed to count inner l4 chksum error")
> -            self.l4err_num += 1
> 
>          # verify detected l3 invalid checksum
>          if "ip_invalid" in kwargs:
> --
> 2.17.2

Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid

[Tu, Lijuan]

Could you please also send your reason while you commit a patch.

So you should also remove the definition of self.l4err_num if it's never used at all.

> -----Original Message-----
> From: Wu, ChangqingX
> Sent: Thursday, April 11, 2019 6:36 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> 
> Dpdk made some code changes in the
> commit:53324971a14e02f5f710d6e73fe475650e9a9802, which effects
> method that tests the number of "Bad-l4csum", continuously sends 2 or
> more packets between start and stop, the number of "Bad-l4csum" Will
> accumulate, if stop, the number of "Bad-l4csum" will be reset, you can check:
> dpdk-11148, Yigit, Ferruh comments
> 
> 
> Thanks
> changqingx
> 
> -----Original Message-----
> From: Tu, Lijuan
> Sent: Friday, April 12, 2019 1:26 AM
> To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> 
> I am not quit catch your reason, I think when it catch "Bad-l4csum", and the
> number increases. So what is your consideration that remove the statement.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> > Sent: Tuesday, April 9, 2019 12:15 AM
> > To: dts@dpdk.org
> > Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid
> >
> > Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> > ---
> >  tests/TestSuite_vxlan.py | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> > 8de8384..34297e0 100644
> > --- a/tests/TestSuite_vxlan.py
> > +++ b/tests/TestSuite_vxlan.py
> > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> >          if "inner_l4_invalid" in kwargs:
> >              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
> >                          == self.l4err_num + 1, "Failed to count inner l4 chksum
> error")
> > -            self.l4err_num += 1
> >
> >          # verify detected l3 invalid checksum
> >          if "ip_invalid" in kwargs:
> > --
> > 2.17.2