* [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid @ 2019-04-09 7:15 changqingxwu 2019-04-09 8:05 ` Zhu, ShuaiX 2019-04-11 17:26 ` Tu, Lijuan 0 siblings, 2 replies; 5+ messages in thread From: changqingxwu @ 2019-04-09 7:15 UTC (permalink / raw) To: dts; +Cc: changqingxwu Signed-off-by: changqingxwu <changqingx.wu@intel.com> --- tests/TestSuite_vxlan.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index 8de8384..34297e0 100644 --- a/tests/TestSuite_vxlan.py +++ b/tests/TestSuite_vxlan.py @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): if "inner_l4_invalid" in kwargs: self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) == self.l4err_num + 1, "Failed to count inner l4 chksum error") - self.l4err_num += 1 # verify detected l3 invalid checksum if "ip_invalid" in kwargs: -- 2.17.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid 2019-04-09 7:15 [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid changqingxwu @ 2019-04-09 8:05 ` Zhu, ShuaiX 2019-04-11 17:26 ` Tu, Lijuan 1 sibling, 0 replies; 5+ messages in thread From: Zhu, ShuaiX @ 2019-04-09 8:05 UTC (permalink / raw) To: Wu, ChangqingX, dts; +Cc: Wu, ChangqingX, Zhu, ShuaiX Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com> > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > Sent: Tuesday, April 9, 2019 3:15 PM > To: dts@dpdk.org > Cc: Wu, ChangqingX <changqingx.wu@intel.com> > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > Signed-off-by: changqingxwu <changqingx.wu@intel.com> > --- > tests/TestSuite_vxlan.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index > 8de8384..34297e0 100644 > --- a/tests/TestSuite_vxlan.py > +++ b/tests/TestSuite_vxlan.py > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > if "inner_l4_invalid" in kwargs: > self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) > == self.l4err_num + 1, "Failed to count inner l4 > chksum error") > - self.l4err_num += 1 > > # verify detected l3 invalid checksum > if "ip_invalid" in kwargs: > -- > 2.17.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid 2019-04-09 7:15 [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid changqingxwu 2019-04-09 8:05 ` Zhu, ShuaiX @ 2019-04-11 17:26 ` Tu, Lijuan 2019-04-12 1:36 ` Wu, ChangqingX 1 sibling, 1 reply; 5+ messages in thread From: Tu, Lijuan @ 2019-04-11 17:26 UTC (permalink / raw) To: Wu, ChangqingX, dts; +Cc: Wu, ChangqingX I am not quit catch your reason, I think when it catch "Bad-l4csum", and the number increases. So what is your consideration that remove the statement. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > Sent: Tuesday, April 9, 2019 12:15 AM > To: dts@dpdk.org > Cc: Wu, ChangqingX <changqingx.wu@intel.com> > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > Signed-off-by: changqingxwu <changqingx.wu@intel.com> > --- > tests/TestSuite_vxlan.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index > 8de8384..34297e0 100644 > --- a/tests/TestSuite_vxlan.py > +++ b/tests/TestSuite_vxlan.py > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > if "inner_l4_invalid" in kwargs: > self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) > == self.l4err_num + 1, "Failed to count inner l4 chksum error") > - self.l4err_num += 1 > > # verify detected l3 invalid checksum > if "ip_invalid" in kwargs: > -- > 2.17.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid 2019-04-11 17:26 ` Tu, Lijuan @ 2019-04-12 1:36 ` Wu, ChangqingX 2019-04-12 16:54 ` Tu, Lijuan 0 siblings, 1 reply; 5+ messages in thread From: Wu, ChangqingX @ 2019-04-12 1:36 UTC (permalink / raw) To: Tu, Lijuan, dts Dpdk made some code changes in the commit:53324971a14e02f5f710d6e73fe475650e9a9802, which effects method that tests the number of "Bad-l4csum", continuously sends 2 or more packets between start and stop, the number of "Bad-l4csum" Will accumulate, if stop, the number of "Bad-l4csum" will be reset, you can check: dpdk-11148, Yigit, Ferruh comments Thanks changqingx -----Original Message----- From: Tu, Lijuan Sent: Friday, April 12, 2019 1:26 AM To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org Cc: Wu, ChangqingX <changqingx.wu@intel.com> Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid I am not quit catch your reason, I think when it catch "Bad-l4csum", and the number increases. So what is your consideration that remove the statement. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > Sent: Tuesday, April 9, 2019 12:15 AM > To: dts@dpdk.org > Cc: Wu, ChangqingX <changqingx.wu@intel.com> > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > Signed-off-by: changqingxwu <changqingx.wu@intel.com> > --- > tests/TestSuite_vxlan.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index > 8de8384..34297e0 100644 > --- a/tests/TestSuite_vxlan.py > +++ b/tests/TestSuite_vxlan.py > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > if "inner_l4_invalid" in kwargs: > self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) > == self.l4err_num + 1, "Failed to count inner l4 chksum error") > - self.l4err_num += 1 > > # verify detected l3 invalid checksum > if "ip_invalid" in kwargs: > -- > 2.17.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid 2019-04-12 1:36 ` Wu, ChangqingX @ 2019-04-12 16:54 ` Tu, Lijuan 0 siblings, 0 replies; 5+ messages in thread From: Tu, Lijuan @ 2019-04-12 16:54 UTC (permalink / raw) To: Wu, ChangqingX, dts Could you please also send your reason while you commit a patch. So you should also remove the definition of self.l4err_num if it's never used at all. > -----Original Message----- > From: Wu, ChangqingX > Sent: Thursday, April 11, 2019 6:36 PM > To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > Dpdk made some code changes in the > commit:53324971a14e02f5f710d6e73fe475650e9a9802, which effects > method that tests the number of "Bad-l4csum", continuously sends 2 or > more packets between start and stop, the number of "Bad-l4csum" Will > accumulate, if stop, the number of "Bad-l4csum" will be reset, you can check: > dpdk-11148, Yigit, Ferruh comments > > > Thanks > changqingx > > -----Original Message----- > From: Tu, Lijuan > Sent: Friday, April 12, 2019 1:26 AM > To: Wu, ChangqingX <changqingx.wu@intel.com>; dts@dpdk.org > Cc: Wu, ChangqingX <changqingx.wu@intel.com> > Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > I am not quit catch your reason, I think when it catch "Bad-l4csum", and the > number increases. So what is your consideration that remove the statement. > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > > Sent: Tuesday, April 9, 2019 12:15 AM > > To: dts@dpdk.org > > Cc: Wu, ChangqingX <changqingx.wu@intel.com> > > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > > > Signed-off-by: changqingxwu <changqingx.wu@intel.com> > > --- > > tests/TestSuite_vxlan.py | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index > > 8de8384..34297e0 100644 > > --- a/tests/TestSuite_vxlan.py > > +++ b/tests/TestSuite_vxlan.py > > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > > if "inner_l4_invalid" in kwargs: > > self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) > > == self.l4err_num + 1, "Failed to count inner l4 chksum > error") > > - self.l4err_num += 1 > > > > # verify detected l3 invalid checksum > > if "ip_invalid" in kwargs: > > -- > > 2.17.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-12 16:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-09 7:15 [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid changqingxwu 2019-04-09 8:05 ` Zhu, ShuaiX 2019-04-11 17:26 ` Tu, Lijuan 2019-04-12 1:36 ` Wu, ChangqingX 2019-04-12 16:54 ` Tu, Lijuan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).