[dpdk-stable] [17.11] net/tap: fix reported number of Tx packets

[dpdk-stable] [17.11] net/tap: fix reported number of Tx packets

[Raslan Darawsheh]

When writev fails to send packets it doesn't update the
number of Tx packets, but it still num_tx is updated.

The value that should be returned is the actual number
of sent packets which is num_packets.

Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
CC: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Keith Wiles <keith.wiles@intel.com>
---
 drivers/net/tap/rte_eth_tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 466624a..50757ef 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 	txq->stats.errs += nb_pkts - num_tx;
 	txq->stats.obytes += num_tx_bytes;
 
-	return num_tx;
+	return num_packets;
 }
 
 static const char *
-- 
2.7.4

Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets

[Yongseok Koh]

> On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> 
> When writev fails to send packets it doesn't update the
> number of Tx packets, but it still num_tx is updated.
> 
> The value that should be returned is the actual number
> of sent packets which is num_packets.
> 
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> CC: stable@dpdk.org
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---

Raslan, it doesn't get compiled on stable/17.11

Thanks,
Yongseok

> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 466624a..50757ef 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> 	txq->stats.errs += nb_pkts - num_tx;
> 	txq->stats.obytes += num_tx_bytes;
> 
> -	return num_tx;
> +	return num_packets;
> }
> 
> static const char *
> -- 
> 2.7.4
> 

Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets

[Raslan Darawsheh]

Hi Yongseok,

I've just double check that, sorry for this issue, but it seems that we don't really need this patch for stable.

The issue that this patch solves came from the fact that when the call to writev fails It was updating num_tx,
but this is not the case for 17.11 so I believe we can drop this patch for 17.11

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Yongseok Koh
> Sent: Monday, January 14, 2019 6:24 AM
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: stable@dpdk.org
> Subject: Re: [17.11] net/tap: fix reported number of Tx packets
> 
> 
> > On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh <rasland@mellanox.com>
> wrote:
> >
> > When writev fails to send packets it doesn't update the number of Tx
> > packets, but it still num_tx is updated.
> >
> > The value that should be returned is the actual number of sent packets
> > which is num_packets.
> >
> > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> > Acked-by: Keith Wiles <keith.wiles@intel.com>
> > ---
> 
> Raslan, it doesn't get compiled on stable/17.11
> 
> Thanks,
> Yongseok
> 
> > drivers/net/tap/rte_eth_tap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/tap/rte_eth_tap.c
> > b/drivers/net/tap/rte_eth_tap.c index 466624a..50757ef 100644
> > --- a/drivers/net/tap/rte_eth_tap.c
> > +++ b/drivers/net/tap/rte_eth_tap.c
> > @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf
> **bufs, uint16_t nb_pkts)
> > 	txq->stats.errs += nb_pkts - num_tx;
> > 	txq->stats.obytes += num_tx_bytes;
> >
> > -	return num_tx;
> > +	return num_packets;
> > }
> >
> > static const char *
> > --
> > 2.7.4
> >

Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets

[Yongseok Koh]

> On Jan 13, 2019, at 11:46 PM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> 
> Hi Yongseok,
> 
> I've just double check that, sorry for this issue, but it seems that we don't really need this patch for stable.
> 
> The issue that this patch solves came from the fact that when the call to writev fails It was updating num_tx,
> but this is not the case for 17.11 so I believe we can drop this patch for 17.11

Got it.

Thanks,
Yongseok

>> -----Original Message-----
>> From: Yongseok Koh
>> Sent: Monday, January 14, 2019 6:24 AM
>> To: Raslan Darawsheh <rasland@mellanox.com>
>> Cc: stable@dpdk.org
>> Subject: Re: [17.11] net/tap: fix reported number of Tx packets
>> 
>> 
>>> On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh <rasland@mellanox.com>
>> wrote:
>>> 
>>> When writev fails to send packets it doesn't update the number of Tx
>>> packets, but it still num_tx is updated.
>>> 
>>> The value that should be returned is the actual number of sent packets
>>> which is num_packets.
>>> 
>>> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
>>> CC: stable@dpdk.org
>>> 
>>> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
>>> Acked-by: Keith Wiles <keith.wiles@intel.com>
>>> ---
>> 
>> Raslan, it doesn't get compiled on stable/17.11
>> 
>> Thanks,
>> Yongseok
>> 
>>> drivers/net/tap/rte_eth_tap.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/net/tap/rte_eth_tap.c
>>> b/drivers/net/tap/rte_eth_tap.c index 466624a..50757ef 100644
>>> --- a/drivers/net/tap/rte_eth_tap.c
>>> +++ b/drivers/net/tap/rte_eth_tap.c
>>> @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf
>> **bufs, uint16_t nb_pkts)
>>> 	txq->stats.errs += nb_pkts - num_tx;
>>> 	txq->stats.obytes += num_tx_bytes;
>>> 
>>> -	return num_tx;
>>> +	return num_packets;
>>> }
>>> 
>>> static const char *
>>> --
>>> 2.7.4
>>> 
>