[spp] [PATCH 0/2] Fix compile error with DPDK v18.08

[spp] [PATCH 0/2] Fix compile error with DPDK v18.08

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Compiling SPP with DPDK v18.08 causes some of erros and warnings
because of following reasons. This series of patches is to fix them.

* Tx queue configuration is not updated for the new Tx offload API.

* rte_eth_dev_attach/detach is deprecated but still remained.

Yasufumi Ogawa (2):
  shared: remove nouse txq_flags
  makefile: ignore deprecated declarations

 src/nfv/Makefile    | 1 +
 src/shared/common.c | 1 -
 src/vf/Makefile     | 1 +
 src/vm/Makefile     | 1 +
 4 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.7.4

[spp] [PATCH 1/2] shared: remove nouse txq_flags

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Txq_flags was deprecated since new Tx offload API is introduced on DPDK
v17.11. It is removed in v18.08 and cause a compile error if it is still
remained.

This patch is for removing nouse txq_flags from init_port().

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/shared/common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/shared/common.c b/src/shared/common.c
index fa33fcc..ea625f5 100644
--- a/src/shared/common.c
+++ b/src/shared/common.c
@@ -98,7 +98,6 @@ init_port(uint16_t port_num, struct rte_mempool *pktmbuf_pool)
 		local_port_conf.txmode.offloads |=
 			DEV_TX_OFFLOAD_MBUF_FAST_FREE;
 	txq_conf = dev_info.default_txconf;
-	txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
 	txq_conf.offloads = local_port_conf.txmode.offloads;
 
 	/*
-- 
2.7.4

[spp] [PATCH 2/2] makefile: ignore deprecated declarations

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Rte_eth_dev_attach() and rte_eth_dev_detach() is deprecated in DPDK
v18.08 and removed in v18.11. It should be replaced with
rte_eth_hotplug_add() and rte_eth_hotplug_remove().

This patch is for adding `-Wno-deprecated-declarations` to avoid
warnings while compilation as temporary. It should be fixed as described
above before v18.11 is released.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/nfv/Makefile | 1 +
 src/vf/Makefile  | 1 +
 src/vm/Makefile  | 1 +
 3 files changed, 3 insertions(+)

diff --git a/src/nfv/Makefile b/src/nfv/Makefile
index 4d5eec6..f40e0d1 100644
--- a/src/nfv/Makefile
+++ b/src/nfv/Makefile
@@ -16,6 +16,7 @@ SRCS-y := nfv.c ../shared/common.c
 
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
+CFLAGS += -Wno-deprecated-declarations
 
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
 LDLIBS += -lrte_pmd_ring
diff --git a/src/vf/Makefile b/src/vf/Makefile
index 43d3db0..189bf7d 100644
--- a/src/vf/Makefile
+++ b/src/vf/Makefile
@@ -16,6 +16,7 @@ SRCS-y := spp_vf.c classifier_mac.c spp_forward.c string_buffer.c command_conn.c
 
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
+CFLAGS += -Wno-deprecated-declarations
 #CFLAGS += -DSPP_DEMONIZE
 #CFLAGS += -DSPP_RINGLATENCYSTATS_ENABLE
 
diff --git a/src/vm/Makefile b/src/vm/Makefile
index 27ba47e..2392f47 100644
--- a/src/vm/Makefile
+++ b/src/vm/Makefile
@@ -26,6 +26,7 @@ INC := $(wildcard *.h)
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
+CFLAGS += -Wno-deprecated-declarations
 
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
 LDLIBS += -lrte_pmd_ring
-- 
2.7.4

Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08

[Hideyuki Yamashita]

Hello,

So far, it looks both patches are not merged into master branch.
I think change on makefile is tentative one and no need to merge.
But the other change on shared needs to be merged to master
because it is essentical change.

BR,
Hideyuki Yamashita
NTT TechnoCross

> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> 
> Compiling SPP with DPDK v18.08 causes some of erros and warnings
> because of following reasons. This series of patches is to fix them.
> 
> * Tx queue configuration is not updated for the new Tx offload API.
> 
> * rte_eth_dev_attach/detach is deprecated but still remained.
> 
> Yasufumi Ogawa (2):
>   shared: remove nouse txq_flags
>   makefile: ignore deprecated declarations
> 
>  src/nfv/Makefile    | 1 +
>  src/shared/common.c | 1 -
>  src/vf/Makefile     | 1 +
>  src/vm/Makefile     | 1 +
>  4 files changed, 3 insertions(+), 1 deletion(-)
> 
> -- 
> 2.7.4
> 

[spp] Cannnot add pcap PMD and null PMD via spp.py

[Hideyuki Yamashita]

Hello,

I am testing spp through spp-ctl/spp.py.

I encounter error when
- adding pcap PMD
- adding null PMD
though spp.py.

When I look source code of spp_webapi.py,
it looks type is not defined for neither null PMD or pcap PMD. 

    def _validate_port(self, port):
        try:
            if_type, if_num = port.split(":")
            if if_type not in ["phy", "vhost", "ring"]: //problematic    
                raise
            int(if_num)
        except:
            raise KeyInvalid('port', port)

It is highly appreciated that someone provide resolution on this.

Thanks in advance.

BR,
Hideyuki Yamashita
NTT TechnoCross

Re: [spp] Cannnot add pcap PMD and null PMD via spp.py

[Yasufumi Ogawa]

> Hello,
> 
> I am testing spp through spp-ctl/spp.py.
> 
> I encounter error when
> - adding pcap PMD
> - adding null PMD
> though spp.py.
> 
> When I look source code of spp_webapi.py,
> it looks type is not defined for neither null PMD or pcap PMD.
> 
>      def _validate_port(self, port):
>          try:
>              if_type, if_num = port.split(":")
>              if if_type not in ["phy", "vhost", "ring"]: //problematic
>                  raise
>              int(if_num)
>          except:
>              raise KeyInvalid('port', port)
> 
> It is highly appreciated that someone provide resolution on this.
Hi Hideyuki,

Sorry for lack of covering features. I should add the PMDs you mentioned and I will update soon.

Thanks
> 
> Thanks in advance.
> 
> BR,
> Hideyuki Yamashita
> NTT TechnoCross

Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08

[Yasufumi Ogawa]

Hi Hideyuki,

Could you tell me what is the point of your suggestion?

I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think 
it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the 
first patch soon, or it is OK later.

Thanks,
Yasufumi

> Hello,
> 
> So far, it looks both patches are not merged into master branch.
> I think change on makefile is tentative one and no need to merge.
> But the other change on shared needs to be merged to master
> because it is essentical change.
> 
> BR,
> Hideyuki Yamashita
> NTT TechnoCross
> 
>> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>>
>> Compiling SPP with DPDK v18.08 causes some of erros and warnings
>> because of following reasons. This series of patches is to fix them.
>>
>> * Tx queue configuration is not updated for the new Tx offload API.
>>
>> * rte_eth_dev_attach/detach is deprecated but still remained.
>>
>> Yasufumi Ogawa (2):
>>    shared: remove nouse txq_flags
>>    makefile: ignore deprecated declarations
>>
>>   src/nfv/Makefile    | 1 +
>>   src/shared/common.c | 1 -
>>   src/vf/Makefile     | 1 +
>>   src/vm/Makefile     | 1 +
>>   4 files changed, 3 insertions(+), 1 deletion(-)
>>
>> -- 
>> 2.7.4

Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08

[Hideyuki Yamashita]

Hello Yasufumi-san,

My suggestion is to apply the first patch soon
because without that patch, compile of spp encounters error.
Soon is better.

About replacing deprecaed functions, I am planning to provide patch 
after the above mentioned patch applied to master.

BR,
Hideyuki Yamashita
NTT TechnoCross

> Hi Hideyuki,
> 
> Could you tell me what is the point of your suggestion?
> 
> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later.
> 
> Thanks,
> Yasufumi
> 
> > Hello,
> >
> > So far, it looks both patches are not merged into master branch.
> > I think change on makefile is tentative one and no need to merge.
> > But the other change on shared needs to be merged to master
> > because it is essentical change.
> >
> > BR,
> > Hideyuki Yamashita
> > NTT TechnoCross
> >
> >> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> >>
> >> Compiling SPP with DPDK v18.08 causes some of erros and warnings
> >> because of following reasons. This series of patches is to fix them.
> >>
> >> * Tx queue configuration is not updated for the new Tx offload API.
> >>
> >> * rte_eth_dev_attach/detach is deprecated but still remained.
> >>
> >> Yasufumi Ogawa (2):
> >>    shared: remove nouse txq_flags
> >>    makefile: ignore deprecated declarations
> >>
> >>   src/nfv/Makefile    | 1 +
> >>   src/shared/common.c | 1 -
> >>   src/vf/Makefile     | 1 +
> >>   src/vm/Makefile     | 1 +
> >>   4 files changed, 3 insertions(+), 1 deletion(-)
> >>
> >> --
> >> 2.7.4

Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08

[Yasufumi Ogawa]

> Hello Yasufumi-san,
> 
> My suggestion is to apply the first patch soon
> because without that patch, compile of spp encounters error.
> Soon is better.
If you compile SPP with DPDK v18.08, yes.

> 
> About replacing deprecaed functions, I am planning to provide patch
> after the above mentioned patch applied to master.
Could you describe about your patch if you will update to v18.08? I think your patch is for replacing deprecated DPDK's APIs and 
your patch(es) is applied even if my patch is not applied before (of course, need both of patches for compiling). Anyway, you 
can send your patch anytime for reviewing.

Thanks,
> 
> BR,
> Hideyuki Yamashita
> NTT TechnoCross
> 
>> Hi Hideyuki,
>>
>> Could you tell me what is the point of your suggestion?
>>
>> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later.
>>
>> Thanks,
>> Yasufumi
>>
>>> Hello,
>>>
>>> So far, it looks both patches are not merged into master branch.
>>> I think change on makefile is tentative one and no need to merge.
>>> But the other change on shared needs to be merged to master
>>> because it is essentical change.
>>>
>>> BR,
>>> Hideyuki Yamashita
>>> NTT TechnoCross
>>>
>>>> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>>>>
>>>> Compiling SPP with DPDK v18.08 causes some of erros and warnings
>>>> because of following reasons. This series of patches is to fix them.
>>>>
>>>> * Tx queue configuration is not updated for the new Tx offload API.
>>>>
>>>> * rte_eth_dev_attach/detach is deprecated but still remained.
>>>>
>>>> Yasufumi Ogawa (2):
>>>>     shared: remove nouse txq_flags
>>>>     makefile: ignore deprecated declarations
>>>>
>>>>    src/nfv/Makefile    | 1 +
>>>>    src/shared/common.c | 1 -
>>>>    src/vf/Makefile     | 1 +
>>>>    src/vm/Makefile     | 1 +
>>>>    4 files changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> --
>>>> 2.7.4

Re: [spp] [spp 03509] Re: [PATCH 0/2] Fix compile error with DPDK v18.08

[Hideyuki Yamashita]

Hello yasufumi-san,

> > Hello Yasufumi-san,
> >
> > My suggestion is to apply the first patch soon
> > because without that patch, compile of spp encounters error.
> > Soon is better.
> If you compile SPP with DPDK v18.08, yes.
Thanks for your confirmation.

> >
> > About replacing deprecaed functions, I am planning to provide patch
> > after the above mentioned patch applied to master.
> Could you describe about your patch if you will update to v18.08?
Yes.

>I think your patch is for replacing deprecated DPDK's APIs and your
>patch(es) is applied even if my patch is not applied before (of course,
>need both of patches for compiling). Anyway, you can send your patch
>anytime for reviewing.
I share the same view with you now.
Then I will send my patches ASAP basis.

Thanks,
Hideyuki Yamashita
NTT TechnoCross

> Thanks,
> >
> > BR,
> > Hideyuki Yamashita
> > NTT TechnoCross
> >
> >> Hi Hideyuki,
> >>
> >> Could you tell me what is the point of your suggestion?
> >>
> >> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later.
> >>
> >> Thanks,
> >> Yasufumi
> >>
> >>> Hello,
> >>>
> >>> So far, it looks both patches are not merged into master branch.
> >>> I think change on makefile is tentative one and no need to merge.
> >>> But the other change on shared needs to be merged to master
> >>> because it is essentical change.
> >>>
> >>> BR,
> >>> Hideyuki Yamashita
> >>> NTT TechnoCross
> >>>
> >>>> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> >>>>
> >>>> Compiling SPP with DPDK v18.08 causes some of erros and warnings
> >>>> because of following reasons. This series of patches is to fix them.
> >>>>
> >>>> * Tx queue configuration is not updated for the new Tx offload API.
> >>>>
> >>>> * rte_eth_dev_attach/detach is deprecated but still remained.
> >>>>
> >>>> Yasufumi Ogawa (2):
> >>>>     shared: remove nouse txq_flags
> >>>>     makefile: ignore deprecated declarations
> >>>>
> >>>>    src/nfv/Makefile    | 1 +
> >>>>    src/shared/common.c | 1 -
> >>>>    src/vf/Makefile     | 1 +
> >>>>    src/vm/Makefile     | 1 +
> >>>>    4 files changed, 3 insertions(+), 1 deletion(-)
> >>>>
> >>>> --
> >>>> 2.7.4
>