* [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service
@ 2021-04-09 7:08 Shijith Thotton
2021-04-12 7:30 ` Jerin Jacob
2021-04-12 8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton
0 siblings, 2 replies; 7+ messages in thread
From: Shijith Thotton @ 2021-04-09 7:08 UTC (permalink / raw)
To: dev
Cc: Shijith Thotton, Abhinandan Gujjar, Jerin Jacob, Akhil Goyal,
Anoob Joseph
Initiate software crypto adapter service, only if hardware capabilities
are not reported.
Case 1.a. OP_FORWARD mode -> HW Dequeue + SW enqueue, should also check
OP_FORWARD capability is not supported by the PMD to initiate service.
Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
lib/librte_eventdev/rte_event_crypto_adapter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c
index d903cdd48..e1d38d383 100644
--- a/lib/librte_eventdev/rte_event_crypto_adapter.c
+++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
@@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t id,
* b. OP_NEW mode -> SW Dequeue
*/
if ((cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
+ !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
adapter->mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) ||
(!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) &&
!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service 2021-04-09 7:08 [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service Shijith Thotton @ 2021-04-12 7:30 ` Jerin Jacob 2021-04-12 8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton 1 sibling, 0 replies; 7+ messages in thread From: Jerin Jacob @ 2021-04-12 7:30 UTC (permalink / raw) To: Shijith Thotton Cc: dpdk-dev, Abhinandan Gujjar, Jerin Jacob, Akhil Goyal, Anoob Joseph On Fri, Apr 9, 2021 at 12:38 PM Shijith Thotton <sthotton@marvell.com> wrote: > > Initiate software crypto adapter service, only if hardware capabilities > are not reported. > > Case 1.a. OP_FORWARD mode -> HW Dequeue + SW enqueue, should also check Case 1.a is required in the commit message? > OP_FORWARD capability is not supported by the PMD to initiate service. > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > Signed-off-by: Shijith Thotton <sthotton@marvell.com> @Gujjar, Abhinandan S Any comments on this? > --- > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c > index d903cdd48..e1d38d383 100644 > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t id, > * b. OP_NEW mode -> SW Dequeue > */ > if ((cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > adapter->mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service 2021-04-09 7:08 [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service Shijith Thotton 2021-04-12 7:30 ` Jerin Jacob @ 2021-04-12 8:53 ` Shijith Thotton 2021-04-13 4:08 ` Gujjar, Abhinandan S 1 sibling, 1 reply; 7+ messages in thread From: Shijith Thotton @ 2021-04-12 8:53 UTC (permalink / raw) To: dev Cc: Shijith Thotton, Abhinandan Gujjar, Jerin Jacob, Akhil Goyal, Anoob Joseph Initiate software crypto adapter service, only if hardware capabilities are not reported. In OP_FORWARD mode, software service is not required to enqueue events if OP_FORWARD capability is supported by the PMD. Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") Signed-off-by: Shijith Thotton <sthotton@marvell.com> --- v2: - Reworded commit message. lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c index d903cdd48..e1d38d383 100644 --- a/lib/librte_eventdev/rte_event_crypto_adapter.c +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t id, * b. OP_NEW mode -> SW Dequeue */ if ((cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && adapter->mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service 2021-04-12 8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton @ 2021-04-13 4:08 ` Gujjar, Abhinandan S 2021-04-13 7:51 ` Shijith Thotton 0 siblings, 1 reply; 7+ messages in thread From: Gujjar, Abhinandan S @ 2021-04-13 4:08 UTC (permalink / raw) To: Shijith Thotton, dev; +Cc: Jerin Jacob, Akhil Goyal, Anoob Joseph > -----Original Message----- > From: Shijith Thotton <sthotton@marvell.com> > Sent: Monday, April 12, 2021 2:24 PM > To: dev@dpdk.org > Cc: Shijith Thotton <sthotton@marvell.com>; Gujjar, Abhinandan S > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>; Akhil > Goyal <gakhil@marvell.com>; Anoob Joseph <anoobj@marvell.com> > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter service > > Initiate software crypto adapter service, only if hardware capabilities are not > reported. In OP_FORWARD mode, software service is not required to > enqueue events if OP_FORWARD capability is supported by the PMD. > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > Signed-off-by: Shijith Thotton <sthotton@marvell.com> > --- > v2: > - Reworded commit message. > > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c > b/lib/librte_eventdev/rte_event_crypto_adapter.c > index d903cdd48..e1d38d383 100644 > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t > id, > * b. OP_NEW mode -> SW Dequeue > */ > if ((cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && The same check is below ORed with above condition. This is confusing. Could you recheck & do the necessary changes? > adapter->mode == > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > -- > 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service 2021-04-13 4:08 ` Gujjar, Abhinandan S @ 2021-04-13 7:51 ` Shijith Thotton 2021-04-14 7:06 ` Gujjar, Abhinandan S 0 siblings, 1 reply; 7+ messages in thread From: Shijith Thotton @ 2021-04-13 7:51 UTC (permalink / raw) To: Gujjar, Abhinandan S Cc: Shijith Thotton, dev, Jerin Jacob, Akhil Goyal, Anoob Joseph On Tue, Apr 13, 2021 at 04:08:40AM +0000, Gujjar, Abhinandan S wrote: > > > > -----Original Message----- > > From: Shijith Thotton <sthotton@marvell.com> > > Sent: Monday, April 12, 2021 2:24 PM > > To: dev@dpdk.org > > Cc: Shijith Thotton <sthotton@marvell.com>; Gujjar, Abhinandan S > > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>; Akhil > > Goyal <gakhil@marvell.com>; Anoob Joseph <anoobj@marvell.com> > > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter service > > > > Initiate software crypto adapter service, only if hardware capabilities are not > > reported. In OP_FORWARD mode, software service is not required to > > enqueue events if OP_FORWARD capability is supported by the PMD. > > > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > > > Signed-off-by: Shijith Thotton <sthotton@marvell.com> > > --- > > v2: > > - Reworded commit message. > > > > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c > > b/lib/librte_eventdev/rte_event_crypto_adapter.c > > index d903cdd48..e1d38d383 100644 > > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > > @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t > > id, > > * b. OP_NEW mode -> SW Dequeue > > */ > > if ((cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > > + !(cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > The same check is below ORed with above condition. > This is confusing. Could you recheck & do the necessary changes? > As per comments above, below checks are used to initiate SW service if: 1. PMDs supports OP_NEW, but not OP_FWD, in FWD mode. 2. Does not support OP_NEW and OP_FWD. I have fixed the first point where only support for OP_NEW is checked in forward mode, by adding a check for no OP_FWD capability. > > adapter->mode == > > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > > (!(cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > > !(cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > > -- > > 2.25.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service 2021-04-13 7:51 ` Shijith Thotton @ 2021-04-14 7:06 ` Gujjar, Abhinandan S 2021-04-17 17:24 ` Jerin Jacob 0 siblings, 1 reply; 7+ messages in thread From: Gujjar, Abhinandan S @ 2021-04-14 7:06 UTC (permalink / raw) To: Shijith Thotton Cc: Shijith Thotton, dev, Jerin Jacob, Akhil Goyal, Anoob Joseph > -----Original Message----- > From: Shijith Thotton <shijith.thotton@gmail.com> > Sent: Tuesday, April 13, 2021 1:21 PM > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com> > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Jerin Jacob > <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Anoob Joseph > <anoobj@marvell.com> > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto > adapter service > > On Tue, Apr 13, 2021 at 04:08:40AM +0000, Gujjar, Abhinandan S wrote: > > > > > > > -----Original Message----- > > > From: Shijith Thotton <sthotton@marvell.com> > > > Sent: Monday, April 12, 2021 2:24 PM > > > To: dev@dpdk.org > > > Cc: Shijith Thotton <sthotton@marvell.com>; Gujjar, Abhinandan S > > > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>; > > > Akhil Goyal <gakhil@marvell.com>; Anoob Joseph > <anoobj@marvell.com> > > > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter > > > service > > > > > > Initiate software crypto adapter service, only if hardware > > > capabilities are not reported. In OP_FORWARD mode, software service > > > is not required to enqueue events if OP_FORWARD capability is > supported by the PMD. > > > > > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > > > > > Signed-off-by: Shijith Thotton <sthotton@marvell.com> > > > --- > > > v2: > > > - Reworded commit message. > > > > > > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c > > > b/lib/librte_eventdev/rte_event_crypto_adapter.c > > > index d903cdd48..e1d38d383 100644 > > > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > > > @@ -861,6 +861,7 @@ > rte_event_crypto_adapter_queue_pair_add(uint8_t > > > id, > > > * b. OP_NEW mode -> SW Dequeue > > > */ > > > if ((cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > > > + !(cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > > The same check is below ORed with above condition. > > This is confusing. Could you recheck & do the necessary changes? > > > > As per comments above, below checks are used to initiate SW service if: > 1. PMDs supports OP_NEW, but not OP_FWD, in FWD mode. > 2. Does not support OP_NEW and OP_FWD. > > I have fixed the first point where only support for OP_NEW is checked in > forward mode, by adding a check for no OP_FWD capability. Sounds good. Acked-by: Abhinandan.gujjar@intel.com > > > > adapter->mode == > > > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > > > (!(cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > > > !(cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > > > -- > > > 2.25.1 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service 2021-04-14 7:06 ` Gujjar, Abhinandan S @ 2021-04-17 17:24 ` Jerin Jacob 0 siblings, 0 replies; 7+ messages in thread From: Jerin Jacob @ 2021-04-17 17:24 UTC (permalink / raw) To: Gujjar, Abhinandan S Cc: Shijith Thotton, Shijith Thotton, dev, Jerin Jacob, Akhil Goyal, Anoob Joseph On Wed, Apr 14, 2021 at 12:36 PM Gujjar, Abhinandan S <abhinandan.gujjar@intel.com> wrote: > > > > > -----Original Message----- > > From: Shijith Thotton <shijith.thotton@gmail.com> > > Sent: Tuesday, April 13, 2021 1:21 PM > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com> > > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Jerin Jacob > > <jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Anoob Joseph > > <anoobj@marvell.com> > > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto > > adapter service > > > > As per comments above, below checks are used to initiate SW service if: > > 1. PMDs supports OP_NEW, but not OP_FWD, in FWD mode. > > 2. Does not support OP_NEW and OP_FWD. > > > > I have fixed the first point where only support for OP_NEW is checked in > > forward mode, by adding a check for no OP_FWD capability. > Sounds good. > > Acked-by: Abhinandan.gujjar@intel.com Applied to dpdk-next-eventdev/for-main. Thanks. > > > > > > > adapter->mode == > > > > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > > > > (!(cap & > > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > > > > !(cap & > > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > > > > -- > > > > 2.25.1 > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-17 17:24 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-09 7:08 [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service Shijith Thotton 2021-04-12 7:30 ` Jerin Jacob 2021-04-12 8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton 2021-04-13 4:08 ` Gujjar, Abhinandan S 2021-04-13 7:51 ` Shijith Thotton 2021-04-14 7:06 ` Gujjar, Abhinandan S 2021-04-17 17:24 ` Jerin Jacob
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).