From: "谢华伟(此时此刻)" <huawei.xhw@alibaba-inc.com> To: Maxime Coquelin <maxime.coquelin@redhat.com>, ferruh.yigit@intel.com Cc: dev@dpdk.org, anatoly.burakov@intel.com, david.marchand@redhat.com, zhihong.wang@intel.com, chenbo.xia@intel.com, grive@u256.net Subject: Re: [dpdk-dev] [PATCH v5 2/3] PCI: support MMIO in rte_pci_ioport_map/unap/read/write Date: Thu, 21 Jan 2021 14:30:09 +0800 Message-ID: <48b27ce4-99c7-5e18-4cfa-0e9bf472d719@alibaba-inc.com> (raw) In-Reply-To: <9dfad03c-d1db-5756-d222-2e9c2f8da65a@redhat.com> On 2021/1/12 16:23, Maxime Coquelin wrote: > Title should be something like: > > "bus/pci: support MMIO in PCI ioport accessors > > On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: >> From: "huawei.xhw" <huawei.xhw@alibaba-inc.com> >> >> If IO BAR, we get PIO address. >> If MMIO BAR, we get mapped virtual address. >> We distinguish PIO and MMIO by their address like how kernel does. >> ioread/write8/16/32 is provided to access PIO/MMIO. >> BTW, for virtio on arch other than x86, BAR flag indicates PIO but is mapped. > No acronym in the commit message. BTW? fixed. PIO(programmed IO) and MMIO(memory mapped IO) explained. > Also, I am not sure to understand this comment. > Does it means in the case of ARM for example, the IORESOURCE_IO flag is > set but the base address is above PIO_MAX? ARM doesn't have PIO but only MMIO. The device sets IORESOURCE_IO flag anyway. Should i remove this message as it causes confuse? > >> Signed-off-by: huawei.xhw <huawei.xhw@alibaba-inc.com> > As in previous patch, we need your full name for the sign-off. fixed. > >> --- >> drivers/bus/pci/linux/pci.c | 4 -- >> drivers/bus/pci/linux/pci_uio.c | 123 ++++++++++++++++++++++++++-------------- >> 2 files changed, 82 insertions(+), 45 deletions(-) >> >> diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c >> index 0f38abf..0dc99e9 100644 >> --- a/drivers/bus/pci/linux/pci.c >> +++ b/drivers/bus/pci/linux/pci.c >> @@ -715,8 +715,6 @@ int rte_pci_write_config(const struct rte_pci_device *device, >> break; >> #endif >> case RTE_PCI_KDRV_IGB_UIO: >> - pci_uio_ioport_read(p, data, len, offset); >> - break; > I think this part should be in patch 1. Patch 1 handles IO port map. Patch 2 unifies IO/MMIO. Patch 3 handles vfio. I feel current split is more clear. > >> case RTE_PCI_KDRV_UIO_GENERIC: >> pci_uio_ioport_read(p, data, len, offset); >> break; >> @@ -736,8 +734,6 @@ int rte_pci_write_config(const struct rte_pci_device *device, >> break; >> #endif >> case RTE_PCI_KDRV_IGB_UIO: >> - pci_uio_ioport_write(p, data, len, offset); >> - break; > Same here. > >> case RTE_PCI_KDRV_UIO_GENERIC: >> pci_uio_ioport_write(p, data, len, offset); >> break; >> diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c >> index 01f2a40..c19382f 100644 >> --- a/drivers/bus/pci/linux/pci_uio.c >> +++ b/drivers/bus/pci/linux/pci_uio.c >> @@ -379,14 +379,9 @@ >> char buf[BUFSIZ]; >> uint64_t phys_addr, end_addr, flags; >> unsigned long base; >> + bool iobar; >> int i; >> >> - if (rte_eal_iopl_init() != 0) { >> - RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for PCI device %s\n", >> - __func__, dev->name); >> - return -1; >> - } >> - >> /* open and read addresses of the corresponding resource in sysfs */ >> snprintf(filename, sizeof(filename), "%s/" PCI_PRI_FMT "/resource", >> rte_pci_get_sysfs_path(), dev->addr.domain, dev->addr.bus, >> @@ -408,15 +403,30 @@ >> &end_addr, &flags) < 0) >> goto error; >> >> - if (!(flags & IORESOURCE_IO)) { >> - RTE_LOG(ERR, EAL, "%s(): bar resource other than IO is not supported\n", __func__); >> + if (flags & IORESOURCE_IO) { >> + iobar = 1; >> + base = (unsigned long)phys_addr; >> + RTE_LOG(INFO, EAL, "%s(): PIO BAR %08lx detected\n", __func__, base); >> + } else if (flags & IORESOURCE_MEM) { >> + iobar = 0; >> + base = (unsigned long)dev->mem_resource[bar].addr; >> + RTE_LOG(INFO, EAL, "%s(): MMIO BAR %08lx detected\n", __func__, base); >> + } else { >> + RTE_LOG(ERR, EAL, "%s(): unknown BAR type\n", __func__); >> + goto error; >> + } >> + >> + >> + if (iobar && rte_eal_iopl_init() != 0) { >> + RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for PCI device %s\n", >> + __func__, dev->name); >> goto error; >> } >> - base = (unsigned long)phys_addr; >> - RTE_LOG(INFO, EAL, "%s(): PIO BAR %08lx detected\n", __func__, base); >> >> - if (base > UINT16_MAX) >> + if (iobar && (base > UINT16_MAX)) { >> + RTE_LOG(ERR, EAL, "%s(): %08lx too large PIO resource\n", __func__, base); >> goto error; >> + } > It looks like above check could be moved directly to (flags & > IORESOURCE_IO) case, so iobar boolean is not needed. yes, code is more clear with your suggestion.
next prev parent reply other threads:[~2021-01-21 6:30 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 14:59 [dpdk-dev] [PATCH v2] pci: support both PIO and MMIO BAR for legacy virtio on x86 谢华伟(此时此刻) 2020-10-01 10:22 ` Burakov, Anatoly 2020-10-02 5:44 ` 谢华伟(此时此刻) 2020-10-09 8:36 ` [dpdk-dev] [PATCH v3] " 谢华伟(此时此刻) 2020-10-13 8:41 ` [dpdk-dev] [PATCH v4] support both PIO and MMIO bar for virtio pci device 谢华伟(此时此刻) 2020-10-13 8:41 ` [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86 谢华伟(此时此刻) 2020-10-13 12:34 ` 谢华伟(此时此刻) 2020-10-21 8:46 ` 谢华伟(此时此刻) 2020-10-21 11:49 ` Ferruh Yigit 2020-10-21 12:32 ` 谢华伟(此时此刻) 2020-10-21 17:24 ` Ferruh Yigit 2020-10-22 9:15 ` 谢华伟(此时此刻) 2020-10-22 9:44 ` Ferruh Yigit 2020-10-22 9:57 ` 谢华伟(此时此刻) 2020-10-22 15:51 ` [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD 谢华伟(此时此刻) 2020-10-22 15:51 ` [dpdk-dev] [PATCH v5 1/3] PCI: use PCI standard sysfs entry to get PIO address 谢华伟(此时此刻) 2021-01-12 8:07 ` Maxime Coquelin 2021-01-14 18:23 ` 谢华伟(此时此刻) 2021-01-24 15:10 ` Xueming(Steven) Li 2020-10-22 15:51 ` [dpdk-dev] [PATCH v5 2/3] PCI: support MMIO in rte_pci_ioport_map/unap/read/write 谢华伟(此时此刻) 2021-01-12 8:23 ` Maxime Coquelin 2021-01-21 6:30 ` 谢华伟(此时此刻) [this message] 2021-01-24 15:22 ` Xueming(Steven) Li 2021-01-25 3:08 ` 谢华伟(此时此刻) 2021-01-27 10:40 ` Ferruh Yigit 2021-01-27 15:34 ` 谢华伟(此时此刻) 2021-01-27 16:45 ` Ferruh Yigit 2020-10-22 15:51 ` [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource 谢华伟(此时此刻) 2021-01-12 9:37 ` Maxime Coquelin 2021-01-12 16:58 ` Maxime Coquelin 2021-01-20 14:54 ` 谢华伟(此时此刻) 2021-01-21 8:29 ` Maxime Coquelin 2021-01-21 14:57 ` 谢华伟(此时此刻) 2021-01-21 15:00 ` 谢华伟(此时此刻) 2021-01-21 15:38 ` Maxime Coquelin 2021-01-22 7:25 ` 谢华伟(此时此刻) 2021-01-26 10:44 ` Maxime Coquelin 2021-01-27 10:32 ` Ferruh Yigit 2021-01-27 12:17 ` Maxime Coquelin 2021-01-27 14:43 ` 谢华伟(此时此刻) 2021-01-27 16:45 ` Ferruh Yigit 2021-01-28 13:43 ` 谢华伟(此时此刻) 2021-01-26 12:30 ` 谢华伟(此时此刻) 2021-01-26 12:35 ` Maxime Coquelin 2021-01-26 14:24 ` 谢华伟(此时此刻) 2020-10-27 8:50 ` [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD 谢华伟(此时此刻) 2020-10-28 3:48 ` 谢华伟(此时此刻) 2020-11-02 11:56 ` 谢华伟(此时此刻) 2020-11-10 12:35 ` 谢华伟(此时此刻) 2020-11-10 12:42 ` David Marchand 2020-11-12 13:35 ` 谢华伟(此时此刻) 2020-12-14 14:24 ` 谢华伟(此时此刻) 2020-12-16 7:54 ` Maxime Coquelin 2021-01-12 17:37 ` Maxime Coquelin 2021-01-14 18:19 ` 谢华伟(此时此刻) 2021-01-21 4:12 ` 谢华伟(此时此刻) 2021-01-21 8:47 ` Maxime Coquelin 2021-01-21 13:51 ` 谢华伟(此时此刻)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=48b27ce4-99c7-5e18-4cfa-0e9bf472d719@alibaba-inc.com \ --to=huawei.xhw@alibaba-inc.com \ --cc=anatoly.burakov@intel.com \ --cc=chenbo.xia@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=grive@u256.net \ --cc=maxime.coquelin@redhat.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git