DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test
@ 2014-06-30 14:42 Pablo de Lara
  2014-07-01  8:31 ` Olivier MATZ
  0 siblings, 1 reply; 9+ messages in thread
From: Pablo de Lara @ 2014-06-30 14:42 UTC (permalink / raw)
  To: dev

From: Pablo de Lara <pablo.de.lara.guarch@intel.com>

In whitelist test, within EAL flags unit test, vdev flag
was being tested, but test fails, as a secondary process
cannot allocate memzones, so it cannot create the device
and application exits. Also, this can be tested in ring
pmd test, which needs vdev and not in whitelist, which
should only test --pci-whitelist.

Patch "app/test: fix build switches to enable cmdline tests"
from Thomas Monjalon is needed for this patch.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test/test_eal_flags.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 1b80b80..7c6656b 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -58,7 +58,6 @@
 #define no_huge "--no-huge"
 #define no_shconf "--no-shconf"
 #define pci_whitelist "--pci-whitelist"
-#define vdev "--vdev"
 #define memtest "memtest"
 #define memtest1 "memtest1"
 #define memtest2 "memtest2"
@@ -317,9 +316,6 @@ test_whitelist_flag(void)
 	const char *wlval3[] = {prgname, prefix, mp_flag, "-n", "1", "-c", "1",
 			pci_whitelist, "09:0B.3,type=test",
 			pci_whitelist, "08:00.1,type=normal",
-#ifdef RTE_LIBRTE_PMD_RING
-			vdev, "eth_ring,arg=test",
-#endif
 	};
 
 	for (i = 0; i < sizeof(wlinval) / sizeof(wlinval[0]); i++) {
-- 
1.7.0.7

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-07-01 12:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-30 14:42 [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test Pablo de Lara
2014-07-01  8:31 ` Olivier MATZ
2014-07-01  8:32   ` [dpdk-dev] [PATCH] app/test: fix vdev test in test_eal_flags Olivier Matz
2014-07-01  8:59   ` [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test De Lara Guarch, Pablo
2014-07-01  9:20     ` Olivier MATZ
2014-07-01  9:21       ` [dpdk-dev] [PATCH v2] app/test: fix vdev test in test_eal_flags Olivier Matz
2014-07-01 11:44         ` De Lara Guarch, Pablo
2014-07-01 12:00           ` Olivier MATZ
2014-07-01 12:11             ` De Lara Guarch, Pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).