DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/iavf: fix performance drop
@ 2021-04-26  5:29 Wenzhuo Lu
  2021-04-26  9:04 ` Zhang, Qi Z
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Wenzhuo Lu @ 2021-04-26  5:29 UTC (permalink / raw)
  To: dev; +Cc: Wenzhuo Lu

AVX2 and SSE don't have the offload path.
Not necessary doing any check. Or the scalar path
will be chosen.

Fixes: eff56a7b9f97 ("net/iavf: add offload path for Rx AVX512")

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/iavf/iavf_rxtx.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 3f3cf63..0ba19dbf 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2401,13 +2401,11 @@
 	check_ret = iavf_rx_vec_dev_check(dev);
 	if (check_ret >= 0 &&
 	    rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) {
-		if (check_ret == IAVF_VECTOR_PATH) {
-			use_sse = true;
-			if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
-			     rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
-			    rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256)
-				use_avx2 = true;
-		}
+		use_sse = true;
+		if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
+		     rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
+		    rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256)
+			use_avx2 = true;
 
 #ifdef CC_AVX512_SUPPORT
 		if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
-- 
1.9.3


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-04-29  3:20 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26  5:29 [dpdk-dev] [PATCH] net/iavf: fix performance drop Wenzhuo Lu
2021-04-26  9:04 ` Zhang, Qi Z
2021-04-27  1:51   ` Lu, Wenzhuo
2021-04-27  2:57     ` Zhang, Qi Z
2021-04-27  5:09       ` Lu, Wenzhuo
2021-04-28 11:32       ` Ferruh Yigit
2021-04-28 12:06         ` Zhang, Qi Z
2021-04-27  5:19 ` Zhang, Qi Z
2021-04-28 11:32 ` Ferruh Yigit
2021-04-29  1:08   ` Lu, Wenzhuo
2021-04-29  1:33 ` Wenzhuo Lu
2021-04-29  3:20   ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).