DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs
@ 2014-09-01 10:24 David Marchand
  2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro David Marchand
                   ` (17 more replies)
  0 siblings, 18 replies; 30+ messages in thread
From: David Marchand @ 2014-09-01 10:24 UTC (permalink / raw)
  To: dev

Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs.
The idea behind this is to make it easier to debug some init failures and to be
sure of the datapath selected in these PMDs (rx / tx handlers selection).

The PMDs changes involve adding more debug messages in the default build.
A new eal option has been added to set the default log level, so that you can
render the eal a little less noisy.

I did not change the default log level for now, as some eal log messages are
marked as DEBUG while being interesting (from my point of view).
I suppose we can change the default log level later once the eal has been
cleaned up.

Changes since v2:
- continue clean up by always using PMD_*_LOG when logging something in
  PMD (i.e. no more printf, RTE_LOG, DEBUGOUT)
- introduce PMD_DRV_LOG_RAW macro for use by shared driver code
- adopt 'second approach': no more \n in PMD_*_LOG callers. This means that we
  will enforce a 'no \n' policy in logs for PMD.

-- 
David Marchand

David Marchand (17):
  ixgbe: use the right debug macro
  ixgbe/base: add a _RAW macro for use by shared code
  ixgbe: clean log messages
  ixgbe: always log init messages
  ixgbe: add a message when forcing scatter mode
  ixgbe: add log messages when rx bulk mode is not usable
  i40e: use the right debug macro
  i40e/base: add a _RAW macro for use by shared code
  i40e: clean log messages
  i40e: always log init messages
  i40e: add log messages when rx bulk mode is not usable
  e1000: use the right debug macro
  e1000/base: add a _RAW macro for use by shared code
  e1000: clean log messages
  e1000: always log init messages
  e1000: add a message when forcing scatter mode
  eal: set log level from command line

 lib/librte_eal/bsdapp/eal/eal.c                    |   42 ++
 .../bsdapp/eal/include/eal_internal_cfg.h          |    1 +
 lib/librte_eal/linuxapp/eal/eal.c                  |   44 +-
 .../linuxapp/eal/include/eal_internal_cfg.h        |    1 +
 lib/librte_pmd_e1000/e1000/e1000_osdep.h           |    4 +-
 lib/librte_pmd_e1000/e1000_logs.h                  |   18 +-
 lib/librte_pmd_e1000/em_ethdev.c                   |   64 ++-
 lib/librte_pmd_e1000/em_rxtx.c                     |  137 +++---
 lib/librte_pmd_e1000/igb_ethdev.c                  |  100 +++--
 lib/librte_pmd_e1000/igb_pf.c                      |    5 +-
 lib/librte_pmd_e1000/igb_rxtx.c                    |   69 ++--
 lib/librte_pmd_i40e/i40e/i40e_osdep.h              |    8 +-
 lib/librte_pmd_i40e/i40e_ethdev.c                  |  434 ++++++++++----------
 lib/librte_pmd_i40e/i40e_ethdev_vf.c               |  168 ++++----
 lib/librte_pmd_i40e/i40e_logs.h                    |   16 +-
 lib/librte_pmd_i40e/i40e_pf.c                      |   79 ++--
 lib/librte_pmd_i40e/i40e_rxtx.c                    |  201 +++++----
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h           |    4 +-
 lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c          |   14 +-
 lib/librte_pmd_ixgbe/ixgbe_bypass.c                |   26 +-
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c                |  177 ++++----
 lib/librte_pmd_ixgbe/ixgbe_fdir.c                  |    6 +-
 lib/librte_pmd_ixgbe/ixgbe_logs.h                  |   16 +-
 lib/librte_pmd_ixgbe/ixgbe_pf.c                    |    4 +-
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c                  |  169 +++++---
 25 files changed, 979 insertions(+), 828 deletions(-)

-- 
1.7.10.4

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2014-09-12 12:27 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-01 10:24 [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro David Marchand
2014-09-02 13:43   ` Jay Rolette
2014-09-02 14:16     ` David Marchand
2014-09-02 14:21       ` Thomas Monjalon
2014-09-02 17:57         ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 02/17] ixgbe/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 03/17] ixgbe: clean log messages David Marchand
2014-09-02 15:19   ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 04/17] ixgbe: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 05/17] ixgbe: add a message when forcing scatter mode David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 06/17] ixgbe: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 07/17] i40e: use the right debug macro David Marchand
2014-09-02 18:25   ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 08/17] i40e/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 09/17] i40e: clean log messages David Marchand
2014-09-02 18:20   ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 10/17] i40e: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 11/17] i40e: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 12/17] e1000: use the right debug macro David Marchand
2014-09-02 18:29   ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 13/17] e1000/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 14/17] e1000: clean log messages David Marchand
2014-09-02 19:05   ` Jay Rolette
2014-09-02 19:19     ` David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 15/17] e1000: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 16/17] e1000: add a message when forcing scatter mode David Marchand
2014-09-02 19:20   ` David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 17/17] eal: set log level from command line David Marchand
2014-09-12 12:32 ` [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).